[GitHub] [hudi] watermelon12138 commented on a diff in pull request #8308: [HUDI-5994] Bucket index supports bulk insert mode.

["watermelon12138 (via GitHub)" <gi...@apache.org>]

watermelon12138 commented on code in PR #8308:
URL: https://github.com/apache/hudi/pull/8308#discussion_r1152699437


##########
hudi-client/hudi-client-common/src/main/java/org/apache/hudi/index/bucket/BucketIdentifier.java:
##########
@@ -91,6 +91,10 @@ public static String newBucketFileIdPrefix(int bucketId) {
     return newBucketFileIdPrefix(bucketIdStr(bucketId));
   }
 
+  public static String newBucketFileIdPrefix(String fileId, int bucketId) {

Review Comment:
   No, newBucketFileIdPrefix(String fileId, int bucketId) function can make BulkInsertBucketInternalWriterHelper use the super function getNextFileId() of BulkInsertDataInternalWriterHelper. if we try to use the newBucketFileIdPrefix(String bucketId), we need to modify the getNextFileId() in BulkInsertDataInternalWriterHelper.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org