You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@flink.apache.org by "ASF GitHub Bot (JIRA)" <ji...@apache.org> on 2017/02/21 08:59:44 UTC
[jira] [Commented] (FLINK-4754) Make number of retained checkpoints
user configurable
[ https://issues.apache.org/jira/browse/FLINK-4754?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15875626#comment-15875626 ]
ASF GitHub Bot commented on FLINK-4754:
---------------------------------------
GitHub user tony810430 opened a pull request:
https://github.com/apache/flink/pull/3374
[FLINK-4754] [checkpoints] Make number of retained checkpoints user configurable
I add `CheckpointConfig.setMaxNumberOfCheckpointsToRetain` to expose user the configuration for number of retained checkpoints, and update the constructor of `JobSnapshottingSettings` to pass the value to `CheckpointRecoveryFactory`.
However, I didn't make this value lazily in the checkpoint store implementations.
It is useful to make it lazily if there is a need to reconfigure it during job is running, but I think that should be another issue.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/tony810430/flink FLINK-4754
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/flink/pull/3374.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #3374
----
commit d475017c29d9c8b91f740227b439d9fa7da152b3
Author: Tony Wei <to...@gmail.com>
Date: 2017-02-20T10:30:24Z
[FLINK-4754] Make number of retained checkpoints user configurable
----
> Make number of retained checkpoints user configurable
> -----------------------------------------------------
>
> Key: FLINK-4754
> URL: https://issues.apache.org/jira/browse/FLINK-4754
> Project: Flink
> Issue Type: Improvement
> Components: State Backends, Checkpointing
> Affects Versions: 1.1.2
> Reporter: Ufuk Celebi
> Assignee: Wei-Che Wei
>
> The number of retained successful checkpoints is fixed to 1. Expose this setting via the {{CheckpointConfig}} instead of having it fixed as a static field in the {{CheckpointRecoveryFactory}}.
> With the current state of things, this would require to set this value lazily in the checkpoint store implementations instead of setting it when creating the store.
--
This message was sent by Atlassian JIRA
(v6.3.15#6346)