[GitHub] [spark] gengliangwang commented on a diff in pull request #41429: [SPARK-43922] Add named parameter support in parser for function calls

["gengliangwang (via GitHub)" <gi...@apache.org>]

gengliangwang commented on code in PR #41429:
URL: https://github.com/apache/spark/pull/41429#discussion_r1228957857


##########
sql/catalyst/src/main/antlr4/org/apache/spark/sql/catalyst/parser/SqlBaseParser.g4:
##########
@@ -862,6 +862,15 @@ expression
     : booleanExpression
     ;
 
+namedArgumentExpression
+    : key=identifier FAT_ARROW value=expression

Review Comment:
   identifier can be quoted and unquoted
   Shall we make it `IDENTIFIER`(unquoted) only?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org