You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@cassandra.apache.org by "Sandeep Tata (JIRA)" <ji...@apache.org> on 2009/05/07 22:32:45 UTC
[jira] Created: (CASSANDRA-154) Change thrift interface to allow
#endpoints as a parameter to insert calls
Change thrift interface to allow #endpoints as a parameter to insert calls
--------------------------------------------------------------------------
Key: CASSANDRA-154
URL: https://issues.apache.org/jira/browse/CASSANDRA-154
Project: Cassandra
Issue Type: Sub-task
Affects Versions: trunk
Reporter: Sandeep Tata
Assignee: Sandeep Tata
Fix For: trunk
Thrift API changes to support CASSANDRA-140.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (CASSANDRA-154) Change thrift interface to allow
#endpoints as a parameter to insert calls
Posted by "Jonathan Ellis (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/CASSANDRA-154?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12707091#action_12707091 ]
Jonathan Ellis commented on CASSANDRA-154:
------------------------------------------
if you're allergic to posting multiple patches to one ticket, at least link the sub-tasks to the parent. :)
> Change thrift interface to allow #endpoints as a parameter to insert calls
> --------------------------------------------------------------------------
>
> Key: CASSANDRA-154
> URL: https://issues.apache.org/jira/browse/CASSANDRA-154
> Project: Cassandra
> Issue Type: Sub-task
> Affects Versions: trunk
> Reporter: Sandeep Tata
> Assignee: Sandeep Tata
> Fix For: trunk
>
>
> Thrift API changes to support CASSANDRA-140.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (CASSANDRA-154) Change thrift interface to allow
#endpoints as a parameter to insert calls
Posted by "Sandeep Tata (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/CASSANDRA-154?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Sandeep Tata updated CASSANDRA-154:
-----------------------------------
Attachment: CASSANDRA-154-src.patch
CASSANDRA-154-interface.patch
Remade to apply against trunk.
> Change thrift interface to allow #endpoints as a parameter to insert calls
> --------------------------------------------------------------------------
>
> Key: CASSANDRA-154
> URL: https://issues.apache.org/jira/browse/CASSANDRA-154
> Project: Cassandra
> Issue Type: Sub-task
> Affects Versions: trunk
> Reporter: Sandeep Tata
> Assignee: Sandeep Tata
> Fix For: trunk
>
> Attachments: CASSANDRA-154-interface.patch, CASSANDRA-154-src.patch, CASSANDRA-154.patch
>
>
> Thrift API changes to support CASSANDRA-140.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (CASSANDRA-154) Change thrift interface to allow
#endpoints as a parameter to insert calls
Posted by "Jonathan Ellis (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/CASSANDRA-154?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12709533#action_12709533 ]
Jonathan Ellis commented on CASSANDRA-154:
------------------------------------------
can we call the i32 `block_for` instead of `block`?
> Change thrift interface to allow #endpoints as a parameter to insert calls
> --------------------------------------------------------------------------
>
> Key: CASSANDRA-154
> URL: https://issues.apache.org/jira/browse/CASSANDRA-154
> Project: Cassandra
> Issue Type: Sub-task
> Affects Versions: trunk
> Reporter: Sandeep Tata
> Assignee: Sandeep Tata
> Fix For: trunk
>
> Attachments: CASSANDRA-154.patch
>
>
> Thrift API changes to support CASSANDRA-140.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (CASSANDRA-154) Change thrift interface to allow
#endpoints as a parameter to insert calls
Posted by "Hudson (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/CASSANDRA-154?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12711119#action_12711119 ]
Hudson commented on CASSANDRA-154:
----------------------------------
Integrated in Cassandra #82 (See [http://hudson.zones.apache.org/hudson/job/Cassandra/82/])
add block_for parameter to insert calls. patch by Sandeep Tata; reviewed by jbellis for
> Change thrift interface to allow #endpoints as a parameter to insert calls
> --------------------------------------------------------------------------
>
> Key: CASSANDRA-154
> URL: https://issues.apache.org/jira/browse/CASSANDRA-154
> Project: Cassandra
> Issue Type: Sub-task
> Affects Versions: trunk
> Reporter: Sandeep Tata
> Assignee: Sandeep Tata
> Fix For: trunk
>
> Attachments: 154-addendum.patch, CASSANDRA-154-interface-v2.patch, CASSANDRA-154-interface.patch, CASSANDRA-154-src-v2.patch, CASSANDRA-154-src.patch, CASSANDRA-154.patch
>
>
> Thrift API changes to support CASSANDRA-140.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (CASSANDRA-154) Change thrift interface to allow
#endpoints as a parameter to insert calls
Posted by "Sandeep Tata (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/CASSANDRA-154?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12709536#action_12709536 ]
Sandeep Tata commented on CASSANDRA-154:
----------------------------------------
Sure, block_for is better.
> Change thrift interface to allow #endpoints as a parameter to insert calls
> --------------------------------------------------------------------------
>
> Key: CASSANDRA-154
> URL: https://issues.apache.org/jira/browse/CASSANDRA-154
> Project: Cassandra
> Issue Type: Sub-task
> Affects Versions: trunk
> Reporter: Sandeep Tata
> Assignee: Sandeep Tata
> Fix For: trunk
>
> Attachments: CASSANDRA-154.patch
>
>
> Thrift API changes to support CASSANDRA-140.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (CASSANDRA-154) Change thrift interface to allow
#endpoints as a parameter to insert calls
Posted by "Sandeep Tata (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/CASSANDRA-154?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12710497#action_12710497 ]
Sandeep Tata commented on CASSANDRA-154:
----------------------------------------
Both changes (QRH taking only responsecount=blockfor, and sanity checks on responcecount) make sense.
Compiles and tests pass
+1 for the addendum
> Change thrift interface to allow #endpoints as a parameter to insert calls
> --------------------------------------------------------------------------
>
> Key: CASSANDRA-154
> URL: https://issues.apache.org/jira/browse/CASSANDRA-154
> Project: Cassandra
> Issue Type: Sub-task
> Affects Versions: trunk
> Reporter: Sandeep Tata
> Assignee: Sandeep Tata
> Fix For: trunk
>
> Attachments: 154-addendum.patch, CASSANDRA-154-interface-v2.patch, CASSANDRA-154-interface.patch, CASSANDRA-154-src-v2.patch, CASSANDRA-154-src.patch, CASSANDRA-154.patch
>
>
> Thrift API changes to support CASSANDRA-140.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (CASSANDRA-154) Change thrift interface to allow
#endpoints as a parameter to insert calls
Posted by "Jonathan Ellis (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/CASSANDRA-154?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12710395#action_12710395 ]
Jonathan Ellis commented on CASSANDRA-154:
------------------------------------------
Note: old client code will run as-is b/c thrift converts bool to int on the wire. But before block=True would wait for majority but block_for=1 will only block for one so behavior has subtly changed if the user does not read the changelog when he upgrades. Personally I am okay with this (there is a reason we did not call our first branch 1.0 :) but I thought it was worth pointing out.
> Change thrift interface to allow #endpoints as a parameter to insert calls
> --------------------------------------------------------------------------
>
> Key: CASSANDRA-154
> URL: https://issues.apache.org/jira/browse/CASSANDRA-154
> Project: Cassandra
> Issue Type: Sub-task
> Affects Versions: trunk
> Reporter: Sandeep Tata
> Assignee: Sandeep Tata
> Fix For: trunk
>
> Attachments: 154-addendum.patch, CASSANDRA-154-interface-v2.patch, CASSANDRA-154-interface.patch, CASSANDRA-154-src-v2.patch, CASSANDRA-154-src.patch, CASSANDRA-154.patch
>
>
> Thrift API changes to support CASSANDRA-140.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (CASSANDRA-154) Change thrift interface to allow
#endpoints as a parameter to insert calls
Posted by "Sandeep Tata (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/CASSANDRA-154?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Sandeep Tata updated CASSANDRA-154:
-----------------------------------
Attachment: CASSANDRA-154-src-v2.patch
CASSANDRA-154-interface-v2.patch
rebase to trunk again after CASSANDRA-53
> Change thrift interface to allow #endpoints as a parameter to insert calls
> --------------------------------------------------------------------------
>
> Key: CASSANDRA-154
> URL: https://issues.apache.org/jira/browse/CASSANDRA-154
> Project: Cassandra
> Issue Type: Sub-task
> Affects Versions: trunk
> Reporter: Sandeep Tata
> Assignee: Sandeep Tata
> Fix For: trunk
>
> Attachments: CASSANDRA-154-interface-v2.patch, CASSANDRA-154-interface.patch, CASSANDRA-154-src-v2.patch, CASSANDRA-154-src.patch, CASSANDRA-154.patch
>
>
> Thrift API changes to support CASSANDRA-140.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (CASSANDRA-154) Change thrift interface to allow
#endpoints as a parameter to insert calls
Posted by "Jonathan Ellis (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/CASSANDRA-154?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Jonathan Ellis updated CASSANDRA-154:
-------------------------------------
Attachment: 154-addendum.patch
attached wrong diff at first. this is the correct one.
> Change thrift interface to allow #endpoints as a parameter to insert calls
> --------------------------------------------------------------------------
>
> Key: CASSANDRA-154
> URL: https://issues.apache.org/jira/browse/CASSANDRA-154
> Project: Cassandra
> Issue Type: Sub-task
> Affects Versions: trunk
> Reporter: Sandeep Tata
> Assignee: Sandeep Tata
> Fix For: trunk
>
> Attachments: 154-addendum.patch, CASSANDRA-154-interface-v2.patch, CASSANDRA-154-interface.patch, CASSANDRA-154-src-v2.patch, CASSANDRA-154-src.patch, CASSANDRA-154.patch
>
>
> Thrift API changes to support CASSANDRA-140.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (CASSANDRA-154) Change thrift interface to allow
#endpoints as a parameter to insert calls
Posted by "Jonathan Ellis (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/CASSANDRA-154?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Jonathan Ellis updated CASSANDRA-154:
-------------------------------------
Attachment: (was: 154-addendum.patch)
> Change thrift interface to allow #endpoints as a parameter to insert calls
> --------------------------------------------------------------------------
>
> Key: CASSANDRA-154
> URL: https://issues.apache.org/jira/browse/CASSANDRA-154
> Project: Cassandra
> Issue Type: Sub-task
> Affects Versions: trunk
> Reporter: Sandeep Tata
> Assignee: Sandeep Tata
> Fix For: trunk
>
> Attachments: 154-addendum.patch, CASSANDRA-154-interface-v2.patch, CASSANDRA-154-interface.patch, CASSANDRA-154-src-v2.patch, CASSANDRA-154-src.patch, CASSANDRA-154.patch
>
>
> Thrift API changes to support CASSANDRA-140.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (CASSANDRA-154) Change thrift interface to allow
#endpoints as a parameter to insert calls
Posted by "Jonathan Ellis (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/CASSANDRA-154?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Jonathan Ellis updated CASSANDRA-154:
-------------------------------------
Attachment: 154-addendum.patch
The biggest problem is that your new QRH has both a responseCount and a blockFor and only blockFor is checked (but only after quorum-ifying which is not what the thrift interface implies).
This patch applies on top of yours and makes QRH only take the old responseCount, which is used as-is. It also checks for responseCount being sane. What do you think?
> Change thrift interface to allow #endpoints as a parameter to insert calls
> --------------------------------------------------------------------------
>
> Key: CASSANDRA-154
> URL: https://issues.apache.org/jira/browse/CASSANDRA-154
> Project: Cassandra
> Issue Type: Sub-task
> Affects Versions: trunk
> Reporter: Sandeep Tata
> Assignee: Sandeep Tata
> Fix For: trunk
>
> Attachments: 154-addendum.patch, CASSANDRA-154-interface-v2.patch, CASSANDRA-154-interface.patch, CASSANDRA-154-src-v2.patch, CASSANDRA-154-src.patch, CASSANDRA-154.patch
>
>
> Thrift API changes to support CASSANDRA-140.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (CASSANDRA-154) Change thrift interface to allow
#endpoints as a parameter to insert calls
Posted by "Sandeep Tata (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/CASSANDRA-154?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Sandeep Tata updated CASSANDRA-154:
-----------------------------------
Attachment: CASSANDRA-154.patch
Changed thrift interface to use int instead of boolean. Pass in 0 for no-blocking.
Big patch, but most of the changes are in the generated code.
All unit tests pass. (Apply this after patch in #140)
> Change thrift interface to allow #endpoints as a parameter to insert calls
> --------------------------------------------------------------------------
>
> Key: CASSANDRA-154
> URL: https://issues.apache.org/jira/browse/CASSANDRA-154
> Project: Cassandra
> Issue Type: Sub-task
> Affects Versions: trunk
> Reporter: Sandeep Tata
> Assignee: Sandeep Tata
> Fix For: trunk
>
> Attachments: CASSANDRA-154.patch
>
>
> Thrift API changes to support CASSANDRA-140.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (CASSANDRA-154) Change thrift interface to allow
#endpoints as a parameter to insert calls
Posted by "Michael Greene (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/CASSANDRA-154?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Michael Greene updated CASSANDRA-154:
-------------------------------------
Component/s: Core
> Change thrift interface to allow #endpoints as a parameter to insert calls
> --------------------------------------------------------------------------
>
> Key: CASSANDRA-154
> URL: https://issues.apache.org/jira/browse/CASSANDRA-154
> Project: Cassandra
> Issue Type: Sub-task
> Components: Core
> Reporter: Sandeep Tata
> Assignee: Sandeep Tata
> Fix For: 0.4
>
> Attachments: 154-addendum.patch, CASSANDRA-154-interface-v2.patch, CASSANDRA-154-interface.patch, CASSANDRA-154-src-v2.patch, CASSANDRA-154-src.patch, CASSANDRA-154.patch
>
>
> Thrift API changes to support CASSANDRA-140.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.