You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by GitBox <gi...@apache.org> on 2020/12/07 12:44:11 UTC
[GitHub] [spark] maropu opened a new pull request #30647: [SPARK-33690][SQL] Escape meta-characters in showString
maropu opened a new pull request #30647:
URL: https://github.com/apache/spark/pull/30647
<!--
Thanks for sending a pull request! Here are some tips for you:
1. If this is your first time, please read our contributor guidelines: https://spark.apache.org/contributing.html
2. Ensure you have added or run the appropriate tests for your PR: https://spark.apache.org/developer-tools.html
3. If the PR is unfinished, add '[WIP]' in your PR title, e.g., '[WIP][SPARK-XXXX] Your PR title ...'.
4. Be sure to keep the PR description updated to reflect all changes.
5. Please write your PR title to summarize what this PR proposes.
6. If possible, provide a concise example to reproduce the issue for a faster review.
7. If you want to add a new configuration, please read the guideline first for naming configurations in
'core/src/main/scala/org/apache/spark/internal/config/ConfigEntry.scala'.
-->
### What changes were proposed in this pull request?
<!--
Please clarify what changes you are proposing. The purpose of this section is to outline the changes and how this PR fixes the issue.
If possible, please consider writing useful notes for better and faster reviews in your PR. See the examples below.
1. If you refactor some codes with changing classes, showing the class hierarchy will help reviewers.
2. If you fix some SQL features, you can provide some references of other DBMSes.
3. If there is design documentation, please add the link.
4. If there is a discussion in the mailing list, please add the link.
-->
This PR intends to escape meta-characters (e.g., \n and \t) in `Dataset.showString`.
Before this PR:
```
scala> Seq("aaa\nbbb\t\tccccc").toDF("value").show()
+--------------+
| value|
+--------------+
|aaa
bbb ccccc|
+--------------+
```
After this PR:
```
+-----------------+
| value|
+-----------------+
|aaa\nbbb\t\tccccc|
+-----------------+
```
### Why are the changes needed?
<!--
Please clarify why the changes are needed. For instance,
1. If you propose a new API, clarify the use case for a new API.
2. If you fix a bug, you can clarify why it is a bug.
-->
For better output.
### Does this PR introduce _any_ user-facing change?
<!--
Note that it means *any* user-facing change including all aspects such as the documentation fix.
If yes, please clarify the previous behavior and the change this PR proposes - provide the console output, description and/or an example to show the behavior difference if possible.
If possible, please also clarify if this is a user-facing change compared to the released Spark versions or within the unreleased branches such as master.
If no, write 'No'.
-->
No.
### How was this patch tested?
<!--
If tests were added, say they were added here. Please make sure to add some test cases that check the changes thoroughly including negative and positive cases if possible.
If it was tested in a way different from regular unit tests, please clarify how you tested step by step, ideally copy and paste-able, so that other reviewers can test and check, and descendants can verify in the future.
If tests were not added, please describe why they were not added and/or why it was difficult to add.
-->
Added a unit test.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #30647: [SPARK-33690][SQL] Escape meta-characters in showString
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #30647:
URL: https://github.com/apache/spark/pull/30647#issuecomment-741568471
**[Test build #132468 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/132468/testReport)** for PR 30647 at commit [`19494be`](https://github.com/apache/spark/commit/19494be7796f6912e4fa00bfd44bc62e0cd92d53).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA removed a comment on pull request #30647: [SPARK-33690][SQL] Escape meta-characters in showString
Posted by GitBox <gi...@apache.org>.
SparkQA removed a comment on pull request #30647:
URL: https://github.com/apache/spark/pull/30647#issuecomment-741568471
**[Test build #132468 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/132468/testReport)** for PR 30647 at commit [`19494be`](https://github.com/apache/spark/commit/19494be7796f6912e4fa00bfd44bc62e0cd92d53).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] maropu commented on pull request #30647: [SPARK-33690][SQL] Escape meta-characters in showString
Posted by GitBox <gi...@apache.org>.
maropu commented on pull request #30647:
URL: https://github.com/apache/spark/pull/30647#issuecomment-741558708
retest this please
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #30647: [SPARK-33690][SQL] Escape meta-characters in showString
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #30647:
URL: https://github.com/apache/spark/pull/30647#issuecomment-740623536
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/37031/
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] maropu commented on a change in pull request #30647: [SPARK-33690][SQL] Escape meta-characters in showString
Posted by GitBox <gi...@apache.org>.
maropu commented on a change in pull request #30647:
URL: https://github.com/apache/spark/pull/30647#discussion_r540634465
##########
File path: docs/sql-migration-guide.md
##########
@@ -26,6 +26,8 @@ license: |
- In Spark 3.2, `spark.sql.adaptive.enabled` is enabled by default. To restore the behavior before Spark 3.2, you can set `spark.sql.adaptive.enabled` to `false`.
+ - In Spark 3.2, the meta-characters `\n` and `\t` are escaped in the `show()` action. In Spark 3.0 or earlier, the two metacharacters are output as it is.
Review comment:
> Ur, do we handle this in complex types like Array/Map/Struct? The current AS-IS PR seems to handle only the top-level string type. If we don't support complex types, we need to narrow down more specific about the benefit.
Yea, nice catch. I'll update this PR for supporting the suggested case. Thanks!
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #30647: [SPARK-33690][SQL] Escape meta-characters in showString
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #30647:
URL: https://github.com/apache/spark/pull/30647#issuecomment-740007481
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/132367/
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on pull request #30647: [SPARK-33690][SQL] Escape meta-characters in showString
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #30647:
URL: https://github.com/apache/spark/pull/30647#issuecomment-740445709
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/37012/
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #30647: [SPARK-33690][SQL] Escape meta-characters in showString
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #30647:
URL: https://github.com/apache/spark/pull/30647#issuecomment-740414226
**[Test build #132412 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/132412/testReport)** for PR 30647 at commit [`19494be`](https://github.com/apache/spark/commit/19494be7796f6912e4fa00bfd44bc62e0cd92d53).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #30647: [SPARK-33690][SQL] Escape meta-characters in showString
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #30647:
URL: https://github.com/apache/spark/pull/30647#issuecomment-743107875
**[Test build #132625 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/132625/testReport)** for PR 30647 at commit [`feb0277`](https://github.com/apache/spark/commit/feb02779c017cca24aa18240aa4370591c248ad6).
* This patch passes all tests.
* This patch merges cleanly.
* This patch adds no public classes.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #30647: [SPARK-33690][SQL] Escape meta-characters in showString
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #30647:
URL: https://github.com/apache/spark/pull/30647#issuecomment-743033351
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/37227/
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #30647: [SPARK-33690][SQL] Escape meta-characters in showString
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #30647:
URL: https://github.com/apache/spark/pull/30647#issuecomment-742986921
**[Test build #132625 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/132625/testReport)** for PR 30647 at commit [`feb0277`](https://github.com/apache/spark/commit/feb02779c017cca24aa18240aa4370591c248ad6).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #30647: [SPARK-33690][SQL] Escape meta-characters in showString
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #30647:
URL: https://github.com/apache/spark/pull/30647#issuecomment-741800442
**[Test build #132485 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/132485/testReport)** for PR 30647 at commit [`21174e0`](https://github.com/apache/spark/commit/21174e071d421c708e531e92d1ffbccf0e80d0f2).
* This patch passes all tests.
* This patch merges cleanly.
* This patch adds no public classes.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #30647: [SPARK-33690][SQL] Escape meta-characters in showString
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #30647:
URL: https://github.com/apache/spark/pull/30647#issuecomment-740445709
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/37012/
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on pull request #30647: [SPARK-33690][SQL] Escape meta-characters in showString
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #30647:
URL: https://github.com/apache/spark/pull/30647#issuecomment-740007481
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/132367/
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #30647: [SPARK-33690][SQL] Escape meta-characters in showString
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #30647:
URL: https://github.com/apache/spark/pull/30647#issuecomment-739955303
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/36967/
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #30647: [SPARK-33690][SQL] Escape meta-characters in showString
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #30647:
URL: https://github.com/apache/spark/pull/30647#issuecomment-739896706
**[Test build #132367 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/132367/testReport)** for PR 30647 at commit [`4a7e86f`](https://github.com/apache/spark/commit/4a7e86f9c840d800bbd0be5ca2a79f8993df636e).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on pull request #30647: [SPARK-33690][SQL] Escape meta-characters in showString
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #30647:
URL: https://github.com/apache/spark/pull/30647#issuecomment-742948996
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] maropu commented on pull request #30647: [SPARK-33690][SQL] Escape meta-characters in showString
Posted by GitBox <gi...@apache.org>.
maropu commented on pull request #30647:
URL: https://github.com/apache/spark/pull/30647#issuecomment-740572625
retest this please
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #30647: [SPARK-33690][SQL] Escape meta-characters in showString
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #30647:
URL: https://github.com/apache/spark/pull/30647#issuecomment-741614435
**[Test build #132468 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/132468/testReport)** for PR 30647 at commit [`19494be`](https://github.com/apache/spark/commit/19494be7796f6912e4fa00bfd44bc62e0cd92d53).
* This patch **fails Spark unit tests**.
* This patch merges cleanly.
* This patch adds no public classes.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on pull request #30647: [SPARK-33690][SQL] Escape meta-characters in showString
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #30647:
URL: https://github.com/apache/spark/pull/30647#issuecomment-742912850
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/37205/
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #30647: [SPARK-33690][SQL] Escape meta-characters in showString
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #30647:
URL: https://github.com/apache/spark/pull/30647#issuecomment-741589264
Kubernetes integration test starting
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/37070/
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] maropu commented on pull request #30647: [SPARK-33690][SQL] Escape meta-characters in showString
Posted by GitBox <gi...@apache.org>.
maropu commented on pull request #30647:
URL: https://github.com/apache/spark/pull/30647#issuecomment-742913538
@dongjoon-hyun @srowen Thanks for the review, guys! I updated the migration guide.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] dongjoon-hyun commented on pull request #30647: [SPARK-33690][SQL] Escape meta-characters in showString
Posted by GitBox <gi...@apache.org>.
dongjoon-hyun commented on pull request #30647:
URL: https://github.com/apache/spark/pull/30647#issuecomment-740111876
Could you take a look at the failure?
- org.apache.spark.sql.DatasetSuite.SPARK-25108 Fix the show method to display the full width character alignment problem
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #30647: [SPARK-33690][SQL] Escape meta-characters in showString
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #30647:
URL: https://github.com/apache/spark/pull/30647#issuecomment-742912850
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/37205/
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #30647: [SPARK-33690][SQL] Escape meta-characters in showString
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #30647:
URL: https://github.com/apache/spark/pull/30647#issuecomment-741665985
**[Test build #132485 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/132485/testReport)** for PR 30647 at commit [`21174e0`](https://github.com/apache/spark/commit/21174e071d421c708e531e92d1ffbccf0e80d0f2).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #30647: [SPARK-33690][SQL] Escape meta-characters in showString
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #30647:
URL: https://github.com/apache/spark/pull/30647#issuecomment-741717795
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/37087/
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] srowen commented on a change in pull request #30647: [SPARK-33690][SQL] Escape meta-characters in showString
Posted by GitBox <gi...@apache.org>.
srowen commented on a change in pull request #30647:
URL: https://github.com/apache/spark/pull/30647#discussion_r538461120
##########
File path: sql/core/src/main/scala/org/apache/spark/sql/Dataset.scala
##########
@@ -304,10 +304,13 @@ class Dataset[T] private[sql](
// For cells that are beyond `truncate` characters, replace it with the
// first `truncate-3` and "..."
schema.fieldNames.toSeq +: data.map { row =>
- row.toSeq.map { cell =>
+ row.toSeq.zip(newDf.schema).map { case (cell, f) =>
val str = cell match {
case null => "null"
case binary: Array[Byte] => binary.map("%02X".format(_)).mkString("[", " ", "]")
+ case _ if f.dataType == StringType =>
+ // Escapes meta-characters not to break the `showString` format
+ cell.toString.replaceAll("\n", "\\\\n").replaceAll("\t", "\\\\t")
Review comment:
Just for my curiosity, why is `\\\\t` necessary? the extra escaping? this seems to replace with the string `\\t` rather than `\t`
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #30647: [SPARK-33690][SQL] Escape meta-characters in showString
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #30647:
URL: https://github.com/apache/spark/pull/30647#issuecomment-742917352
**[Test build #132609 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/132609/testReport)** for PR 30647 at commit [`e727672`](https://github.com/apache/spark/commit/e727672e5055d2f9d546ab672fd0bfcb530dbd9c).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #30647: [SPARK-33690][SQL] Escape meta-characters in showString
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #30647:
URL: https://github.com/apache/spark/pull/30647#issuecomment-743009572
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/132609/
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] maropu commented on a change in pull request #30647: [SPARK-33690][SQL] Escape meta-characters in showString
Posted by GitBox <gi...@apache.org>.
maropu commented on a change in pull request #30647:
URL: https://github.com/apache/spark/pull/30647#discussion_r538070822
##########
File path: sql/core/src/main/scala/org/apache/spark/sql/Dataset.scala
##########
@@ -304,10 +304,13 @@ class Dataset[T] private[sql](
// For cells that are beyond `truncate` characters, replace it with the
// first `truncate-3` and "..."
schema.fieldNames.toSeq +: data.map { row =>
- row.toSeq.map { cell =>
+ row.toSeq.zip(newDf.schema).map { case (cell, f) =>
val str = cell match {
case null => "null"
case binary: Array[Byte] => binary.map("%02X".format(_)).mkString("[", " ", "]")
+ case _ if f.dataType == StringType =>
+ // Escapes meta-characters not to break the `showString` format
+ cell.toString.replaceAll("\n", "\\\\n").replaceAll("\t", "\\\\t")
Review comment:
The previous approach had an unacceptable behaviour ([it escaped unicode strings...](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/132367/testReport/org.apache.spark.sql/DatasetSuite/SPARK_25108_Fix_the_show_method_to_display_the_full_width_character_alignment_problem/)), so I've updated the code to replace `\t` and `\n` only.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA removed a comment on pull request #30647: [SPARK-33690][SQL] Escape meta-characters in showString
Posted by GitBox <gi...@apache.org>.
SparkQA removed a comment on pull request #30647:
URL: https://github.com/apache/spark/pull/30647#issuecomment-741665985
**[Test build #132485 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/132485/testReport)** for PR 30647 at commit [`21174e0`](https://github.com/apache/spark/commit/21174e071d421c708e531e92d1ffbccf0e80d0f2).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #30647: [SPARK-33690][SQL] Escape meta-characters in showString
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #30647:
URL: https://github.com/apache/spark/pull/30647#issuecomment-742996178
**[Test build #132609 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/132609/testReport)** for PR 30647 at commit [`e727672`](https://github.com/apache/spark/commit/e727672e5055d2f9d546ab672fd0bfcb530dbd9c).
* This patch passes all tests.
* This patch merges cleanly.
* This patch adds no public classes.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #30647: [SPARK-33690][SQL] Escape meta-characters in showString
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #30647:
URL: https://github.com/apache/spark/pull/30647#issuecomment-741708753
Kubernetes integration test status success
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/37087/
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] maropu commented on a change in pull request #30647: [SPARK-33690][SQL] Escape meta-characters in showString
Posted by GitBox <gi...@apache.org>.
maropu commented on a change in pull request #30647:
URL: https://github.com/apache/spark/pull/30647#discussion_r538076256
##########
File path: sql/core/src/test/scala/org/apache/spark/sql/ExplainSuite.scala
##########
@@ -261,11 +261,11 @@ class ExplainSuite extends ExplainSuiteHelper with DisableAdaptiveExecutionSuite
"PartitionFilters: \\[isnotnull\\(k#xL\\), dynamicpruningexpression\\(k#xL " +
"IN subquery#x\\)\\]"
val expected_pattern3 =
- "Location: InMemoryFileIndex \\[.*org.apache.spark.sql.ExplainSuite" +
- "/df2/.*, ... 99 entries\\]"
+ "Location: InMemoryFileIndex \\[\\S*org.apache.spark.sql.ExplainSuite" +
+ "/df2/\\S*, ... 99 entries\\]"
Review comment:
I updated this pattern for avoiding a unexpected longest string match in `expected_pattern3`; this PR makes the explain output be placed in a single line because line breaks are removed in `show`. So, the two consecutive `Location:....` strings are regarded as a single match, and then the test in L272 fails.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] maropu commented on pull request #30647: [SPARK-33690][SQL] Escape meta-characters in showString
Posted by GitBox <gi...@apache.org>.
maropu commented on pull request #30647:
URL: https://github.com/apache/spark/pull/30647#issuecomment-742913387
> Do we need to escape in Python side too?
Since pyspark showString just refers to the JVM implementation, it has the same behaivour in the Python side, too, I thinik.
```
>>> spark.createDataFrame([Row(v='aaa\nbbb\t\tcc')]).show()
+--------------+
| v|
+--------------+
|aaa\nbbb\t\tcc|
+--------------+
```
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on pull request #30647: [SPARK-33690][SQL] Escape meta-characters in showString
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #30647:
URL: https://github.com/apache/spark/pull/30647#issuecomment-743122364
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/132625/
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #30647: [SPARK-33690][SQL] Escape meta-characters in showString
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #30647:
URL: https://github.com/apache/spark/pull/30647#issuecomment-740503769
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/132412/
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] maropu commented on a change in pull request #30647: [SPARK-33690][SQL] Escape meta-characters in showString
Posted by GitBox <gi...@apache.org>.
maropu commented on a change in pull request #30647:
URL: https://github.com/apache/spark/pull/30647#discussion_r539039354
##########
File path: sql/core/src/main/scala/org/apache/spark/sql/Dataset.scala
##########
@@ -304,10 +304,13 @@ class Dataset[T] private[sql](
// For cells that are beyond `truncate` characters, replace it with the
// first `truncate-3` and "..."
schema.fieldNames.toSeq +: data.map { row =>
- row.toSeq.map { cell =>
+ row.toSeq.zip(newDf.schema).map { case (cell, f) =>
val str = cell match {
case null => "null"
case binary: Array[Byte] => binary.map("%02X".format(_)).mkString("[", " ", "]")
+ case _ if f.dataType == StringType =>
+ // Escapes meta-characters not to break the `showString` format
+ cell.toString.replaceAll("\n", "\\\\n").replaceAll("\t", "\\\\t")
Review comment:
Yea, that's a reasonable question; It seems `$` and `\` has a special meaning in the second param of `replaceAll` and see: https://docs.oracle.com/javase/8/docs/api/java/lang/String.html#replaceAll-java.lang.String-java.lang.String-
```
Note that backslashes (\) and dollar signs ($) in the replacement string may cause the results
to be different than if it were being treated as a literal replacement string; see Matcher.replaceAll.
Use Matcher.quoteReplacement(java.lang.String) to suppress the special meaning
of these characters, if desired.
```
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA removed a comment on pull request #30647: [SPARK-33690][SQL] Escape meta-characters in showString
Posted by GitBox <gi...@apache.org>.
SparkQA removed a comment on pull request #30647:
URL: https://github.com/apache/spark/pull/30647#issuecomment-742917352
**[Test build #132609 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/132609/testReport)** for PR 30647 at commit [`e727672`](https://github.com/apache/spark/commit/e727672e5055d2f9d546ab672fd0bfcb530dbd9c).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] dongjoon-hyun closed pull request #30647: [SPARK-33690][SQL] Escape meta-characters in showString
Posted by GitBox <gi...@apache.org>.
dongjoon-hyun closed pull request #30647:
URL: https://github.com/apache/spark/pull/30647
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on pull request #30647: [SPARK-33690][SQL] Escape meta-characters in showString
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #30647:
URL: https://github.com/apache/spark/pull/30647#issuecomment-741622879
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA removed a comment on pull request #30647: [SPARK-33690][SQL] Escape meta-characters in showString
Posted by GitBox <gi...@apache.org>.
SparkQA removed a comment on pull request #30647:
URL: https://github.com/apache/spark/pull/30647#issuecomment-740414226
**[Test build #132412 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/132412/testReport)** for PR 30647 at commit [`19494be`](https://github.com/apache/spark/commit/19494be7796f6912e4fa00bfd44bc62e0cd92d53).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA removed a comment on pull request #30647: [SPARK-33690][SQL] Escape meta-characters in showString
Posted by GitBox <gi...@apache.org>.
SparkQA removed a comment on pull request #30647:
URL: https://github.com/apache/spark/pull/30647#issuecomment-742986921
**[Test build #132625 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/132625/testReport)** for PR 30647 at commit [`feb0277`](https://github.com/apache/spark/commit/feb02779c017cca24aa18240aa4370591c248ad6).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] maropu commented on pull request #30647: [SPARK-33690][SQL] Escape meta-characters in showString
Posted by GitBox <gi...@apache.org>.
maropu commented on pull request #30647:
URL: https://github.com/apache/spark/pull/30647#issuecomment-743165539
cc: @dongjoon-hyun
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #30647: [SPARK-33690][SQL] Escape meta-characters in showString
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #30647:
URL: https://github.com/apache/spark/pull/30647#issuecomment-743008174
Kubernetes integration test starting
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/37227/
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on pull request #30647: [SPARK-33690][SQL] Escape meta-characters in showString
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #30647:
URL: https://github.com/apache/spark/pull/30647#issuecomment-739955303
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/36967/
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #30647: [SPARK-33690][SQL] Escape meta-characters in showString
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #30647:
URL: https://github.com/apache/spark/pull/30647#issuecomment-743019942
Kubernetes integration test status success
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/37227/
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #30647: [SPARK-33690][SQL] Escape meta-characters in showString
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #30647:
URL: https://github.com/apache/spark/pull/30647#issuecomment-742893769
**[Test build #132601 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/132601/testReport)** for PR 30647 at commit [`07f9d5e`](https://github.com/apache/spark/commit/07f9d5e8fdcc66b784a2f8edab233d37b7d7665f).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on pull request #30647: [SPARK-33690][SQL] Escape meta-characters in showString
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #30647:
URL: https://github.com/apache/spark/pull/30647#issuecomment-741717795
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/37087/
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] srowen commented on pull request #30647: [SPARK-33690][SQL] Escape meta-characters in showString
Posted by GitBox <gi...@apache.org>.
srowen commented on pull request #30647:
URL: https://github.com/apache/spark/pull/30647#issuecomment-742104246
I think it's useful to mention it in the migration guide, but I think it's a fine change for a minor release, as more fix than change.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] dongjoon-hyun commented on a change in pull request #30647: [SPARK-33690][SQL] Escape meta-characters in showString
Posted by GitBox <gi...@apache.org>.
dongjoon-hyun commented on a change in pull request #30647:
URL: https://github.com/apache/spark/pull/30647#discussion_r540633126
##########
File path: docs/sql-migration-guide.md
##########
@@ -26,6 +26,8 @@ license: |
- In Spark 3.2, `spark.sql.adaptive.enabled` is enabled by default. To restore the behavior before Spark 3.2, you can set `spark.sql.adaptive.enabled` to `false`.
+ - In Spark 3.2, the meta-characters `\n` and `\t` are escaped in the `show()` action. In Spark 3.0 or earlier, the two metacharacters are output as it is.
Review comment:
Ur, do we handle this in complex types like `Array/Map/Struct`? Otherwise, we need to narrow down more specific about the benefit.
> the meta-characters `\n` and `\t` are escaped in the `show()` action
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #30647: [SPARK-33690][SQL] Escape meta-characters in showString
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #30647:
URL: https://github.com/apache/spark/pull/30647#issuecomment-739921136
Kubernetes integration test starting
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/36967/
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on pull request #30647: [SPARK-33690][SQL] Escape meta-characters in showString
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #30647:
URL: https://github.com/apache/spark/pull/30647#issuecomment-740623536
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/37031/
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #30647: [SPARK-33690][SQL] Escape meta-characters in showString
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #30647:
URL: https://github.com/apache/spark/pull/30647#issuecomment-739936820
Kubernetes integration test status failure
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/36967/
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #30647: [SPARK-33690][SQL] Escape meta-characters in showString
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #30647:
URL: https://github.com/apache/spark/pull/30647#issuecomment-742948996
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] dongjoon-hyun commented on pull request #30647: [SPARK-33690][SQL] Escape meta-characters in showString
Posted by GitBox <gi...@apache.org>.
dongjoon-hyun commented on pull request #30647:
URL: https://github.com/apache/spark/pull/30647#issuecomment-742913837
Thank you for update, @maropu .
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #30647: [SPARK-33690][SQL] Escape meta-characters in showString
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #30647:
URL: https://github.com/apache/spark/pull/30647#issuecomment-742912829
Kubernetes integration test status success
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/37205/
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #30647: [SPARK-33690][SQL] Escape meta-characters in showString
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #30647:
URL: https://github.com/apache/spark/pull/30647#issuecomment-743122364
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/132625/
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #30647: [SPARK-33690][SQL] Escape meta-characters in showString
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #30647:
URL: https://github.com/apache/spark/pull/30647#issuecomment-741605727
Kubernetes integration test status success
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/37070/
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #30647: [SPARK-33690][SQL] Escape meta-characters in showString
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #30647:
URL: https://github.com/apache/spark/pull/30647#issuecomment-742944862
**[Test build #132601 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/132601/testReport)** for PR 30647 at commit [`07f9d5e`](https://github.com/apache/spark/commit/07f9d5e8fdcc66b784a2f8edab233d37b7d7665f).
* This patch **fails Spark unit tests**.
* This patch merges cleanly.
* This patch adds no public classes.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #30647: [SPARK-33690][SQL] Escape meta-characters in showString
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #30647:
URL: https://github.com/apache/spark/pull/30647#issuecomment-742905403
Kubernetes integration test starting
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/37205/
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #30647: [SPARK-33690][SQL] Escape meta-characters in showString
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #30647:
URL: https://github.com/apache/spark/pull/30647#issuecomment-740573531
**[Test build #132431 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/132431/testReport)** for PR 30647 at commit [`19494be`](https://github.com/apache/spark/commit/19494be7796f6912e4fa00bfd44bc62e0cd92d53).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA removed a comment on pull request #30647: [SPARK-33690][SQL] Escape meta-characters in showString
Posted by GitBox <gi...@apache.org>.
SparkQA removed a comment on pull request #30647:
URL: https://github.com/apache/spark/pull/30647#issuecomment-739896706
**[Test build #132367 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/132367/testReport)** for PR 30647 at commit [`4a7e86f`](https://github.com/apache/spark/commit/4a7e86f9c840d800bbd0be5ca2a79f8993df636e).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #30647: [SPARK-33690][SQL] Escape meta-characters in showString
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #30647:
URL: https://github.com/apache/spark/pull/30647#issuecomment-741622879
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #30647: [SPARK-33690][SQL] Escape meta-characters in showString
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #30647:
URL: https://github.com/apache/spark/pull/30647#issuecomment-740433216
Kubernetes integration test starting
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/37012/
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] maropu edited a comment on pull request #30647: [SPARK-33690][SQL] Escape meta-characters in showString
Posted by GitBox <gi...@apache.org>.
maropu edited a comment on pull request #30647:
URL: https://github.com/apache/spark/pull/30647#issuecomment-742913538
@dongjoon-hyun @srowen Thanks for the review, guys! I've updated the migration guide.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on pull request #30647: [SPARK-33690][SQL] Escape meta-characters in showString
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #30647:
URL: https://github.com/apache/spark/pull/30647#issuecomment-743033351
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/37227/
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on pull request #30647: [SPARK-33690][SQL] Escape meta-characters in showString
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #30647:
URL: https://github.com/apache/spark/pull/30647#issuecomment-740503769
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/132412/
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #30647: [SPARK-33690][SQL] Escape meta-characters in showString
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #30647:
URL: https://github.com/apache/spark/pull/30647#issuecomment-740487236
**[Test build #132412 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/132412/testReport)** for PR 30647 at commit [`19494be`](https://github.com/apache/spark/commit/19494be7796f6912e4fa00bfd44bc62e0cd92d53).
* This patch **fails Spark unit tests**.
* This patch merges cleanly.
* This patch adds no public classes.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on pull request #30647: [SPARK-33690][SQL] Escape meta-characters in showString
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #30647:
URL: https://github.com/apache/spark/pull/30647#issuecomment-743009572
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/132609/
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] dongjoon-hyun commented on a change in pull request #30647: [SPARK-33690][SQL] Escape meta-characters in showString
Posted by GitBox <gi...@apache.org>.
dongjoon-hyun commented on a change in pull request #30647:
URL: https://github.com/apache/spark/pull/30647#discussion_r540632517
##########
File path: docs/sql-migration-guide.md
##########
@@ -26,6 +26,8 @@ license: |
- In Spark 3.2, `spark.sql.adaptive.enabled` is enabled by default. To restore the behavior before Spark 3.2, you can set `spark.sql.adaptive.enabled` to `false`.
+ - In Spark 3.2, the meta-characters `\n` and `\t` are escaped in the `show()` action. In Spark 3.0 or earlier, the two metacharacters are output as it is.
Review comment:
`In Spark 3.0 or earlier` -> `In Spark 3.1 or earlier`
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] srowen commented on pull request #30647: [SPARK-33690][SQL] Escape meta-characters in showString
Posted by GitBox <gi...@apache.org>.
srowen commented on pull request #30647:
URL: https://github.com/apache/spark/pull/30647#issuecomment-739986582
Seems OK. The alternative is to strip them. If this is consistent with anything else we do to escape, OK.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #30647: [SPARK-33690][SQL] Escape meta-characters in showString
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #30647:
URL: https://github.com/apache/spark/pull/30647#issuecomment-740594441
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/132431/
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] maropu commented on a change in pull request #30647: [SPARK-33690][SQL] Escape meta-characters in showString
Posted by GitBox <gi...@apache.org>.
maropu commented on a change in pull request #30647:
URL: https://github.com/apache/spark/pull/30647#discussion_r540634465
##########
File path: docs/sql-migration-guide.md
##########
@@ -26,6 +26,8 @@ license: |
- In Spark 3.2, `spark.sql.adaptive.enabled` is enabled by default. To restore the behavior before Spark 3.2, you can set `spark.sql.adaptive.enabled` to `false`.
+ - In Spark 3.2, the meta-characters `\n` and `\t` are escaped in the `show()` action. In Spark 3.0 or earlier, the two metacharacters are output as it is.
Review comment:
> Ur, do we handle this in complex types like Array/Map/Struct? The current AS-IS PR seems to handle only the top-level string type. If we don't support complex types, we need to narrow down more specific about the benefit.
Yea, nice catch. I'll check if we can support the suggested case. Thanks!
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] maropu commented on a change in pull request #30647: [SPARK-33690][SQL] Escape meta-characters in showString
Posted by GitBox <gi...@apache.org>.
maropu commented on a change in pull request #30647:
URL: https://github.com/apache/spark/pull/30647#discussion_r540633896
##########
File path: docs/sql-migration-guide.md
##########
@@ -26,6 +26,8 @@ license: |
- In Spark 3.2, `spark.sql.adaptive.enabled` is enabled by default. To restore the behavior before Spark 3.2, you can set `spark.sql.adaptive.enabled` to `false`.
+ - In Spark 3.2, the meta-characters `\n` and `\t` are escaped in the `show()` action. In Spark 3.0 or earlier, the two metacharacters are output as it is.
Review comment:
> In Spark 3.0 or earlier -> In Spark 3.1 or earlier
Ah, my bad...
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on pull request #30647: [SPARK-33690][SQL] Escape meta-characters in showString
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #30647:
URL: https://github.com/apache/spark/pull/30647#issuecomment-740594441
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/132431/
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #30647: [SPARK-33690][SQL] Escape meta-characters in showString
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #30647:
URL: https://github.com/apache/spark/pull/30647#issuecomment-741693449
Kubernetes integration test starting
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/37087/
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins commented on pull request #30647: [SPARK-33690][SQL] Escape meta-characters in showString
Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #30647:
URL: https://github.com/apache/spark/pull/30647#issuecomment-741815125
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/132485/
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] viirya commented on a change in pull request #30647: [SPARK-33690][SQL] Escape meta-characters in showString
Posted by GitBox <gi...@apache.org>.
viirya commented on a change in pull request #30647:
URL: https://github.com/apache/spark/pull/30647#discussion_r539088095
##########
File path: sql/core/src/test/scala/org/apache/spark/sql/DataFrameSuite.scala
##########
@@ -1234,6 +1234,17 @@ class DataFrameSuite extends QueryTest
assert(df.showString(10, vertical = true) === expectedAnswer)
}
+ test("showString: escape meta-characters") {
Review comment:
Add JIRA number?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #30647: [SPARK-33690][SQL] Escape meta-characters in showString
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #30647:
URL: https://github.com/apache/spark/pull/30647#issuecomment-740445689
Kubernetes integration test status success
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/37012/
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] dongjoon-hyun commented on a change in pull request #30647: [SPARK-33690][SQL] Escape meta-characters in showString
Posted by GitBox <gi...@apache.org>.
dongjoon-hyun commented on a change in pull request #30647:
URL: https://github.com/apache/spark/pull/30647#discussion_r540633126
##########
File path: docs/sql-migration-guide.md
##########
@@ -26,6 +26,8 @@ license: |
- In Spark 3.2, `spark.sql.adaptive.enabled` is enabled by default. To restore the behavior before Spark 3.2, you can set `spark.sql.adaptive.enabled` to `false`.
+ - In Spark 3.2, the meta-characters `\n` and `\t` are escaped in the `show()` action. In Spark 3.0 or earlier, the two metacharacters are output as it is.
Review comment:
Ur, do we handle this in complex types like `Array/Map/Struct`? The current AS-IS PR seems to handle only the top-level string type. If we don't support complex types, we need to narrow down more specific about the benefit.
> the meta-characters `\n` and `\t` are escaped in the `show()` action
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] maropu commented on a change in pull request #30647: [SPARK-33690][SQL] Escape meta-characters in showString
Posted by GitBox <gi...@apache.org>.
maropu commented on a change in pull request #30647:
URL: https://github.com/apache/spark/pull/30647#discussion_r539106942
##########
File path: sql/core/src/test/scala/org/apache/spark/sql/DataFrameSuite.scala
##########
@@ -1234,6 +1234,17 @@ class DataFrameSuite extends QueryTest
assert(df.showString(10, vertical = true) === expectedAnswer)
}
+ test("showString: escape meta-characters") {
Review comment:
Sure!
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #30647: [SPARK-33690][SQL] Escape meta-characters in showString
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #30647:
URL: https://github.com/apache/spark/pull/30647#issuecomment-740589135
**[Test build #132431 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/132431/testReport)** for PR 30647 at commit [`19494be`](https://github.com/apache/spark/commit/19494be7796f6912e4fa00bfd44bc62e0cd92d53).
* This patch **fails Spark unit tests**.
* This patch merges cleanly.
* This patch adds no public classes.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #30647: [SPARK-33690][SQL] Escape meta-characters in showString
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #30647:
URL: https://github.com/apache/spark/pull/30647#issuecomment-742941821
Kubernetes integration test status success
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/37214/
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] AmplabJenkins removed a comment on pull request #30647: [SPARK-33690][SQL] Escape meta-characters in showString
Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #30647:
URL: https://github.com/apache/spark/pull/30647#issuecomment-741815125
Refer to this link for build results (access rights to CI server needed):
https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/132485/
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA removed a comment on pull request #30647: [SPARK-33690][SQL] Escape meta-characters in showString
Posted by GitBox <gi...@apache.org>.
SparkQA removed a comment on pull request #30647:
URL: https://github.com/apache/spark/pull/30647#issuecomment-740573531
**[Test build #132431 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/132431/testReport)** for PR 30647 at commit [`19494be`](https://github.com/apache/spark/commit/19494be7796f6912e4fa00bfd44bc62e0cd92d53).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA removed a comment on pull request #30647: [SPARK-33690][SQL] Escape meta-characters in showString
Posted by GitBox <gi...@apache.org>.
SparkQA removed a comment on pull request #30647:
URL: https://github.com/apache/spark/pull/30647#issuecomment-742893769
**[Test build #132601 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/132601/testReport)** for PR 30647 at commit [`07f9d5e`](https://github.com/apache/spark/commit/07f9d5e8fdcc66b784a2f8edab233d37b7d7665f).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #30647: [SPARK-33690][SQL] Escape meta-characters in showString
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #30647:
URL: https://github.com/apache/spark/pull/30647#issuecomment-740006847
**[Test build #132367 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/132367/testReport)** for PR 30647 at commit [`4a7e86f`](https://github.com/apache/spark/commit/4a7e86f9c840d800bbd0be5ca2a79f8993df636e).
* This patch **fails Spark unit tests**.
* This patch merges cleanly.
* This patch adds no public classes.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
[GitHub] [spark] SparkQA commented on pull request #30647: [SPARK-33690][SQL] Escape meta-characters in showString
Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #30647:
URL: https://github.com/apache/spark/pull/30647#issuecomment-742933528
Kubernetes integration test starting
URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/37214/
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org