You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@mesos.apache.org by Andrei Budnik <ab...@mesosphere.com> on 2018/12/10 16:41:50 UTC
Review Request 69540: Added `ROOT_PseudoDevicesWithRootFilesystem`
test.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/69540/
-----------------------------------------------------------
Review request for mesos, Jie Yu and James Peach.
Bugs: MESOS-9462
https://issues.apache.org/jira/browse/MESOS-9462
Repository: mesos
Description
-------
This test verifies that pseudo devices like /dev/random are properly
mounted in the container's root filesystem.
Diffs
-----
src/tests/containerizer/linux_filesystem_isolator_tests.cpp 84b342cdd4b8ef4803725ecfa9f922687ccdadd8
src/tests/containerizer/rootfs.cpp 83662fc2c2b9ea902b444bab9c2911df01ee11d5
Diff: https://reviews.apache.org/r/69540/diff/1/
Testing
-------
internal CI
Thanks,
Andrei Budnik
Re: Review Request 69540: Added
`ROOT_PseudoDevicesWithRootFilesystem` test.
Posted by Gilbert Song <so...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/69540/#review211175
-----------------------------------------------------------
Ship it!
Ship It!
- Gilbert Song
On Dec. 10, 2018, 8:41 a.m., Andrei Budnik wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/69540/
> -----------------------------------------------------------
>
> (Updated Dec. 10, 2018, 8:41 a.m.)
>
>
> Review request for mesos, Jie Yu and James Peach.
>
>
> Bugs: MESOS-9462
> https://issues.apache.org/jira/browse/MESOS-9462
>
>
> Repository: mesos
>
>
> Description
> -------
>
> This test verifies that pseudo devices like /dev/random are properly
> mounted in the container's root filesystem.
>
>
> Diffs
> -----
>
> src/tests/containerizer/linux_filesystem_isolator_tests.cpp 84b342cdd4b8ef4803725ecfa9f922687ccdadd8
> src/tests/containerizer/rootfs.cpp 83662fc2c2b9ea902b444bab9c2911df01ee11d5
>
>
> Diff: https://reviews.apache.org/r/69540/diff/1/
>
>
> Testing
> -------
>
> internal CI
>
>
> Thanks,
>
> Andrei Budnik
>
>
Re: Review Request 69540: Added
`ROOT_PseudoDevicesWithRootFilesystem` test.
Posted by Mesos Reviewbot Windows <re...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/69540/#review211156
-----------------------------------------------------------
PASS: Mesos patch 69540 was successfully built and tested.
Reviews applied: `['69540']`
All the build artifacts available at: http://dcos-win.westus2.cloudapp.azure.com/artifacts/mesos-reviewbot-testing/2687/mesos-review-69540
- Mesos Reviewbot Windows
On Dec. 10, 2018, 4:41 p.m., Andrei Budnik wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/69540/
> -----------------------------------------------------------
>
> (Updated Dec. 10, 2018, 4:41 p.m.)
>
>
> Review request for mesos, Jie Yu and James Peach.
>
>
> Bugs: MESOS-9462
> https://issues.apache.org/jira/browse/MESOS-9462
>
>
> Repository: mesos
>
>
> Description
> -------
>
> This test verifies that pseudo devices like /dev/random are properly
> mounted in the container's root filesystem.
>
>
> Diffs
> -----
>
> src/tests/containerizer/linux_filesystem_isolator_tests.cpp 84b342cdd4b8ef4803725ecfa9f922687ccdadd8
> src/tests/containerizer/rootfs.cpp 83662fc2c2b9ea902b444bab9c2911df01ee11d5
>
>
> Diff: https://reviews.apache.org/r/69540/diff/1/
>
>
> Testing
> -------
>
> internal CI
>
>
> Thanks,
>
> Andrei Budnik
>
>
Re: Review Request 69540: Added
`ROOT_PseudoDevicesWithRootFilesystem` test.
Posted by Jie Yu <yu...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/69540/#review211151
-----------------------------------------------------------
Ship it!
Ship It!
- Jie Yu
On Dec. 10, 2018, 4:41 p.m., Andrei Budnik wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/69540/
> -----------------------------------------------------------
>
> (Updated Dec. 10, 2018, 4:41 p.m.)
>
>
> Review request for mesos, Jie Yu and James Peach.
>
>
> Bugs: MESOS-9462
> https://issues.apache.org/jira/browse/MESOS-9462
>
>
> Repository: mesos
>
>
> Description
> -------
>
> This test verifies that pseudo devices like /dev/random are properly
> mounted in the container's root filesystem.
>
>
> Diffs
> -----
>
> src/tests/containerizer/linux_filesystem_isolator_tests.cpp 84b342cdd4b8ef4803725ecfa9f922687ccdadd8
> src/tests/containerizer/rootfs.cpp 83662fc2c2b9ea902b444bab9c2911df01ee11d5
>
>
> Diff: https://reviews.apache.org/r/69540/diff/1/
>
>
> Testing
> -------
>
> internal CI
>
>
> Thanks,
>
> Andrei Budnik
>
>
Re: Review Request 69540: Added
`ROOT_PseudoDevicesWithRootFilesystem` test.
Posted by Andrei Budnik <ab...@mesosphere.com>.
> On Dec. 10, 2018, 5:06 p.m., James Peach wrote:
> > src/tests/containerizer/linux_filesystem_isolator_tests.cpp
> > Lines 137 (patched)
> > <https://reviews.apache.org/r/69540/diff/1/?file=2112780#file2112780line137>
> >
> > As a separate commit, can we factor out the flags set up from all these test case?
The following patch in the patch chain factors out the flags.
- Andrei
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/69540/#review211146
-----------------------------------------------------------
On Dec. 10, 2018, 4:41 p.m., Andrei Budnik wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/69540/
> -----------------------------------------------------------
>
> (Updated Dec. 10, 2018, 4:41 p.m.)
>
>
> Review request for mesos, Jie Yu and James Peach.
>
>
> Bugs: MESOS-9462
> https://issues.apache.org/jira/browse/MESOS-9462
>
>
> Repository: mesos
>
>
> Description
> -------
>
> This test verifies that pseudo devices like /dev/random are properly
> mounted in the container's root filesystem.
>
>
> Diffs
> -----
>
> src/tests/containerizer/linux_filesystem_isolator_tests.cpp 84b342cdd4b8ef4803725ecfa9f922687ccdadd8
> src/tests/containerizer/rootfs.cpp 83662fc2c2b9ea902b444bab9c2911df01ee11d5
>
>
> Diff: https://reviews.apache.org/r/69540/diff/1/
>
>
> Testing
> -------
>
> internal CI
>
>
> Thanks,
>
> Andrei Budnik
>
>
Re: Review Request 69540: Added
`ROOT_PseudoDevicesWithRootFilesystem` test.
Posted by James Peach <jp...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/69540/#review211146
-----------------------------------------------------------
Fix it, then Ship it!
src/tests/containerizer/linux_filesystem_isolator_tests.cpp
Lines 137 (patched)
<https://reviews.apache.org/r/69540/#comment296078>
As a separate commit, can we factor out the flags set up from all these test case?
src/tests/containerizer/linux_filesystem_isolator_tests.cpp
Lines 156 (patched)
<https://reviews.apache.org/r/69540/#comment296082>
Writing to /dev/full should fail with ENOSPC, but I don't see a straightforward way to verify that with dd.
- James Peach
On Dec. 10, 2018, 4:41 p.m., Andrei Budnik wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/69540/
> -----------------------------------------------------------
>
> (Updated Dec. 10, 2018, 4:41 p.m.)
>
>
> Review request for mesos, Jie Yu and James Peach.
>
>
> Bugs: MESOS-9462
> https://issues.apache.org/jira/browse/MESOS-9462
>
>
> Repository: mesos
>
>
> Description
> -------
>
> This test verifies that pseudo devices like /dev/random are properly
> mounted in the container's root filesystem.
>
>
> Diffs
> -----
>
> src/tests/containerizer/linux_filesystem_isolator_tests.cpp 84b342cdd4b8ef4803725ecfa9f922687ccdadd8
> src/tests/containerizer/rootfs.cpp 83662fc2c2b9ea902b444bab9c2911df01ee11d5
>
>
> Diff: https://reviews.apache.org/r/69540/diff/1/
>
>
> Testing
> -------
>
> internal CI
>
>
> Thanks,
>
> Andrei Budnik
>
>