You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@ant.apache.org by bu...@apache.org on 2012/09/03 17:30:21 UTC
[Bug 53821] New: IdentityStack.removeAll() is slow
https://issues.apache.org/bugzilla/show_bug.cgi?id=53821
Priority: P2
Bug ID: 53821
Assignee: notifications@ant.apache.org
Summary: IdentityStack.removeAll() is slow
Severity: normal
Classification: Unclassified
OS: Linux
Reporter: nistor1@illinois.edu
Hardware: PC
Status: NEW
Version: 1.8.4
Component: Core
Product: Ant
Created attachment 29320
--> https://issues.apache.org/bugzilla/attachment.cgi?id=29320&action=edit
patch
"IdentityStack.removeAll(Collection coll)" has the same performance
problem as the previously fixed Bug 53622 (for
"VectorSet.retainAll(Collection coll)"). The problem is that
"removeAll(Collection coll)" performs "coll.contains(e.next())", which
is slow if for example "coll" is a list.
I attached a patch similar to the one used by Jesse Glick in Bug
53622. I also attached a test that exposes this problem. For this
test, the patch provides a 97X speedup on my machine.
To run the test, just do:
$ java Test
The output for the un-patched version is:
Time is 2516
The output for the patched version is:
Time is 26
--
You are receiving this mail because:
You are the assignee for the bug.
[Bug 53821] IdentityStack.removeAll() is slow
Posted by bu...@apache.org.
https://issues.apache.org/bugzilla/show_bug.cgi?id=53821
--- Comment #1 from Adrian Nistor <ni...@illinois.edu> ---
Created attachment 29321
--> https://issues.apache.org/bugzilla/attachment.cgi?id=29321&action=edit
test
--
You are receiving this mail because:
You are the assignee for the bug.
[Bug 53821] IdentityStack.removeAll() is slow
Posted by bu...@apache.org.
https://issues.apache.org/bugzilla/show_bug.cgi?id=53821
Jesse Glick <jg...@apache.org> changed:
What |Removed |Added
----------------------------------------------------------------------------
Keywords| |PatchAvailable
--
You are receiving this mail because:
You are the assignee for the bug.
[Bug 53821] IdentityStack.removeAll() is slow
Posted by bu...@apache.org.
https://issues.apache.org/bugzilla/show_bug.cgi?id=53821
Stefan Bodewig <bo...@apache.org> changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|NEW |RESOLVED
Resolution|--- |FIXED
Target Milestone|--- |1.9.4
--- Comment #2 from Stefan Bodewig <bo...@apache.org> ---
svn revision 1554813
--
You are receiving this mail because:
You are the assignee for the bug.
[Bug 53821] IdentityStack.removeAll() is slow
Posted by bu...@apache.org.
https://issues.apache.org/bugzilla/show_bug.cgi?id=53821
Antoine Levy-Lambert <an...@apache.org> changed:
What |Removed |Added
----------------------------------------------------------------------------
Version|1.9.0 |1.9.1
--
You are receiving this mail because:
You are the assignee for the bug.
[Bug 53821] IdentityStack.removeAll() is slow
Posted by bu...@apache.org.
https://issues.apache.org/bugzilla/show_bug.cgi?id=53821
Antoine Levy-Lambert <an...@apache.org> changed:
What |Removed |Added
----------------------------------------------------------------------------
Version|1.8.4 |1.9.0
--
You are receiving this mail because:
You are the assignee for the bug.
[Bug 53821] IdentityStack.removeAll() is slow
Posted by bu...@apache.org.
https://issues.apache.org/bugzilla/show_bug.cgi?id=53821
Adrian Nistor <ni...@illinois.edu> changed:
What |Removed |Added
----------------------------------------------------------------------------
CC| |nistor1@illinois.edu
--
You are receiving this mail because:
You are the assignee for the bug.