[jira] [Updated] (WICKET-4027) Consider dropping MockPageManager and use mock IPageStore instead

["Martin Grigorov (JIRA)" <ji...@apache.org>]

     [ https://issues.apache.org/jira/browse/WICKET-4027?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Martin Grigorov updated WICKET-4027:
------------------------------------

    Attachment: WICKET-4027-2.patch

Attaching a patch for the second problem. 
It should be used only if the suggested approach with MockPageStore doesn't work for some reason.

> Consider dropping MockPageManager and use mock IPageStore instead
> -----------------------------------------------------------------
>
>                 Key: WICKET-4027
>                 URL: https://issues.apache.org/jira/browse/WICKET-4027
>             Project: Wicket
>          Issue Type: Improvement
>          Components: wicket
>    Affects Versions: 1.5-RC7
>            Reporter: Martin Grigorov
>            Assignee: Martin Grigorov
>         Attachments: WICKET-4027-2.patch
>
>
> Currently WicketTester setups custom IPageManager (MockPageManager) which has several problems:
> 1) it saves stateless pages - touchPage(statelessPage) shouldn't be stored
> 2) it calls #detach() for all pages ever stored in the map. it should call it only on the pages stored in the last request.
> If we fix these problems then we are going to reimplement the default IPageManager (StorePageManager). So I suggest to drop MockPageManager and setup inmemory IPageStore behind it instead. This way we can test PageStoreBehavior as well.

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira