You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@ambari.apache.org by Tom Beerbower <tb...@hortonworks.com> on 2014/08/26 02:12:11 UTC
Review Request 25045: href is wrong for sub resource query of request
resource
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/25045/
-----------------------------------------------------------
Review request for Ambari, Jonathan Hurley and John Speidel.
Bugs: ambari-7007
https://issues.apache.org/jira/browse/ambari-7007
Repository: ambari
Description
-------
the href under "items" is incorrect in that it has a trailing '/' which shouldn't be there
"href" : "http://172.19.226.16:8080/api/v1/requests?tasks/Tasks/status=COMPLETED/"
{
"href" : "http://c6401.ambari.apache.org:8080/api/v1/requests/1?tasks/Tasks/status=COMPLETED/",
"Requests" : {
"id" : 1
},
"tasks" : [
{
"href" : "http://c6401.ambari.apache.org:8080/api/v1/requests/1/tasks/2",
"Tasks" : {
"id" : 2,
"request_id" : 1,
"status" : "COMPLETED"
}
}
]
}
Diffs
-----
ambari-server/src/main/java/org/apache/ambari/server/api/resources/RequestResourceDefinition.java a3920d1
Diff: https://reviews.apache.org/r/25045/diff/
Testing
-------
Manual test. All existing unit tests pass.
Results :
Tests run: 1935, Failures: 0, Errors: 0, Skipped: 15
...
[INFO] ------------------------------------------------------------------------
[INFO] BUILD SUCCESS
[INFO] ------------------------------------------------------------------------
[INFO] Total time: 39:20.821s
[INFO] Finished at: Mon Aug 25 18:16:20 EDT 2014
[INFO] Final Memory: 37M/123M
[INFO] ------------------------------------------------------------------------
Thanks,
Tom Beerbower
Re: Review Request 25045: href is wrong for sub resource query of
request resource
Posted by Tom Beerbower <tb...@hortonworks.com>.
> On Aug. 26, 2014, 12:16 p.m., Jonathan Hurley wrote:
> > Ship It!
Thanks for reviewing!
- Tom
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/25045/#review51519
-----------------------------------------------------------
On Aug. 26, 2014, 12:12 a.m., Tom Beerbower wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/25045/
> -----------------------------------------------------------
>
> (Updated Aug. 26, 2014, 12:12 a.m.)
>
>
> Review request for Ambari, Jonathan Hurley and John Speidel.
>
>
> Bugs: ambari-7007
> https://issues.apache.org/jira/browse/ambari-7007
>
>
> Repository: ambari
>
>
> Description
> -------
>
>
> the href under "items" is incorrect in that it has a trailing '/' which shouldn't be there
>
> "href" : "http://172.19.226.16:8080/api/v1/requests?tasks/Tasks/status=COMPLETED/"
>
> {
> "href" : "http://c6401.ambari.apache.org:8080/api/v1/requests/1?tasks/Tasks/status=COMPLETED/",
> "Requests" : {
> "id" : 1
> },
> "tasks" : [
> {
> "href" : "http://c6401.ambari.apache.org:8080/api/v1/requests/1/tasks/2",
> "Tasks" : {
> "id" : 2,
> "request_id" : 1,
> "status" : "COMPLETED"
> }
> }
> ]
> }
>
>
> Diffs
> -----
>
> ambari-server/src/main/java/org/apache/ambari/server/api/resources/RequestResourceDefinition.java a3920d1
>
> Diff: https://reviews.apache.org/r/25045/diff/
>
>
> Testing
> -------
>
> Manual test. All existing unit tests pass.
>
> Results :
>
> Tests run: 1935, Failures: 0, Errors: 0, Skipped: 15
>
> ...
>
> [INFO] ------------------------------------------------------------------------
> [INFO] BUILD SUCCESS
> [INFO] ------------------------------------------------------------------------
> [INFO] Total time: 39:20.821s
> [INFO] Finished at: Mon Aug 25 18:16:20 EDT 2014
> [INFO] Final Memory: 37M/123M
> [INFO] ------------------------------------------------------------------------
>
>
> Thanks,
>
> Tom Beerbower
>
>
Re: Review Request 25045: href is wrong for sub resource query of
request resource
Posted by Jonathan Hurley <jh...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/25045/#review51519
-----------------------------------------------------------
Ship it!
Ship It!
- Jonathan Hurley
On Aug. 25, 2014, 8:12 p.m., Tom Beerbower wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/25045/
> -----------------------------------------------------------
>
> (Updated Aug. 25, 2014, 8:12 p.m.)
>
>
> Review request for Ambari, Jonathan Hurley and John Speidel.
>
>
> Bugs: ambari-7007
> https://issues.apache.org/jira/browse/ambari-7007
>
>
> Repository: ambari
>
>
> Description
> -------
>
>
> the href under "items" is incorrect in that it has a trailing '/' which shouldn't be there
>
> "href" : "http://172.19.226.16:8080/api/v1/requests?tasks/Tasks/status=COMPLETED/"
>
> {
> "href" : "http://c6401.ambari.apache.org:8080/api/v1/requests/1?tasks/Tasks/status=COMPLETED/",
> "Requests" : {
> "id" : 1
> },
> "tasks" : [
> {
> "href" : "http://c6401.ambari.apache.org:8080/api/v1/requests/1/tasks/2",
> "Tasks" : {
> "id" : 2,
> "request_id" : 1,
> "status" : "COMPLETED"
> }
> }
> ]
> }
>
>
> Diffs
> -----
>
> ambari-server/src/main/java/org/apache/ambari/server/api/resources/RequestResourceDefinition.java a3920d1
>
> Diff: https://reviews.apache.org/r/25045/diff/
>
>
> Testing
> -------
>
> Manual test. All existing unit tests pass.
>
> Results :
>
> Tests run: 1935, Failures: 0, Errors: 0, Skipped: 15
>
> ...
>
> [INFO] ------------------------------------------------------------------------
> [INFO] BUILD SUCCESS
> [INFO] ------------------------------------------------------------------------
> [INFO] Total time: 39:20.821s
> [INFO] Finished at: Mon Aug 25 18:16:20 EDT 2014
> [INFO] Final Memory: 37M/123M
> [INFO] ------------------------------------------------------------------------
>
>
> Thanks,
>
> Tom Beerbower
>
>