You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@tvm.apache.org by GitBox <gi...@apache.org> on 2022/10/21 00:06:09 UTC

[GitHub] [tvm] vinx13 commented on a diff in pull request #13081: [TIR][Arith] Support negative coeff in ModularSet

vinx13 commented on code in PR #13081:
URL: https://github.com/apache/tvm/pull/13081#discussion_r1001232247


##########
tests/python/unittest/test_arith_canonical_simplify.py:
##########
@@ -97,6 +97,8 @@ def test_split_index_simplify():
     # cannot simplify mixed case, unless we canonicalize into one mode.
     ck.verify(tdiv(x, 6) * 2 + tmod(fld(x, 3), 2), tdiv(x, 6) * 2 + tmod(fld(x, 3), 2))
 
+    ck.verify(tmod(-x, 2), tmod(x, -2) * -1)

Review Comment:
   does this cover modular set analysis?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@tvm.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org