Re: svn commit: r431948 - /lenya/trunk/src/java/org/apache/lenya/cms/cocoon/components/modules/input/PageEnvelopeModule.java

[Andreas Hartmann <an...@apache.org>]

Hi Thorsten,

thorsten@apache.org wrote:
> Author: thorsten
> Date: Wed Aug 16 10:03:41 2006
> New Revision: 431948
> 
> URL: http://svn.apache.org/viewvc?rev=431948&view=rev
> Log:
> Updating the page-envelope to return the path and not the uuid for document-path
> 
> Modified:
>     lenya/trunk/src/java/org/apache/lenya/cms/cocoon/components/modules/input/PageEnvelopeModule.java
> 
> Modified: lenya/trunk/src/java/org/apache/lenya/cms/cocoon/components/modules/input/PageEnvelopeModule.java
> URL: http://svn.apache.org/viewvc/lenya/trunk/src/java/org/apache/lenya/cms/cocoon/components/modules/input/PageEnvelopeModule.java?rev=431948&r1=431947&r2=431948&view=diff
> ==============================================================================
> --- lenya/trunk/src/java/org/apache/lenya/cms/cocoon/components/modules/input/PageEnvelopeModule.java (original)
> +++ lenya/trunk/src/java/org/apache/lenya/cms/cocoon/components/modules/input/PageEnvelopeModule.java Wed Aug 16 10:03:41 2006
> @@ -95,7 +95,7 @@
>                  } else if (name.equals(PageEnvelope.DOCUMENT_URL_WITHOUT_LANGUAGE)) {
>                      value = document.getCanonicalWebappURL();
>                  } else if (name.equals(PageEnvelope.DOCUMENT_PATH)) {
> -                    value = envelope.getDocumentPath();
> +                    value = document.getLocator().getPath();

I'm not sure if this was really intended, because the semantics of these
methods are quite different - envelope.getDocumentPath() returns the file
system path, document.getLocator().getPath() returns the path in the site
structure.

I agree to this change, since the file system path shouldn't be used
anymore and the term "path" is used for the location in the site structure
now, I just wanted to note that this might break some things.

-- Andreas



-- 
Andreas Hartmann
Wyona Inc.  -   Open Source Content Management   -   Apache Lenya
http://www.wyona.com                      http://lenya.apache.org
andreas.hartmann@wyona.com                     andreas@apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lenya.apache.org
For additional commands, e-mail: dev-help@lenya.apache.org