You are viewing a plain text version of this content. The canonical link for it is here.

Posted to reviews@spark.apache.org by gatorsmile <gi...@git.apache.org> on 2016/08/24 18:52:35 UTC

[GitHub] spark pull request #14793: [SPARK-17221] [SQL] Build File-based Test Cases f...

GitHub user gatorsmile opened a pull request:

    https://github.com/apache/spark/pull/14793

    [SPARK-17221] [SQL] Build File-based Test Cases for Using Join and Left-Semi Join

    ### What changes were proposed in this pull request?
    This PR is part of the original PR: https://github.com/apache/spark/pull/14625.
    
    Based on file-based SQL end-to-end testing framework in `SQLQueryTestSuite`, this PR is to create test cases for `left-semi` joins and `using` joins. We did not change the data and query, and thus, the queries and results should match the original ones.
    
    In addition, this PR also moved the test cases from `SQLQuerySuite` to `DataFrameJoinSuite`, because these test cases are not using SQL.
    
    ### How was this patch tested?
    N/A

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/gatorsmile/spark moveUsingAndLeftSemiJoins

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/spark/pull/14793.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #14793
    
----
commit 85aedf8e770a3357ddd218732804096234a922d0
Author: gatorsmile <ga...@gmail.com>
Date:   2016-08-24T18:24:56Z

    move test cases for using joins

commit 5a42c4af7513ebd5bf53cf4e5c9e49972a154f8a
Author: gatorsmile <ga...@gmail.com>
Date:   2016-08-24T18:35:13Z

    move test cases for left-semi joins

commit 6b6e2577a9ac09bc3b8052a283c22556d28274a1
Author: gatorsmile <ga...@gmail.com>
Date:   2016-08-24T18:45:12Z

    move test cases from sqlquerysuite to dataframesuite

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] spark issue #14793: [SPARK-17221] [SQL] Build File-based Test Cases for Usin...

Posted by AmplabJenkins <gi...@git.apache.org>.

Github user AmplabJenkins commented on the issue:

    https://github.com/apache/spark/pull/14793
  
    Merged build finished. Test PASSed.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] spark issue #14793: [SPARK-17221] [SQL] Build File-based Test Cases for Usin...

Posted by SparkQA <gi...@git.apache.org>.

Github user SparkQA commented on the issue:

    https://github.com/apache/spark/pull/14793
  
    **[Test build #64371 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/64371/consoleFull)** for PR 14793 at commit [`6b6e257`](https://github.com/apache/spark/commit/6b6e2577a9ac09bc3b8052a283c22556d28274a1).


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] spark issue #14793: [SPARK-17221] [SQL] Build File-based Test Cases for Usin...

Posted by AmplabJenkins <gi...@git.apache.org>.

Github user AmplabJenkins commented on the issue:

    https://github.com/apache/spark/pull/14793
  
    Test PASSed.
    Refer to this link for build results (access rights to CI server needed): 
    https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/65300/
    Test PASSed.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] spark issue #14793: [SPARK-17221] [SQL] Build File-based Test Cases for Usin...

Posted by gatorsmile <gi...@git.apache.org>.

Github user gatorsmile commented on the issue:

    https://github.com/apache/spark/pull/14793
  
    retest this please


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] spark issue #14793: [SPARK-17221] [SQL] Build File-based Test Cases for Usin...

Posted by SparkQA <gi...@git.apache.org>.

Github user SparkQA commented on the issue:

    https://github.com/apache/spark/pull/14793
  
    **[Test build #65300 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/65300/consoleFull)** for PR 14793 at commit [`81c404e`](https://github.com/apache/spark/commit/81c404ec09a1c4646c11ae5142d28d563dfdf61c).
     * This patch passes all tests.
     * This patch merges cleanly.
     * This patch adds no public classes.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] spark issue #14793: [SPARK-17221] [SQL] Build File-based Test Cases for Usin...

Posted by SparkQA <gi...@git.apache.org>.

Github user SparkQA commented on the issue:

    https://github.com/apache/spark/pull/14793
  
    **[Test build #64837 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/64837/consoleFull)** for PR 14793 at commit [`81c404e`](https://github.com/apache/spark/commit/81c404ec09a1c4646c11ae5142d28d563dfdf61c).


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] spark issue #14793: [SPARK-17221] [SQL] Build File-based Test Cases for Usin...

Posted by gatorsmile <gi...@git.apache.org>.

Github user gatorsmile commented on the issue:

    https://github.com/apache/spark/pull/14793
  
    To reviewers: to make it easier to review, each commit can be reviewed separately. The name of each commit is self descriptive


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] spark issue #14793: [SPARK-17221] [SQL] Build File-based Test Cases for Usin...

Posted by AmplabJenkins <gi...@git.apache.org>.

Github user AmplabJenkins commented on the issue:

    https://github.com/apache/spark/pull/14793
  
    Test PASSed.
    Refer to this link for build results (access rights to CI server needed): 
    https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/64837/
    Test PASSed.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] spark issue #14793: [SPARK-17221] [SQL] Build File-based Test Cases for Usin...

Posted by cloud-fan <gi...@git.apache.org>.

Github user cloud-fan commented on the issue:

    https://github.com/apache/spark/pull/14793
  
    LGTM


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] spark issue #14793: [SPARK-17221] [SQL] Build File-based Test Cases for Usin...

Posted by AmplabJenkins <gi...@git.apache.org>.

Github user AmplabJenkins commented on the issue:

    https://github.com/apache/spark/pull/14793
  
    Test PASSed.
    Refer to this link for build results (access rights to CI server needed): 
    https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/64371/
    Test PASSed.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] spark issue #14793: [SPARK-17221] [SQL] Build File-based Test Cases for Usin...

Posted by SparkQA <gi...@git.apache.org>.

Github user SparkQA commented on the issue:

    https://github.com/apache/spark/pull/14793
  
    **[Test build #64837 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/64837/consoleFull)** for PR 14793 at commit [`81c404e`](https://github.com/apache/spark/commit/81c404ec09a1c4646c11ae5142d28d563dfdf61c).
     * This patch passes all tests.
     * This patch merges cleanly.
     * This patch adds no public classes.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] spark issue #14793: [SPARK-17221] [SQL] Build File-based Test Cases for Usin...

Posted by SparkQA <gi...@git.apache.org>.

Github user SparkQA commented on the issue:

    https://github.com/apache/spark/pull/14793
  
    **[Test build #64371 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/64371/consoleFull)** for PR 14793 at commit [`6b6e257`](https://github.com/apache/spark/commit/6b6e2577a9ac09bc3b8052a283c22556d28274a1).
     * This patch passes all tests.
     * This patch merges cleanly.
     * This patch adds no public classes.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org