You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@reef.apache.org by "Andrew Chung (JIRA)" <ji...@apache.org> on 2016/01/29 00:55:39 UTC

[jira] [Commented] (REEF-886) Change public methods in ClassHierarchy as internal

    [ https://issues.apache.org/jira/browse/REEF-886?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15122564#comment-15122564 ] 

Andrew Chung commented on REEF-886:
-----------------------------------

Done in https://issues.apache.org/jira/browse/REEF-1095.

> Change public methods in ClassHierarchy as internal
> ---------------------------------------------------
>
>                 Key: REEF-886
>                 URL: https://issues.apache.org/jira/browse/REEF-886
>             Project: REEF
>          Issue Type: Improvement
>            Reporter: Julia
>             Fix For: 0.14
>
>
> Currently most of Tang ClassHierachy methods are public. 
> As a generic tool, it is OK to make them as public, especially some APIs are designed to be shared cross Languages. 
> But from Tang perspective, what we should exposed to the user should be mainly Configuration and Injection methods. The methods such as GetNote() in class hierarchy should be hide to the Tang user. 
> We should look at this issue to see what Hierarchy APIs can be turned into internal. 



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)