You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@trafficserver.apache.org by "Igor Brezac (Created) (JIRA)" <ji...@apache.org> on 2012/03/15 21:06:38 UTC
[jira] [Created] (TS-1140) Implement HTTP method filtering in
ip_allow.config
Implement HTTP method filtering in ip_allow.config
--------------------------------------------------
Key: TS-1140
URL: https://issues.apache.org/jira/browse/TS-1140
Project: Traffic Server
Issue Type: New Feature
Components: HTTP
Affects Versions: 3.1.2, 3.1.3
Reporter: Igor Brezac
Priority: Critical
Fix For: 3.1.3
Implement HTTP method filtering in ip_allow.config (and deprecate proxy.config.http.quick_filter.mask)
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (TS-1140) Implement HTTP method filtering in
ip_allow.config
Posted by "Igor Brezac (Updated) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/TS-1140?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Igor Brezac updated TS-1140:
----------------------------
Attachment: (was: ts-1140-v2.diff)
> Implement HTTP method filtering in ip_allow.config
> --------------------------------------------------
>
> Key: TS-1140
> URL: https://issues.apache.org/jira/browse/TS-1140
> Project: Traffic Server
> Issue Type: New Feature
> Components: HTTP
> Affects Versions: 3.1.3, 3.1.2
> Reporter: Igor Brezac
> Priority: Critical
> Fix For: 3.1.3
>
> Attachments: ts-1140-v2.diff, ts-1140.diff, ts.patch
>
>
> Implement HTTP method filtering in ip_allow.config (and deprecate proxy.config.http.quick_filter.mask)
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Issue Comment Edited] (TS-1140) Implement HTTP method
filtering in ip_allow.config
Posted by "Alan M. Carroll (Issue Comment Edited) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/TS-1140?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13230872#comment-13230872 ]
Alan M. Carroll edited comment on TS-1140 at 3/16/12 3:42 AM:
--------------------------------------------------------------
Updated patch. I think I got most of Igor's issues.
was (Author: amc):
Updated patch.
> Implement HTTP method filtering in ip_allow.config
> --------------------------------------------------
>
> Key: TS-1140
> URL: https://issues.apache.org/jira/browse/TS-1140
> Project: Traffic Server
> Issue Type: New Feature
> Components: HTTP
> Affects Versions: 3.1.3, 3.1.2
> Reporter: Igor Brezac
> Priority: Critical
> Fix For: 3.1.3
>
> Attachments: ts-1140.diff, ts.patch
>
>
> Implement HTTP method filtering in ip_allow.config (and deprecate proxy.config.http.quick_filter.mask)
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (TS-1140) Implement HTTP method filtering in
ip_allow.config
Posted by "Igor Galić (Commented JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/TS-1140?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13230739#comment-13230739 ]
Igor Galić commented on TS-1140:
--------------------------------
I don't like the smell of STL in this code, but it's been in before, so that's not Igor's beef.
line 107, while you're at it, please change the if()/else to have { braces }
lines 129-138 are incomprehensible.. to me. Don't we have anywhere a foreach template? Alan...? ;)
what's happening in line 164 of that patch with the snprintf?
Looks like you're using tabs - our code uses spaces.
Two questions or.. wishes:
{code}
+src_ip=0.0.0.0-255.255.255.255 action=ip_deny method=PUSH|PURGE|DELETE
{code}
Maybe I'm delusioned, but I thought we had a /network notation somewhere around. Maybe it's just wishful thinking because in httpd we do.
And finally: This is my remap config:
{code}
map / http://127.0.0.1:8000 @method=GET @method=POST @method=HEAD @method=OPTIONS @action=allow
{code}
I used this because quickfilters where broken. But now that they worked and you moved the code to IpAllow.cc -- which part of our code takes care of parsing ^ that?
> Implement HTTP method filtering in ip_allow.config
> --------------------------------------------------
>
> Key: TS-1140
> URL: https://issues.apache.org/jira/browse/TS-1140
> Project: Traffic Server
> Issue Type: New Feature
> Components: HTTP
> Affects Versions: 3.1.3, 3.1.2
> Reporter: Igor Brezac
> Priority: Critical
> Fix For: 3.1.3
>
> Attachments: ts.patch
>
>
> Implement HTTP method filtering in ip_allow.config (and deprecate proxy.config.http.quick_filter.mask)
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (TS-1140) Implement HTTP method filtering in
ip_allow.config
Posted by "Alan M. Carroll (Updated) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/TS-1140?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Alan M. Carroll updated TS-1140:
--------------------------------
Attachment: ts-1140.diff
Updated patch.
> Implement HTTP method filtering in ip_allow.config
> --------------------------------------------------
>
> Key: TS-1140
> URL: https://issues.apache.org/jira/browse/TS-1140
> Project: Traffic Server
> Issue Type: New Feature
> Components: HTTP
> Affects Versions: 3.1.3, 3.1.2
> Reporter: Igor Brezac
> Priority: Critical
> Fix For: 3.1.3
>
> Attachments: ts-1140.diff, ts.patch
>
>
> Implement HTTP method filtering in ip_allow.config (and deprecate proxy.config.http.quick_filter.mask)
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (TS-1140) Implement HTTP method filtering in
ip_allow.config
Posted by "Igor Brezac (Updated) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/TS-1140?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Igor Brezac updated TS-1140:
----------------------------
Attachment: ts-1140-v2.diff
> Implement HTTP method filtering in ip_allow.config
> --------------------------------------------------
>
> Key: TS-1140
> URL: https://issues.apache.org/jira/browse/TS-1140
> Project: Traffic Server
> Issue Type: New Feature
> Components: HTTP
> Affects Versions: 3.1.3, 3.1.2
> Reporter: Igor Brezac
> Priority: Critical
> Fix For: 3.1.3
>
> Attachments: ts-1140-v2.diff, ts-1140.diff, ts.patch
>
>
> Implement HTTP method filtering in ip_allow.config (and deprecate proxy.config.http.quick_filter.mask)
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (TS-1140) Implement HTTP method filtering in
ip_allow.config
Posted by "Leif Hedstrom (Updated) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/TS-1140?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Leif Hedstrom updated TS-1140:
------------------------------
Fix Version/s: (was: 3.1.3)
3.1.4
> Implement HTTP method filtering in ip_allow.config
> --------------------------------------------------
>
> Key: TS-1140
> URL: https://issues.apache.org/jira/browse/TS-1140
> Project: Traffic Server
> Issue Type: New Feature
> Components: HTTP
> Affects Versions: 3.1.3, 3.1.2
> Reporter: Igor Brezac
> Priority: Critical
> Fix For: 3.1.4
>
> Attachments: ts-1140-v2.diff, ts-1140.diff, ts.patch
>
>
> Implement HTTP method filtering in ip_allow.config (and deprecate proxy.config.http.quick_filter.mask)
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (TS-1140) Implement HTTP method filtering in
ip_allow.config
Posted by "Alan M. Carroll (Updated) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/TS-1140?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Alan M. Carroll updated TS-1140:
--------------------------------
Attachment: ts-1140.diff
> Implement HTTP method filtering in ip_allow.config
> --------------------------------------------------
>
> Key: TS-1140
> URL: https://issues.apache.org/jira/browse/TS-1140
> Project: Traffic Server
> Issue Type: New Feature
> Components: HTTP
> Affects Versions: 3.1.3, 3.1.2
> Reporter: Igor Brezac
> Priority: Critical
> Fix For: 3.1.3
>
> Attachments: ts-1140.diff, ts.patch
>
>
> Implement HTTP method filtering in ip_allow.config (and deprecate proxy.config.http.quick_filter.mask)
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (TS-1140) Implement HTTP method filtering in
ip_allow.config
Posted by "Alan M. Carroll (Updated) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/TS-1140?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Alan M. Carroll updated TS-1140:
--------------------------------
Attachment: (was: ts-1140.diff)
> Implement HTTP method filtering in ip_allow.config
> --------------------------------------------------
>
> Key: TS-1140
> URL: https://issues.apache.org/jira/browse/TS-1140
> Project: Traffic Server
> Issue Type: New Feature
> Components: HTTP
> Affects Versions: 3.1.3, 3.1.2
> Reporter: Igor Brezac
> Priority: Critical
> Fix For: 3.1.3
>
> Attachments: ts-1140.diff, ts.patch
>
>
> Implement HTTP method filtering in ip_allow.config (and deprecate proxy.config.http.quick_filter.mask)
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (TS-1140) Implement HTTP method filtering in
ip_allow.config
Posted by "Igor Brezac (Updated) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/TS-1140?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Igor Brezac updated TS-1140:
----------------------------
Attachment: ts.patch
> Implement HTTP method filtering in ip_allow.config
> --------------------------------------------------
>
> Key: TS-1140
> URL: https://issues.apache.org/jira/browse/TS-1140
> Project: Traffic Server
> Issue Type: New Feature
> Components: HTTP
> Affects Versions: 3.1.3, 3.1.2
> Reporter: Igor Brezac
> Priority: Critical
> Fix For: 3.1.3
>
> Attachments: ts.patch
>
>
> Implement HTTP method filtering in ip_allow.config (and deprecate proxy.config.http.quick_filter.mask)
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Issue Comment Edited] (TS-1140) Implement HTTP method
filtering in ip_allow.config
Posted by "Igor Brezac (Issue Comment Edited) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/TS-1140?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13230901#comment-13230901 ]
Igor Brezac edited comment on TS-1140 at 3/17/12 4:24 PM:
----------------------------------------------------------
Fixed a few more issues based on Igor's comments.
was (Author: ibrezac):
Fixed a few more issue based on Igor's comments.
> Implement HTTP method filtering in ip_allow.config
> --------------------------------------------------
>
> Key: TS-1140
> URL: https://issues.apache.org/jira/browse/TS-1140
> Project: Traffic Server
> Issue Type: New Feature
> Components: HTTP
> Affects Versions: 3.1.3, 3.1.2
> Reporter: Igor Brezac
> Priority: Critical
> Fix For: 3.1.3
>
> Attachments: ts-1140-v2.diff, ts-1140.diff, ts.patch
>
>
> Implement HTTP method filtering in ip_allow.config (and deprecate proxy.config.http.quick_filter.mask)
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (TS-1140) Implement HTTP method filtering in
ip_allow.config
Posted by "Igor Brezac (Updated) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/TS-1140?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Igor Brezac updated TS-1140:
----------------------------
Attachment: ts-1140-v2.diff
Fixed a few more issue based on Igor's comments.
> Implement HTTP method filtering in ip_allow.config
> --------------------------------------------------
>
> Key: TS-1140
> URL: https://issues.apache.org/jira/browse/TS-1140
> Project: Traffic Server
> Issue Type: New Feature
> Components: HTTP
> Affects Versions: 3.1.3, 3.1.2
> Reporter: Igor Brezac
> Priority: Critical
> Fix For: 3.1.3
>
> Attachments: ts-1140-v2.diff, ts-1140.diff, ts.patch
>
>
> Implement HTTP method filtering in ip_allow.config (and deprecate proxy.config.http.quick_filter.mask)
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira