You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@superset.apache.org by GitBox <gi...@apache.org> on 2020/09/19 07:04:12 UTC
[GitHub] [incubator-superset] jeremy-ecoenergy opened a new issue #10965: Attempting to edit a table column redirects to another table
jeremy-ecoenergy opened a new issue #10965:
URL: https://github.com/apache/incubator-superset/issues/10965
When trying to edit a table column, Superset redirects to another table's definition, followed by the table column listing. This happens across tables, regardless of the database type.
### Expected results
Being able to edit the table column.
### Actual results
It's redirected and I can't edit.
#### Screenshots
#### How to reproduce the bug
1. Go to a table definition, then columns
2. Click on the edit button next to a column
### Environment
Present
### Checklist
Make sure these boxes are checked before submitting your issue - thank you!
- [ ] I have checked the superset logs for python stacktraces and included it here as text if there are any.
- [ ] I have reproduced the issue with at least the latest released version of superset.
- [ ] I have checked the issue tracker for the same issue and I haven't found one similar.
### Additional context
Add any other context about the problem here.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] benceorlai edited a comment on issue #10965: Attempting to edit a table column redirects to another table
Posted by GitBox <gi...@apache.org>.
benceorlai edited a comment on issue #10965:
URL: https://github.com/apache/incubator-superset/issues/10965#issuecomment-713116906
Hi @jeremy-ecoenergy
There was a [PR](https://github.com/apache/incubator-superset/pull/10731) that fixed this in Superset 11 days ago. That improvement was made available in the cloud version a few days later so it should be working as expected. Could you confirm that it is now working?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] stale[bot] commented on issue #10965: Attempting to edit a table column redirects to another table
Posted by GitBox <gi...@apache.org>.
stale[bot] commented on issue #10965:
URL: https://github.com/apache/incubator-superset/issues/10965#issuecomment-751276442
This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions. For admin, please label this issue `.pinned` to prevent stale bot from closing the issue.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] jeremy-ecoenergy commented on issue #10965: Attempting to edit a table column redirects to another table
Posted by GitBox <gi...@apache.org>.
jeremy-ecoenergy commented on issue #10965:
URL: https://github.com/apache/incubator-superset/issues/10965#issuecomment-713349305
It's not clear how this PR fixes the issue? The columns from the SQL query can't be synced.
I did find a workaround by using an incognito window and the legacy data source editor, but it was still buggy.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] nytai commented on issue #10965: Attempting to edit a table column redirects to another table
Posted by GitBox <gi...@apache.org>.
nytai commented on issue #10965:
URL: https://github.com/apache/incubator-superset/issues/10965#issuecomment-697071034
This is weird indeed. @jeremy-ecoenergy as a work around you could use the datasource editor in explore to make changes to your table.
<img width="1001" alt="Screen Shot 2020-09-22 at 6 38 15 PM" src="https://user-images.githubusercontent.com/10255196/93954613-e90e1e80-fd02-11ea-92c4-911a7ad623a4.png">
<img width="2325" alt="Screen Shot 2020-09-22 at 6 38 27 PM" src="https://user-images.githubusercontent.com/10255196/93954615-ea3f4b80-fd02-11ea-9077-d5b6d0014a52.png">
<img width="2480" alt="Screen Shot 2020-09-22 at 6 38 39 PM" src="https://user-images.githubusercontent.com/10255196/93954616-ead7e200-fd02-11ea-9b96-40d9dce6c430.png">
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] JunlinC commented on issue #10965: Attempting to edit a table column redirects to another table
Posted by GitBox <gi...@apache.org>.
JunlinC commented on issue #10965:
URL: https://github.com/apache/incubator-superset/issues/10965#issuecomment-695178295
Thank you Jeremy for reporting, this issue will be prioritized. @benceorlai
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] nytai commented on issue #10965: Attempting to edit a table column redirects to another table
Posted by GitBox <gi...@apache.org>.
nytai commented on issue #10965:
URL: https://github.com/apache/incubator-superset/issues/10965#issuecomment-697071034
This is weird indeed. @jeremy-ecoenergy as a work around you could use the datasource editor in explore to make changes to your table.
<img width="1001" alt="Screen Shot 2020-09-22 at 6 38 15 PM" src="https://user-images.githubusercontent.com/10255196/93954613-e90e1e80-fd02-11ea-92c4-911a7ad623a4.png">
<img width="2325" alt="Screen Shot 2020-09-22 at 6 38 27 PM" src="https://user-images.githubusercontent.com/10255196/93954615-ea3f4b80-fd02-11ea-9077-d5b6d0014a52.png">
<img width="2480" alt="Screen Shot 2020-09-22 at 6 38 39 PM" src="https://user-images.githubusercontent.com/10255196/93954616-ead7e200-fd02-11ea-9b96-40d9dce6c430.png">
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] mistercrunch commented on issue #10965: Attempting to edit a table column redirects to another table
Posted by GitBox <gi...@apache.org>.
mistercrunch commented on issue #10965:
URL: https://github.com/apache/incubator-superset/issues/10965#issuecomment-697140982
This is happening in the "legacy table editor" which we're in the process of deprecating. It's related to an old bug in FAB where is stores the browser history in a session variable. The solution here is to deprecate the legacy table editor.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] JunlinC edited a comment on issue #10965: Attempting to edit a table column redirects to another table
Posted by GitBox <gi...@apache.org>.
JunlinC edited a comment on issue #10965:
URL: https://github.com/apache/incubator-superset/issues/10965#issuecomment-695178295
Thank you Jeremy for reporting, this issue will be prioritized. @benceorlai 🙏
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] benceorlai commented on issue #10965: Attempting to edit a table column redirects to another table
Posted by GitBox <gi...@apache.org>.
benceorlai commented on issue #10965:
URL: https://github.com/apache/incubator-superset/issues/10965#issuecomment-713392671
I might have misunderstood your explanation, sorry. You are correct, for *virtual* datasets, the column sync is not working at the moment. There is another PR [(PR-10645)](https://github.com/apache/incubator-superset/pull/10645) pending for that, we are working on it as we speak.
Additionally, this functional area is getting a lot of changes these weeks, the full extent of the work is shared publicly in the Superset roadmap here --> https://github.com/apache-superset/superset-roadmap/projects/1#card-45405983
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] issue-label-bot[bot] commented on issue #10965: Attempting to edit a table column redirects to another table
Posted by GitBox <gi...@apache.org>.
issue-label-bot[bot] commented on issue #10965:
URL: https://github.com/apache/incubator-superset/issues/10965#issuecomment-695175668
Issue-Label Bot is automatically applying the label `#bug` to this issue, with a confidence of 0.98. Please mark this comment with :thumbsup: or :thumbsdown: to give our bot feedback!
Links: [app homepage](https://github.com/marketplace/issue-label-bot), [dashboard](https://mlbot.net/data/apache/incubator-superset) and [code](https://github.com/hamelsmu/MLapp) for this bot.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] jeremy-ecoenergy commented on issue #10965: Attempting to edit a table column redirects to another table
Posted by GitBox <gi...@apache.org>.
jeremy-ecoenergy commented on issue #10965:
URL: https://github.com/apache/incubator-superset/issues/10965#issuecomment-709865847
Explore -> edit datasource works fine for editing columns, but doesn't allow one to add new columns (which is why I'm trying to do). In this case it's a virtual table derived from an SQL query.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [incubator-superset] benceorlai commented on issue #10965: Attempting to edit a table column redirects to another table
Posted by GitBox <gi...@apache.org>.
benceorlai commented on issue #10965:
URL: https://github.com/apache/incubator-superset/issues/10965#issuecomment-713116906
Hi @jeremy-ecoenergy
There was a [pr](https://github.com/apache/incubator-superset/pull/10731) that fixed this in Superset 11 days ago. That improvement was made available in the cloud version a few days later so it should be working as expected. Could you confirm that it is now working?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org