You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@rocketmq.apache.org by "messere1 (via GitHub)" <gi...@apache.org> on 2026/08/11 08:41:05 UTC
[PR] [studio][ISSUE #1690] Support legacy system theme listeners [rocketmq-dashboard]
messere1 opened a new pull request, #1693:
URL: https://github.com/apache/rocketmq-dashboard/pull/1693
## Summary
- subscribe to system theme changes through MediaQueryList event listeners when available
- fall back to legacy addListener/removeListener in older Safari and embedded WebViews
- clean up through the same API used for subscription
- cover legacy rendering, theme updates, and listener removal
## Root cause and impact
ThemeProvider checked that `matchMedia` existed but assumed its result implemented EventTarget. Legacy MediaQueryList implementations expose only addListener/removeListener, causing the provider effect to throw when the application follows the system theme. Feature detection keeps modern behavior and restores compatibility.
Closes #1690
## Validation
- npm test -- --run src/theme/__tests__/ThemeContext.test.tsx (9 passed)
- npx eslint src/theme/ThemeProvider.tsx src/theme/__tests__/ThemeContext.test.tsx
- npm run build
- git diff --check
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@rocketmq.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [studio][ISSUE #1690] Support legacy system theme listeners [rocketmq-dashboard]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] closed pull request #1693: [studio][ISSUE #1690] Support legacy system theme listeners
URL: https://github.com/apache/rocketmq-dashboard/pull/1693
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@rocketmq.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] [studio][ISSUE #1690] Support legacy system theme listeners [rocketmq-dashboard]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #1693:
URL: https://github.com/apache/rocketmq-dashboard/pull/1693#issuecomment-5363574890
This pull request has been automatically closed because there has been no activity for 7 days. If you would like to continue working on this, please reopen the PR with updated changes.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@rocketmq.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org