You are viewing a plain text version of this content. The canonical link for it is here.

Posted to dev@calcite.apache.org by "Kevin Risden (JIRA)" <ji...@apache.org> on 2018/09/23 02:13:00 UTC

[jira] [Created] (CALCITE-2587) Avatica - Regenerate protobuf for 3.6.1

Kevin Risden created CALCITE-2587:
-------------------------------------

             Summary: Avatica - Regenerate protobuf for 3.6.1
                 Key: CALCITE-2587
                 URL: https://issues.apache.org/jira/browse/CALCITE-2587
             Project: Calcite
          Issue Type: Improvement
          Components: avatica
            Reporter: Kevin Risden
            Assignee: Kevin Risden
             Fix For: avatica-1.13.0


I was looking into deprecation warnings and found that protobuf 3.6.0 should have added suppresswarnings to a few valueOf calls that were deprecated. However, the java files were not being regenerated even with the protobuf-maven-plugin.

It seems like the [checkStaleness|https://www.xolstice.org/protobuf-maven-plugin/compile-mojo.html#checkStaleness] flag was preventing the compilation even after updating protobuf from 3.5.x to 3.6.1.

It doesn't look like there is a good reason to have checkStaleness set to true since the protobuf compilation is pretty quick. This should help us catch protobuf errors sooner.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)