You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@airflow.apache.org by GitBox <gi...@apache.org> on 2020/12/02 00:34:10 UTC
[GitHub] [airflow] danielenricocahall opened a new pull request #12749: Order broken DAG messages in UI
danielenricocahall opened a new pull request #12749:
URL: https://github.com/apache/airflow/pull/12749
In case of existing issue, reference it using one of the following:
closes: https://github.com/apache/airflow/issues/9669
Minor update to ensure that Broken DAG messages are ordered when displayed in the UI. Since the ordering doesn't really matter, it just has to be consistent, I chose to order by the `id` column.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] mik-laj edited a comment on pull request #12749: Order broken DAG messages in UI
Posted by GitBox <gi...@apache.org>.
mik-laj edited a comment on pull request #12749:
URL: https://github.com/apache/airflow/pull/12749#issuecomment-737726449
This won't help because the ID is changed every time the file is processed.
https://github.com/apache/airflow/blob/8f48f12128e0d985c6de2603902524859fecbca8/airflow/jobs/scheduler_job.py#L532-L541
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] kaxil merged pull request #12749: Order broken DAG messages in UI
Posted by GitBox <gi...@apache.org>.
kaxil merged pull request #12749:
URL: https://github.com/apache/airflow/pull/12749
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] mik-laj commented on pull request #12749: Order broken DAG messages in UI
Posted by GitBox <gi...@apache.org>.
mik-laj commented on pull request #12749:
URL: https://github.com/apache/airflow/pull/12749#issuecomment-737726449
This won't help because the ID is changed every time the file is processed.
https://github.com/apache/airflow/blob/master/airflow/jobs/scheduler_job.py#L532-L541
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] mik-laj edited a comment on pull request #12749: Order broken DAG messages in UI
Posted by GitBox <gi...@apache.org>.
mik-laj edited a comment on pull request #12749:
URL: https://github.com/apache/airflow/pull/12749#issuecomment-738496768
I am working on ensuring a permanent ID.
https://github.com/apache/airflow/pull/11960
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] danielenricocahall commented on pull request #12749: Order broken DAG messages in UI
Posted by GitBox <gi...@apache.org>.
danielenricocahall commented on pull request #12749:
URL: https://github.com/apache/airflow/pull/12749#issuecomment-738488092
> This won't help because the ID is changed every time the file is processed.
> https://github.com/apache/airflow/blob/8f48f12128e0d985c6de2603902524859fecbca8/airflow/jobs/scheduler_job.py#L532-L541
Oh no, I didn't realize that :( should we sort by stacktrace or something more consistent?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] mik-laj commented on pull request #12749: Order broken DAG messages in UI
Posted by GitBox <gi...@apache.org>.
mik-laj commented on pull request #12749:
URL: https://github.com/apache/airflow/pull/12749#issuecomment-738496768
I am working on providing a permanent ID.
https://github.com/apache/airflow/pull/11960
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] boring-cyborg[bot] commented on pull request #12749: Order broken DAG messages in UI
Posted by GitBox <gi...@apache.org>.
boring-cyborg[bot] commented on pull request #12749:
URL: https://github.com/apache/airflow/pull/12749#issuecomment-737235132
Awesome work, congrats on your first merged pull request!
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org