[GitHub] [activemq-artemis] michaelpearce-gain commented on a change in pull request #2806: ARTEMIS-2459 Fix err in the replacement of a non-destructively consumed LVQ message

[GitBox <gi...@apache.org>]

michaelpearce-gain commented on a change in pull request #2806: ARTEMIS-2459 Fix err in the replacement of a non-destructively consumed LVQ message
URL: https://github.com/apache/activemq-artemis/pull/2806#discussion_r316213976
 
 

 ##########
 File path: artemis-server/src/main/java/org/apache/activemq/artemis/core/server/impl/LastValueQueue.java
 ##########
 @@ -193,6 +193,17 @@ public void acknowledge(final MessageReference ref, final AckReason reason, fina
       super.acknowledge(ref, reason, consumer);
    }
 
+   @Override
+   public void acknowledge(Transaction tx,
+                           MessageReference ref,
+                           AckReason reason,
+                           ServerConsumer consumer) throws Exception {
+      if (isNonDestructive() && reason == AckReason.EXPIRED || reason == AckReason.KILLED ) {
 
 Review comment:
   Expired should ack even if nondestructive.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services