You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@cloudstack.apache.org by GitBox <gi...@apache.org> on 2021/03/03 13:02:27 UTC

[GitHub] [cloudstack-documentation] GabrielBrascher commented on a change in pull request #192: Wording and command of install guide / "LIBVIRTD_ARGS="--listen"" leads to failure with libvirt6.0.0

GabrielBrascher commented on a change in pull request #192:
URL: https://github.com/apache/cloudstack-documentation/pull/192#discussion_r585286376



##########
File path: source/installguide/management-server/_nfs.rst
##########
@@ -237,12 +237,34 @@ operating system version.
    #. Log back in to the hypervisor host and try to mount the /export
       directories. For example, substitute your own management server
       name:
-
-      .. parsed-literal::
-
-         mkdir /primary
-         mount -t nfs <management-server-name>:/export/primary
-         umount /primary
-         mkdir /secondary
-         mount -t nfs <management-server-name>:/export/secondary
-         umount /secondary
+	
+		#. Creat directories for testing.

Review comment:
       `Creat` -> `Create`

##########
File path: source/installguide/management-server/_database.rst
##########
@@ -22,8 +22,9 @@ node, you can install the MySQL server locally. For an installation that
 has multiple management server nodes, we assume the MySQL database also
 runs on a separate node.
 
-CloudStack has been tested with MySQL 5.1 and 5.5. These versions are
-included in RHEL/CentOS and Ubuntu.
+CloudStack has been tested with MySQL 5.1 ,5.5 and 8.0. The versions 5.1
+and 5.5 are included in RHEL/CentOS and Ubuntu.
+For MySQL 8.0 please refer to the offical / community repositories of the product..

Review comment:
       Remove duplicated `..` at the end.

##########
File path: source/installguide/management-server/_database.rst
##########
@@ -22,8 +22,9 @@ node, you can install the MySQL server locally. For an installation that
 has multiple management server nodes, we assume the MySQL database also
 runs on a separate node.
 
-CloudStack has been tested with MySQL 5.1 and 5.5. These versions are
-included in RHEL/CentOS and Ubuntu.
+CloudStack has been tested with MySQL 5.1 ,5.5 and 8.0. The versions 5.1

Review comment:
       Minnor formatation of the comma: `MySQL 5.1 ,5.5 and 8.0.` ->  `MySQL 5.1, 5.5 and 8.0.`

##########
File path: source/installguide/hypervisor/kvm.rst
##########
@@ -289,15 +289,7 @@ cloudstack-agent and should already be installed.
 #. Turning on "listen\_tcp" in libvirtd.conf is not enough, we have to
    change the parameters as well:
 
-   On RHEL or CentOS modify ``/etc/sysconfig/libvirtd``:
-
-   Uncomment the following line:
-
-   .. parsed-literal::
-
-      #LIBVIRTD_ARGS="--listen"
-
-   On Ubuntu 14.04: modify ``/etc/default/libvirt-bin``
+      On Ubuntu 14.04: modify ``/etc/default/libvirt-bin``

Review comment:
       It would also be good to remove Ubuntu 14.04 from documentation as it is no longer supported.

##########
File path: source/installguide/management-server/_database.rst
##########
@@ -293,6 +294,9 @@ same node for MySQL. See `“Install the Database on the Management Server Node
 
       sudo service mysql restart
 
+	.. note::
+	Before performing a reboot of the management server please check if mysql is configured to start automatically.

Review comment:
       `mysql` -> `MySQL`




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org