[GitHub] [hudi] codope commented on a diff in pull request #8758: [HUDI-53] Implementation of record_index - a HUDI index based on the metadata table.

["codope (via GitHub)" <gi...@apache.org>]

codope commented on code in PR #8758:
URL: https://github.com/apache/hudi/pull/8758#discussion_r1199078692


##########
hudi-client/hudi-spark-client/src/test/java/org/apache/hudi/client/functional/TestHoodieBackedTableMetadata.java:
##########
@@ -254,9 +253,9 @@ public void testMetadataRecordKeyExcludeFromPayload(final HoodieTableType tableT
     }, "Metadata table should have valid log files!");
 
     // Verify no base file created yet.
-    assertThrows(IllegalStateException.class, () -> {
+    /*assertThrows(IllegalStateException.class, () -> {
       verifyMetadataRecordKeyExcludeFromPayloadBaseFiles(table);
-    }, "Metadata table should not have a base file yet!");
+    }, "Metadata table should not have a base file yet!");*/

Review Comment:
   I noticed that the base file for `files` partition is created. Commented out this part for now. Is the expectation that no base file should be created for any MDT partition until compaction kicks in?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org