You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@ambari.apache.org by Padma Priya N <pa...@gmail.com> on 2017/01/23 09:53:01 UTC

Review Request 55834: AMBARI-19669:Not able to add the settings for action nodes in firefox browser

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/55834/
-----------------------------------------------------------

Review request for Ambari, belliraj hb, Gaurav Nagar, Nitiraj Rathore, and Pallav Kulshreshtha.


Bugs: AMBARI-19669
    https://issues.apache.org/jira/browse/AMBARI-19669


Repository: ambari


Description
-------

Mofified the actions structure to an array. Removed the usage of Object.values method which causes the issue.


Diffs
-----

  contrib/views/wfmanager/src/main/resources/ui/app/components/version-settings.js 966313f 
  contrib/views/wfmanager/src/main/resources/ui/app/domain/workflow.js 3c89f5c 
  contrib/views/wfmanager/src/main/resources/ui/app/utils/common-utils.js 8cc40d6 
  contrib/views/wfmanager/src/main/resources/ui/app/utils/constants.js 9126819 

Diff: https://reviews.apache.org/r/55834/diff/


Testing
-------

Manual


Thanks,

Padma Priya N


Re: Review Request 55834: AMBARI-19669:Not able to add the settings for action nodes in firefox browser

Posted by belliraj hb <be...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/55834/#review162619
-----------------------------------------------------------


Ship it!




Ship It!

- belliraj hb


On Jan. 23, 2017, 9:53 a.m., Padma Priya N wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/55834/
> -----------------------------------------------------------
> 
> (Updated Jan. 23, 2017, 9:53 a.m.)
> 
> 
> Review request for Ambari, belliraj hb, Gaurav Nagar, Nitiraj Rathore, and Pallav Kulshreshtha.
> 
> 
> Bugs: AMBARI-19669
>     https://issues.apache.org/jira/browse/AMBARI-19669
> 
> 
> Repository: ambari
> 
> 
> Description
> -------
> 
> Mofified the actions structure to an array. Removed the usage of Object.values method which causes the issue.
> 
> 
> Diffs
> -----
> 
>   contrib/views/wfmanager/src/main/resources/ui/app/components/version-settings.js 966313f 
>   contrib/views/wfmanager/src/main/resources/ui/app/domain/workflow.js 3c89f5c 
>   contrib/views/wfmanager/src/main/resources/ui/app/utils/common-utils.js 8cc40d6 
>   contrib/views/wfmanager/src/main/resources/ui/app/utils/constants.js 9126819 
> 
> Diff: https://reviews.apache.org/r/55834/diff/
> 
> 
> Testing
> -------
> 
> Manual
> 
> 
> Thanks,
> 
> Padma Priya N
> 
>


Re: Review Request 55834: AMBARI-19669:Not able to add the settings for action nodes in firefox browser

Posted by Pallav Kulshreshtha <pa...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/55834/#review162625
-----------------------------------------------------------


Ship it!




Ship It!

- Pallav Kulshreshtha


On Jan. 23, 2017, 9:53 a.m., Padma Priya N wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/55834/
> -----------------------------------------------------------
> 
> (Updated Jan. 23, 2017, 9:53 a.m.)
> 
> 
> Review request for Ambari, belliraj hb, Gaurav Nagar, Nitiraj Rathore, and Pallav Kulshreshtha.
> 
> 
> Bugs: AMBARI-19669
>     https://issues.apache.org/jira/browse/AMBARI-19669
> 
> 
> Repository: ambari
> 
> 
> Description
> -------
> 
> Mofified the actions structure to an array. Removed the usage of Object.values method which causes the issue.
> 
> 
> Diffs
> -----
> 
>   contrib/views/wfmanager/src/main/resources/ui/app/components/version-settings.js 966313f 
>   contrib/views/wfmanager/src/main/resources/ui/app/domain/workflow.js 3c89f5c 
>   contrib/views/wfmanager/src/main/resources/ui/app/utils/common-utils.js 8cc40d6 
>   contrib/views/wfmanager/src/main/resources/ui/app/utils/constants.js 9126819 
> 
> Diff: https://reviews.apache.org/r/55834/diff/
> 
> 
> Testing
> -------
> 
> Manual
> 
> 
> Thanks,
> 
> Padma Priya N
> 
>