You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@apisix.apache.org by "shreemaan-abhishek (via GitHub)" <gi...@apache.org> on 2023/03/02 08:46:05 UTC
[GitHub] [apisix] shreemaan-abhishek opened a new issue, #8992: feat: As a user, I want apisix to warn me if I have multiple URIs that would match for the same route
shreemaan-abhishek opened a new issue, #8992:
URL: https://github.com/apache/apisix/issues/8992
### Description
Example:
Route one:
```bash
curl -XPUT 127.0.0.1:9180/apisix/admin/routes/1 -H "X-API-KEY: edd1c9f034335f136f87ad84b625c8f1" -d '{
"uri":"/anything/*",
"plugins": {
.....
},
"upstream":{
"type":"roundrobin",
"nodes":{
"httpbin.org:80":1
}
}
}'
```
route two:
```bash
curl -XPUT 127.0.0.1:9180/apisix/admin/routes/2 -H "X-API-KEY: edd1c9f034335f136f87ad84b625c8f1" -d '{
"uri":"/anything/*",
"plugins": {
.....
},
"upstream":{
"type":"roundrobin",
"nodes":{
"abc.org:80":1
}
}
}'
```
In this case, APISIX would randomly match any route when I visit `127.0.0.1:9080/anything/test`.
I understand that this is the user's fault but if users receive a warning when they try to create a route that has a conflicting URI it would lead to a better UX.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix] Neilblaze commented on issue #8992: feat: As a user, I want apisix to warn me if I have multiple URIs that would match for the same route
Posted by "Neilblaze (via GitHub)" <gi...@apache.org>.
Neilblaze commented on issue #8992:
URL: https://github.com/apache/apisix/issues/8992#issuecomment-1451594393
I can take a shot. I'll dm you for a bit of assistance.
cc: @navendu-pottekkat
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix] Neilblaze commented on issue #8992: feat: As a user, I want apisix to warn me if I have multiple URIs that would match for the same route
Posted by "Neilblaze (via GitHub)" <gi...@apache.org>.
Neilblaze commented on issue #8992:
URL: https://github.com/apache/apisix/issues/8992#issuecomment-1451607550
Sure, I'll take a try!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix] Neilblaze commented on issue #8992: feat: As a user, I want apisix to warn me if I have multiple URIs that would match for the same route
Posted by "Neilblaze (via GitHub)" <gi...@apache.org>.
Neilblaze commented on issue #8992:
URL: https://github.com/apache/apisix/issues/8992#issuecomment-1451604960
@shreemaan-abhishek Sounds good to me! 😄
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix] shreemaan-abhishek commented on issue #8992: feat: As a user, I want apisix to warn me if I have multiple URIs that would match for the same route
Posted by "shreemaan-abhishek (via GitHub)" <gi...@apache.org>.
shreemaan-abhishek commented on issue #8992:
URL: https://github.com/apache/apisix/issues/8992#issuecomment-1451603624
@Neilblaze, I'd recommend waiting until the community thinks that this would be a good feature to have.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix] shreemaan-abhishek commented on issue #8992: feat: As a user, I want apisix to warn me if I have multiple URIs that would match for the same route
Posted by "shreemaan-abhishek (via GitHub)" <gi...@apache.org>.
shreemaan-abhishek commented on issue #8992:
URL: https://github.com/apache/apisix/issues/8992#issuecomment-1451605787
You can still go ahead and try to implement it but in the worst case your work might be rejected but in the process you will learn a lot.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix] Fabriceli commented on issue #8992: feat: As a user, I want apisix to warn me if I have multiple URIs that would match for the same route
Posted by "Fabriceli (via GitHub)" <gi...@apache.org>.
Fabriceli commented on issue #8992:
URL: https://github.com/apache/apisix/issues/8992#issuecomment-1452037767
If the Route one and Route two have a different Host, they will be different route. However that is a good feature for the user
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org