You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@shindig.apache.org by "Jakub Vrána (JIRA)" <ji...@apache.org> on 2009/02/26 16:37:03 UTC
[jira] Created: (SHINDIG-952) Wrong phpDoc comments
Wrong phpDoc comments
---------------------
Key: SHINDIG-952
URL: https://issues.apache.org/jira/browse/SHINDIG-952
Project: Shindig
Issue Type: Bug
Components: PHP
Affects Versions: trunk
Reporter: Jakub Vrána
Priority: Minor
Fix For: trunk
There are wrong phpDoc comments in php/src/social/spi/*Service.php. For example AppDataService::updatePersonData describes key and value but there are $fields and $values instead. Some parameters and some methods are not documented at all. All *Service.php need some care.
Moreover, type hints are missing in several places. E.g. AppDataService::updatePersonData $userId has hint UserId, but AppDataService::deletePersonData $userId hasn't. array hints are missing from all array parameters.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (SHINDIG-952) Wrong phpDoc comments
Posted by "Chris Chabot (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/SHINDIG-952?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12680151#action_12680151 ]
Chris Chabot commented on SHINDIG-952:
--------------------------------------
Jakub, I don't suppose you could submit a patch to fix these up?
> Wrong phpDoc comments
> ---------------------
>
> Key: SHINDIG-952
> URL: https://issues.apache.org/jira/browse/SHINDIG-952
> Project: Shindig
> Issue Type: Bug
> Components: PHP
> Affects Versions: trunk
> Reporter: Jakub Vrána
> Priority: Minor
> Fix For: trunk
>
> Original Estimate: 1h
> Remaining Estimate: 1h
>
> There are wrong phpDoc comments in php/src/social/spi/*Service.php. For example AppDataService::updatePersonData describes key and value but there are $fields and $values instead. Some parameters and some methods are not documented at all. All *Service.php need some care.
> Moreover, type hints are missing in several places. E.g. AppDataService::updatePersonData $userId has hint UserId, but AppDataService::deletePersonData $userId hasn't. array hints are missing from all array parameters.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (SHINDIG-952) Wrong phpDoc comments
Posted by "Jakub Vrána (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/SHINDIG-952?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12677374#action_12677374 ]
Jakub Vrána commented on SHINDIG-952:
-------------------------------------
ActivityService::getActivity() uses $appdId instead of $appId (typo).
> Wrong phpDoc comments
> ---------------------
>
> Key: SHINDIG-952
> URL: https://issues.apache.org/jira/browse/SHINDIG-952
> Project: Shindig
> Issue Type: Bug
> Components: PHP
> Affects Versions: trunk
> Reporter: Jakub Vrána
> Priority: Minor
> Fix For: trunk
>
> Original Estimate: 1h
> Remaining Estimate: 1h
>
> There are wrong phpDoc comments in php/src/social/spi/*Service.php. For example AppDataService::updatePersonData describes key and value but there are $fields and $values instead. Some parameters and some methods are not documented at all. All *Service.php need some care.
> Moreover, type hints are missing in several places. E.g. AppDataService::updatePersonData $userId has hint UserId, but AppDataService::deletePersonData $userId hasn't. array hints are missing from all array parameters.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.