You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@datasketches.apache.org by "jmalkin (via GitHub)" <gi...@apache.org> on 2024/04/08 23:02:59 UTC
[PR] make a couple methods static (datasketches-java)
jmalkin opened a new pull request, #543:
URL: https://github.com/apache/datasketches-java/pull/543
(no comment)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@datasketches.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@datasketches.apache.org
For additional commands, e-mail: commits-help@datasketches.apache.org
Re: [PR] make a couple methods static (datasketches-java)
Posted by "jmalkin (via GitHub)" <gi...@apache.org>.
jmalkin merged PR #543:
URL: https://github.com/apache/datasketches-java/pull/543
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@datasketches.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@datasketches.apache.org
For additional commands, e-mail: commits-help@datasketches.apache.org
Re: [PR] make a couple methods static (datasketches-java)
Posted by "jmalkin (via GitHub)" <gi...@apache.org>.
jmalkin commented on code in PR #543:
URL: https://github.com/apache/datasketches-java/pull/543#discussion_r1556587299
##########
src/test/java/org/apache/datasketches/filters/bloomfilter/DirectBitArrayRTest.java:
##########
@@ -32,7 +32,7 @@
public class DirectBitArrayRTest {
- private Memory bitArrayToMemory(HeapBitArray ba) {
+ static private Memory bitArrayToMemory(HeapBitArray ba) {
Review Comment:
fixed
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@datasketches.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@datasketches.apache.org
For additional commands, e-mail: commits-help@datasketches.apache.org
Re: [PR] make a couple methods static (datasketches-java)
Posted by "leerho (via GitHub)" <gi...@apache.org>.
leerho commented on code in PR #543:
URL: https://github.com/apache/datasketches-java/pull/543#discussion_r1556534748
##########
src/test/java/org/apache/datasketches/filters/bloomfilter/DirectBitArrayRTest.java:
##########
@@ -32,7 +32,7 @@
public class DirectBitArrayRTest {
- private Memory bitArrayToMemory(HeapBitArray ba) {
+ static private Memory bitArrayToMemory(HeapBitArray ba) {
Review Comment:
Recommended practice is "private static"
##########
src/test/java/org/apache/datasketches/filters/bloomfilter/DirectBitArrayTest.java:
##########
@@ -30,7 +30,7 @@
public class DirectBitArrayTest {
- private WritableMemory bitArrayToWritableMemory(HeapBitArray ba) {
+ static private WritableMemory bitArrayToWritableMemory(HeapBitArray ba) {
Review Comment:
Recommended practice is "private static"
##########
src/test/java/org/apache/datasketches/filters/bloomfilter/DirectBitArrayRTest.java:
##########
@@ -32,7 +32,7 @@
public class DirectBitArrayRTest {
- private Memory bitArrayToMemory(HeapBitArray ba) {
+ static private Memory bitArrayToMemory(HeapBitArray ba) {
Review Comment:
See [Java language spec 8.4.3](https://docs.oracle.com/javase/specs/jls/se7/html/jls-8.html#jls-8.4.3)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@datasketches.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@datasketches.apache.org
For additional commands, e-mail: commits-help@datasketches.apache.org