[GitHub] [spark] amaliujia commented on a diff in pull request #41123: [SPARK-43428][FOLLOW-UP] Utils and JSON Utils refactoring

["amaliujia (via GitHub)" <gi...@apache.org>]

amaliujia commented on code in PR #41123:
URL: https://github.com/apache/spark/pull/41123#discussion_r1190436250


##########
common/utils/src/main/scala/org/apache/spark/util/JsonUtils.scala:
##########
@@ -25,9 +25,9 @@ import com.fasterxml.jackson.databind.{DeserializationFeature, ObjectMapper}
 import com.fasterxml.jackson.module.scala.DefaultScalaModule
 
 
-private[spark] object JsonUtils {
+private[spark] trait JsonUtils {
 
-  private val mapper = new ObjectMapper().registerModule(DefaultScalaModule)
+  protected val mapper = new ObjectMapper().registerModule(DefaultScalaModule)

Review Comment:
   @LuciferYang which type annotation you are referring to? Can you share an example?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org