You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@mesos.apache.org by Anand Mazumdar <ma...@gmail.com> on 2016/02/03 03:32:28 UTC
Review Request 43131: Modified existing usage of Slave constructors.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43131/
-----------------------------------------------------------
Review request for mesos and Vinod Kone.
Bugs: MESOS-4255
https://issues.apache.org/jira/browse/MESOS-4255
Repository: mesos
Description
-------
This change adds the argument process ID wherever the `Slave` object is constructed.
Diffs
-----
src/local/local.cpp 582d4a10444831b0753d20650698e5d3b51cca9f
src/slave/main.cpp a412cebcaf533feaff54e8ed398ae7007263e51f
src/tests/mesos.cpp 18d0d8f8037ebc27c87bcb0f1ce9f143e7505ec8
Diff: https://reviews.apache.org/r/43131/diff/
Testing
-------
make check
Thanks,
Anand Mazumdar
Re: Review Request 43131: Modified existing usage of Slave
constructor.
Posted by Anand Mazumdar <ma...@gmail.com>.
> On Feb. 3, 2016, 7:51 p.m., Vinod Kone wrote:
> > src/slave/main.cpp, line 211
> > <https://reviews.apache.org/r/43131/diff/1/?file=1230405#file1230405line211>
> >
> > this is backwards incompatible. this will need to go through a deprecation cycle with a warning to the dev/user list.
Sounds good. Let me mail dev/user mailing list about it as per our offline discussion.
I was under the impression that no one would be using the `slave(1)` delegate but directly `ip:port` since it's an internal detail but it does not seem to be the case. My bad.
- Anand
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43131/#review117660
-----------------------------------------------------------
On Feb. 3, 2016, 7:56 p.m., Anand Mazumdar wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/43131/
> -----------------------------------------------------------
>
> (Updated Feb. 3, 2016, 7:56 p.m.)
>
>
> Review request for mesos and Vinod Kone.
>
>
> Bugs: MESOS-4255
> https://issues.apache.org/jira/browse/MESOS-4255
>
>
> Repository: mesos
>
>
> Description
> -------
>
> This change adds the argument process ID wherever the `Slave` object is constructed.
>
>
> Diffs
> -----
>
> src/local/local.cpp 582d4a10444831b0753d20650698e5d3b51cca9f
> src/slave/main.cpp a412cebcaf533feaff54e8ed398ae7007263e51f
> src/tests/mesos.cpp 18d0d8f8037ebc27c87bcb0f1ce9f143e7505ec8
>
> Diff: https://reviews.apache.org/r/43131/diff/
>
>
> Testing
> -------
>
> make check
>
>
> Thanks,
>
> Anand Mazumdar
>
>
Re: Review Request 43131: Modified existing usage of Slave
constructor.
Posted by Vinod Kone <vi...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43131/#review117660
-----------------------------------------------------------
src/slave/main.cpp (line 211)
<https://reviews.apache.org/r/43131/#comment178927>
this is backwards incompatible. this will need to go through a deprecation cycle with a warning to the dev/user list.
- Vinod Kone
On Feb. 3, 2016, 2:34 a.m., Anand Mazumdar wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/43131/
> -----------------------------------------------------------
>
> (Updated Feb. 3, 2016, 2:34 a.m.)
>
>
> Review request for mesos and Vinod Kone.
>
>
> Bugs: MESOS-4255
> https://issues.apache.org/jira/browse/MESOS-4255
>
>
> Repository: mesos
>
>
> Description
> -------
>
> This change adds the argument process ID wherever the `Slave` object is constructed.
>
>
> Diffs
> -----
>
> src/local/local.cpp 582d4a10444831b0753d20650698e5d3b51cca9f
> src/slave/main.cpp a412cebcaf533feaff54e8ed398ae7007263e51f
> src/tests/mesos.cpp 18d0d8f8037ebc27c87bcb0f1ce9f143e7505ec8
>
> Diff: https://reviews.apache.org/r/43131/diff/
>
>
> Testing
> -------
>
> make check
>
>
> Thanks,
>
> Anand Mazumdar
>
>
Re: Review Request 43131: Modified existing usage of Slave
constructor.
Posted by Vinod Kone <vi...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43131/#review117678
-----------------------------------------------------------
src/slave/main.cpp (line 211)
<https://reviews.apache.org/r/43131/#comment178954>
lets use Procses::generate() as before?
- Vinod Kone
On Feb. 3, 2016, 7:56 p.m., Anand Mazumdar wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/43131/
> -----------------------------------------------------------
>
> (Updated Feb. 3, 2016, 7:56 p.m.)
>
>
> Review request for mesos and Vinod Kone.
>
>
> Bugs: MESOS-4255
> https://issues.apache.org/jira/browse/MESOS-4255
>
>
> Repository: mesos
>
>
> Description
> -------
>
> This change adds the argument process ID wherever the `Slave` object is constructed.
>
>
> Diffs
> -----
>
> src/local/local.cpp 582d4a10444831b0753d20650698e5d3b51cca9f
> src/slave/main.cpp a412cebcaf533feaff54e8ed398ae7007263e51f
> src/tests/mesos.cpp 18d0d8f8037ebc27c87bcb0f1ce9f143e7505ec8
>
> Diff: https://reviews.apache.org/r/43131/diff/
>
>
> Testing
> -------
>
> make check
>
>
> Thanks,
>
> Anand Mazumdar
>
>
Re: Review Request 43131: Modified existing usage of Slave
constructor.
Posted by Vinod Kone <vi...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43131/#review117870
-----------------------------------------------------------
Ship it!
Ship It!
- Vinod Kone
On Feb. 3, 2016, 10:40 p.m., Anand Mazumdar wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/43131/
> -----------------------------------------------------------
>
> (Updated Feb. 3, 2016, 10:40 p.m.)
>
>
> Review request for mesos and Vinod Kone.
>
>
> Bugs: MESOS-4255
> https://issues.apache.org/jira/browse/MESOS-4255
>
>
> Repository: mesos
>
>
> Description
> -------
>
> This change adds the argument process ID wherever the `Slave` object is constructed.
>
>
> Diffs
> -----
>
> src/local/local.cpp 582d4a10444831b0753d20650698e5d3b51cca9f
> src/slave/main.cpp a412cebcaf533feaff54e8ed398ae7007263e51f
> src/tests/mesos.cpp 18d0d8f8037ebc27c87bcb0f1ce9f143e7505ec8
>
> Diff: https://reviews.apache.org/r/43131/diff/
>
>
> Testing
> -------
>
> make check
>
>
> Thanks,
>
> Anand Mazumdar
>
>
Re: Review Request 43131: Modified existing usage of Slave
constructor.
Posted by Anand Mazumdar <ma...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43131/
-----------------------------------------------------------
(Updated Feb. 3, 2016, 10:40 p.m.)
Review request for mesos and Vinod Kone.
Changes
-------
Made local cluster use generated process ID's and not static ones.
Bugs: MESOS-4255
https://issues.apache.org/jira/browse/MESOS-4255
Repository: mesos
Description
-------
This change adds the argument process ID wherever the `Slave` object is constructed.
Diffs (updated)
-----
src/local/local.cpp 582d4a10444831b0753d20650698e5d3b51cca9f
src/slave/main.cpp a412cebcaf533feaff54e8ed398ae7007263e51f
src/tests/mesos.cpp 18d0d8f8037ebc27c87bcb0f1ce9f143e7505ec8
Diff: https://reviews.apache.org/r/43131/diff/
Testing
-------
make check
Thanks,
Anand Mazumdar
Re: Review Request 43131: Modified existing usage of Slave
constructor.
Posted by Anand Mazumdar <ma...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43131/
-----------------------------------------------------------
(Updated Feb. 3, 2016, 10:02 p.m.)
Review request for mesos and Vinod Kone.
Changes
-------
Explicitly invoke `process::ID::generate` instead of hardcoding the constant.
Bugs: MESOS-4255
https://issues.apache.org/jira/browse/MESOS-4255
Repository: mesos
Description
-------
This change adds the argument process ID wherever the `Slave` object is constructed.
Diffs (updated)
-----
src/local/local.cpp 582d4a10444831b0753d20650698e5d3b51cca9f
src/slave/main.cpp a412cebcaf533feaff54e8ed398ae7007263e51f
src/tests/mesos.cpp 18d0d8f8037ebc27c87bcb0f1ce9f143e7505ec8
Diff: https://reviews.apache.org/r/43131/diff/
Testing
-------
make check
Thanks,
Anand Mazumdar
Re: Review Request 43131: Modified existing usage of Slave
constructor.
Posted by Anand Mazumdar <ma...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43131/
-----------------------------------------------------------
(Updated Feb. 3, 2016, 7:56 p.m.)
Review request for mesos and Vinod Kone.
Changes
-------
Review comment
Bugs: MESOS-4255
https://issues.apache.org/jira/browse/MESOS-4255
Repository: mesos
Description
-------
This change adds the argument process ID wherever the `Slave` object is constructed.
Diffs (updated)
-----
src/local/local.cpp 582d4a10444831b0753d20650698e5d3b51cca9f
src/slave/main.cpp a412cebcaf533feaff54e8ed398ae7007263e51f
src/tests/mesos.cpp 18d0d8f8037ebc27c87bcb0f1ce9f143e7505ec8
Diff: https://reviews.apache.org/r/43131/diff/
Testing
-------
make check
Thanks,
Anand Mazumdar
Re: Review Request 43131: Modified existing usage of Slave
constructor.
Posted by Anand Mazumdar <ma...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43131/
-----------------------------------------------------------
(Updated Feb. 3, 2016, 2:34 a.m.)
Review request for mesos and Vinod Kone.
Changes
-------
Modified description
Summary (updated)
-----------------
Modified existing usage of Slave constructor.
Bugs: MESOS-4255
https://issues.apache.org/jira/browse/MESOS-4255
Repository: mesos
Description
-------
This change adds the argument process ID wherever the `Slave` object is constructed.
Diffs
-----
src/local/local.cpp 582d4a10444831b0753d20650698e5d3b51cca9f
src/slave/main.cpp a412cebcaf533feaff54e8ed398ae7007263e51f
src/tests/mesos.cpp 18d0d8f8037ebc27c87bcb0f1ce9f143e7505ec8
Diff: https://reviews.apache.org/r/43131/diff/
Testing
-------
make check
Thanks,
Anand Mazumdar