[GitHub] [spark] dchvn commented on a change in pull request #34363: [SPARK-37083][PYTHON] Inline type hints for python/pyspark/accumulators.py

[GitBox <gi...@apache.org>]

dchvn commented on a change in pull request #34363:
URL: https://github.com/apache/spark/pull/34363#discussion_r734920585



##########
File path: python/pyspark/accumulators.py
##########
@@ -20,20 +20,32 @@
 import struct
 import socketserver as SocketServer
 import threading
+from typing import TypeVar, Generic, Tuple, Callable, Type, Dict, Union, TYPE_CHECKING
+
 from pyspark.serializers import read_int, PickleSerializer
 
+if TYPE_CHECKING:
+    from pyspark._typing import SupportsIAdd
+    import socketserver.BaseRequestHandler  # type: ignore

Review comment:
       I took it from stub file and do not know how to remove it.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org