[GitHub] asfgit closed pull request #311: ACCUMULO-4703 Fix warnings for newer JCommander

[GitBox <gi...@apache.org>]

asfgit closed pull request #311: ACCUMULO-4703 Fix warnings for newer JCommander
URL: https://github.com/apache/accumulo/pull/311
 
 
   

This is a PR merged from a forked repository.
As GitHub hides the original diff on merge, it is displayed below for
the sake of provenance:

As this is a foreign pull request (from a fork), the diff is supplied
below (as it won't show otherwise due to GitHub magic):

diff --git a/shell/src/test/java/org/apache/accumulo/shell/PasswordConverterTest.java b/shell/src/test/java/org/apache/accumulo/shell/PasswordConverterTest.java
index 75d72939d4..1db0f02b26 100644
--- a/shell/src/test/java/org/apache/accumulo/shell/PasswordConverterTest.java
+++ b/shell/src/test/java/org/apache/accumulo/shell/PasswordConverterTest.java
@@ -76,7 +76,7 @@ public void teardown() {
   public void testPass() {
     String expected = String.valueOf(Math.random());
     argv[1] = "pass:" + expected;
-    new JCommander(password, argv);
+    new JCommander(password).parse(argv);
     assertEquals(expected, password.password);
   }
 
@@ -84,7 +84,7 @@ public void testPass() {
   public void testEnv() {
     String name = System.getenv().keySet().iterator().next();
     argv[1] = "env:" + name;
-    new JCommander(password, argv);
+    new JCommander(password).parse(argv);
     assertEquals(System.getenv(name), password.password);
   }
 
@@ -94,20 +94,20 @@ public void testFile() throws FileNotFoundException {
     Scanner scan = new Scanner(new File("pom.xml"));
     String expected = scan.nextLine();
     scan.close();
-    new JCommander(password, argv);
+    new JCommander(password).parse(argv);
     assertEquals(expected, password.password);
   }
 
   @Test(expected = ParameterException.class)
   public void testNoFile() throws FileNotFoundException {
     argv[1] = "file:doesnotexist";
-    new JCommander(password, argv);
+    new JCommander(password).parse(argv);
   }
 
   @Test
   public void testStdin() {
     argv[1] = "stdin";
-    new JCommander(password, argv);
+    new JCommander(password).parse(argv);
     assertEquals("stdin", password.password);
   }
 }


 

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services