You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@hudi.apache.org by GitBox <gi...@apache.org> on 2020/02/04 16:46:51 UTC
[GitHub] [incubator-hudi] lamber-ken opened a new pull request #1305:
[MINOR] Remove the declaration of thrown RuntimeException
lamber-ken opened a new pull request #1305: [MINOR] Remove the declaration of thrown RuntimeException
URL: https://github.com/apache/incubator-hudi/pull/1305
## What is the purpose of the pull request
From jdk doc, we know RuntimeExceptions do not need to be declared in method.
https://docs.oracle.com/javase/8/docs/api/java/lang/RuntimeException.html
## Brief change log
- *Remove the declaration of thrown RuntimeException*
## Verify this pull request
This pull request is code cleanup without any test coverage.
## Committer checklist
- [X] Has a corresponding JIRA in PR title & commit
- [X] Commit message is descriptive of the change
- [ ] CI is green
- [ ] Necessary doc changes done or have another open PR
- [ ] For large changes, please consider breaking it into sub-tasks under an umbrella JIRA.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-hudi] yanghua commented on issue #1305: [MINOR] Remove
the declaration of thrown RuntimeException
Posted by GitBox <gi...@apache.org>.
yanghua commented on issue #1305: [MINOR] Remove the declaration of thrown RuntimeException
URL: https://github.com/apache/incubator-hudi/pull/1305#issuecomment-582695979
> cc @yanghua I actually thought of assigning this to you..to get your take on whether this qualifies as MINOR.. I think it does
@vinothchandar +1 it does
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-hudi] vinothchandar commented on issue #1305: [MINOR]
Remove the declaration of thrown RuntimeException
Posted by GitBox <gi...@apache.org>.
vinothchandar commented on issue #1305: [MINOR] Remove the declaration of thrown RuntimeException
URL: https://github.com/apache/incubator-hudi/pull/1305#issuecomment-582605003
cc @yanghua I actually thought of assigning this to you..to get your take on whether this qualifies as MINOR.. I think it does
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-hudi] leesf merged pull request #1305: [MINOR] Remove
the declaration of thrown RuntimeException
Posted by GitBox <gi...@apache.org>.
leesf merged pull request #1305: [MINOR] Remove the declaration of thrown RuntimeException
URL: https://github.com/apache/incubator-hudi/pull/1305
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services