You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@mynewt.apache.org by GitBox <gi...@apache.org> on 2022/09/27 12:54:41 UTC
[GitHub] [mynewt-nimble] rahult-github opened a new pull request, #1377: nimble/host: Add HCI Commands/ events for connection subrating
rahult-github opened a new pull request, #1377:
URL: https://github.com/apache/mynewt-nimble/pull/1377
This PR adds support for HCI commands and events in stack for Connection subrating feature.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@mynewt.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [mynewt-nimble] apache-mynewt-bot commented on pull request #1377: nimble/host: Add HCI Commands/ events for connection subrating
Posted by GitBox <gi...@apache.org>.
apache-mynewt-bot commented on PR #1377:
URL: https://github.com/apache/mynewt-nimble/pull/1377#issuecomment-1260487095
<!-- style-bot -->
## Style check summary
### Our coding style is [here!](https://github.com/apache/mynewt-core/blob/master/CODING_STANDARDS.md)
#### nimble/host/src/ble_hs_hci_evt.c
<details>
```diff
@@ -67,8 +67,7 @@
static ble_hs_hci_evt_le_fn ble_hs_hci_evt_le_subrate_change;
/* Statistics */
-struct host_hci_stats
-{
+struct host_hci_stats {
uint32_t events_rxd;
uint32_t good_acks_rxd;
uint32_t bad_acks_rxd;
```
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@mynewt.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [mynewt-nimble] apache-mynewt-bot commented on pull request #1377: nimble/host: Add HCI Commands/ events for connection subrating
Posted by GitBox <gi...@apache.org>.
apache-mynewt-bot commented on PR #1377:
URL: https://github.com/apache/mynewt-nimble/pull/1377#issuecomment-1262011641
<!-- style-bot -->
## Style check summary
### Our coding style is [here!](https://github.com/apache/mynewt-core/blob/master/CODING_STANDARDS.md)
#### nimble/host/src/ble_hs_hci_evt.c
<details>
```diff
@@ -67,8 +67,7 @@
static ble_hs_hci_evt_le_fn ble_hs_hci_evt_le_subrate_change;
/* Statistics */
-struct host_hci_stats
-{
+struct host_hci_stats {
uint32_t events_rxd;
uint32_t good_acks_rxd;
uint32_t bad_acks_rxd;
```
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@mynewt.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [mynewt-nimble] rahult-github commented on pull request #1377: nimble/host: Add HCI Commands/ events for connection subrating
Posted by GitBox <gi...@apache.org>.
rahult-github commented on PR #1377:
URL: https://github.com/apache/mynewt-nimble/pull/1377#issuecomment-1259467237
Hi @sjanc , this PR attempts to add host side support for Connection Subrating feature. Can you please take a look ?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@mynewt.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [mynewt-nimble] apache-mynewt-bot commented on pull request #1377: nimble/host: Add HCI Commands/ events for connection subrating
Posted by GitBox <gi...@apache.org>.
apache-mynewt-bot commented on PR #1377:
URL: https://github.com/apache/mynewt-nimble/pull/1377#issuecomment-1263111248
<!-- style-bot -->
## Style check summary
#### No suggestions at this time!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@mynewt.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [mynewt-nimble] apache-mynewt-bot commented on pull request #1377: nimble/host: Add HCI Commands/ events for connection subrating
Posted by GitBox <gi...@apache.org>.
apache-mynewt-bot commented on PR #1377:
URL: https://github.com/apache/mynewt-nimble/pull/1377#issuecomment-1260713299
<!-- style-bot -->
## Style check summary
### Our coding style is [here!](https://github.com/apache/mynewt-core/blob/master/CODING_STANDARDS.md)
#### nimble/host/src/ble_hs_hci_evt.c
<details>
```diff
@@ -67,8 +67,7 @@
static ble_hs_hci_evt_le_fn ble_hs_hci_evt_le_subrate_change;
/* Statistics */
-struct host_hci_stats
-{
+struct host_hci_stats {
uint32_t events_rxd;
uint32_t good_acks_rxd;
uint32_t bad_acks_rxd;
```
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@mynewt.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [mynewt-nimble] apache-mynewt-bot commented on pull request #1377: nimble/host: Add HCI Commands/ events for connection subrating
Posted by GitBox <gi...@apache.org>.
apache-mynewt-bot commented on PR #1377:
URL: https://github.com/apache/mynewt-nimble/pull/1377#issuecomment-1259649501
<!-- style-bot -->
## Style check summary
### Our coding style is [here!](https://github.com/apache/mynewt-core/blob/master/CODING_STANDARDS.md)
#### nimble/host/include/host/ble_gap.h
<details>
```diff
@@ -1044,13 +1044,13 @@
uint16_t conn_handle;
} pairing_complete;
- /**
+ /**
* Represents a subrate change event that indicates connection subrate update procedure
* has completed and some parameters have changed Valid for
* the following event types:
* o BLE_GAP_EVENT_SUBRATE_CHANGE
*/
- struct {
+ struct {
/** BLE_ERR_SUCCESS on success or error code on failure */
uint8_t status;
@@ -1068,7 +1068,7 @@
/** Supervision Timeout */
uint16_t supervision_tmo;
- } subrate_change;
+ } subrate_change;
};
};
@@ -2209,15 +2209,15 @@
* @param supervision_timeout Max supervision timeout allowed in request by a peripheral
*/
int ble_gap_set_default_subrate(uint16_t subrate_min, uint16_t subrate_max, uint16_t max_latency,
- uint16_t cont_num, uint16_t supervision_timeout);
+ uint16_t cont_num, uint16_t supervision_timeout);
/**
* Set Subrate Request
*
- * @param conn_handle Connection Handle of the ACL.
+ * @param conn_handle Connection Handle of the ACL.
* @param subrate_min Min subrate factor allowed in request by a peripheral
* @param subrate_max Max subrate factor allowed in request by a peripheral
- * @param max_latency Max peripheral latency allowed in units of
+ * @param max_latency Max peripheral latency allowed in units of
* subrated conn interval.
*
* @param cont_num Min number of underlying conn event to remain active
```
</details>
#### nimble/host/src/ble_gap.c
<details>
```diff
@@ -4683,7 +4683,7 @@
int
ble_gap_set_default_subrate(uint16_t subrate_min, uint16_t subrate_max, uint16_t max_latency,
- uint16_t cont_num, uint16_t supervision_tmo)
+ uint16_t cont_num, uint16_t supervision_tmo)
{
struct ble_hci_le_set_default_subrate_cp cmd;
uint16_t opcode;
@@ -4701,8 +4701,8 @@
int
ble_gap_set_subrate_req(uint16_t conn_handle, uint16_t subrate_min, uint16_t subrate_max,
- uint16_t max_latency, uint16_t cont_num,
- uint16_t supervision_tmo)
+ uint16_t max_latency, uint16_t cont_num,
+ uint16_t supervision_tmo)
{
struct ble_hci_le_subrate_req_cp cmd;
uint16_t opcode;
```
</details>
#### nimble/host/src/ble_hs_hci_evt.c
<details>
```diff
@@ -67,8 +67,7 @@
static ble_hs_hci_evt_le_fn ble_hs_hci_evt_le_subrate_change;
/* Statistics */
-struct host_hci_stats
-{
+struct host_hci_stats {
uint32_t events_rxd;
uint32_t good_acks_rxd;
uint32_t bad_acks_rxd;
@@ -754,7 +753,7 @@
static int
ble_hs_hci_evt_le_subrate_change(uint8_t subevent, const void *data,
- unsigned int len)
+ unsigned int len)
{
const struct ble_hci_ev_le_subev_subrate_change *ev = data;
```
</details>
#### nimble/host/src/ble_hs_startup.c
<details>
```diff
@@ -242,9 +242,9 @@
if (version >= BLE_HCI_VER_BCS_5_3) {
/**
- * Enable the following LE events:
- * 0x0000000400000000 LE Subrate change event
- */
+ * Enable the following LE events:
+ * 0x0000000400000000 LE Subrate change event
+ */
mask |= 0x0000000400000000;
}
```
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@mynewt.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org