[GitHub] [apisix] spacewander commented on a change in pull request #5319: test: grpc stream proxy test with test nginx

[GitBox <gi...@apache.org>]

spacewander commented on a change in pull request #5319:
URL: https://github.com/apache/apisix/pull/5319#discussion_r736065920



##########
File path: ci/linux_openresty_common_runner.sh
##########
@@ -107,8 +104,8 @@ apisix:
     sleep 1
     cat logs/error.log
 
-    ./t/grpc-proxy-test.sh
-    sleep 1
+    # ./t/grpc-proxy-test.sh
+    # sleep 1
 
     ./bin/apisix stop
     sleep 1

Review comment:
       OK. Remember to put this back:
   ```
   # ensure grpc server example is already started
   for (( i = 0; i <= 100; i++ )); do
       if [[ "$i" -eq 100 ]]; then
           echo "failed to start grpc_server_example in time"
           exit 1
       fi
       nc -zv 127.0.0.1 50051 && break
       sleep 1
   done
   ```

##########
File path: ci/centos7-ci.sh
##########
@@ -44,18 +44,25 @@ install_dependencies() {
     yum install -y cpanminus perl
     cpanm --notest Test::Nginx IPC::Run > build.log 2>&1 || (cat build.log && exit 1)
 
-    # install and start grpc_server_example
+    # add go1.15 binary to the path
     mkdir build-cache
-    wget https://github.com/api7/grpc_server_example/releases/download/"$GRPC_SERVER_EXAMPLE_VER"/grpc_server_example-amd64.tar.gz
-    tar -xvf grpc_server_example-amd64.tar.gz
-    mv grpc_server_example build-cache/
-    git clone https://github.com/iresty/grpc_server_example.git grpc_server_example
-    cd grpc_server_example/ && mv proto/ ../build-cache/ && cd ..
-    ./build-cache/grpc_server_example \
+    cd build-cache/ && wget https://golang.org/dl/go1.15.linux-amd64.tar.gz && tar -xf go1.15.linux-amd64.tar.gz
+    export PATH=$PATH:$(pwd)/go/bin
+    cd ..
+    # install and start grpc_server_example
+    cd t/grpc_server_example
+
+    if [ ! "$(ls -A . )" ]; then

Review comment:
       Better to add a comment about why this branch is needed

##########
File path: ci/centos7-ci.sh
##########
@@ -44,18 +44,25 @@ install_dependencies() {
     yum install -y cpanminus perl
     cpanm --notest Test::Nginx IPC::Run > build.log 2>&1 || (cat build.log && exit 1)
 
-    # install and start grpc_server_example
+    # add go1.15 binary to the path
     mkdir build-cache
-    wget https://github.com/api7/grpc_server_example/releases/download/"$GRPC_SERVER_EXAMPLE_VER"/grpc_server_example-amd64.tar.gz
-    tar -xvf grpc_server_example-amd64.tar.gz
-    mv grpc_server_example build-cache/
-    git clone https://github.com/iresty/grpc_server_example.git grpc_server_example
-    cd grpc_server_example/ && mv proto/ ../build-cache/ && cd ..
-    ./build-cache/grpc_server_example \
+    cd build-cache/ && wget https://golang.org/dl/go1.15.linux-amd64.tar.gz && tar -xf go1.15.linux-amd64.tar.gz

Review comment:
       Better to put a comment here to show why we need to download Go manually.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org