You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@tvm.apache.org by GitBox <gi...@apache.org> on 2022/09/16 12:05:43 UTC
[GitHub] [tvm] cyx-6 opened a new pull request, #12815: [TVMScript] IRBuilder methods for `Block`
cyx-6 opened a new pull request, #12815:
URL: https://github.com/apache/tvm/pull/12815
This PR introduces remaining IRBuilder methods for `Block`.
Co-authored-by: yongwww <yo...@gmail.com>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@tvm.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [tvm] cyx-6 commented on a diff in pull request #12815: [TVMScript] IRBuilder methods for `Block`
Posted by GitBox <gi...@apache.org>.
cyx-6 commented on code in PR #12815:
URL: https://github.com/apache/tvm/pull/12815#discussion_r973315524
##########
python/tvm/script/ir_builder/tir/frame.py:
##########
@@ -38,6 +38,11 @@ class BlockFrame(TIRFrame):
...
Review Comment:
added
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@tvm.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [tvm] junrushao commented on pull request #12815: [TVMScript] IRBuilder methods for `Block`
Posted by GitBox <gi...@apache.org>.
junrushao commented on PR #12815:
URL: https://github.com/apache/tvm/pull/12815#issuecomment-1249759283
to fix mypy complaints, you may use:
```python
def __enter__(self) -> "IRBuilderFrame":
- _ffi_api.IRBuilderFrameEnter(self) # pylint: disable=no-member # type: ignore
+ _ffi_api.IRBuilderFrameEnter(self) # type: ignore # pylint: disable=no-member
return self
def __exit__(self, ptype, value, trace) -> None: # pylint: disable=unused-argument
- _ffi_api.IRBuilderFrameExit(self) # pylint: disable=no-member # type: ignore
+ _ffi_api.IRBuilderFrameExit(self) # type: ignore # pylint: disable=no-member
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@tvm.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [tvm] junrushao commented on a diff in pull request #12815: [TVMScript] IRBuilder methods for `Block`
Posted by GitBox <gi...@apache.org>.
junrushao commented on code in PR #12815:
URL: https://github.com/apache/tvm/pull/12815#discussion_r973018801
##########
python/tvm/script/ir_builder/tir/frame.py:
##########
@@ -38,6 +38,11 @@ class BlockFrame(TIRFrame):
...
Review Comment:
please add mypy checks for our IRBuilder package:
In file `tests/scripts/task_mypy.sh`, let's add:
```python
echo "Checking MyPy Type defs in the tvmscript IRBuilder package."
mypy --check-untyped-defs python/tvm/script/ir_builder
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@tvm.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [tvm] junrushao merged pull request #12815: [TVMScript] IRBuilder methods for `Block`
Posted by GitBox <gi...@apache.org>.
junrushao merged PR #12815:
URL: https://github.com/apache/tvm/pull/12815
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@tvm.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org