You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@dolphinscheduler.apache.org by GitBox <gi...@apache.org> on 2019/12/12 06:31:23 UTC

[GitHub] [incubator-dolphinscheduler] Technoboy- commented on issue #1444: move alert module into server package

Technoboy- commented on issue #1444: move alert module into server package
URL: https://github.com/apache/incubator-dolphinscheduler/pull/1444#issuecomment-564870127
 
 
   > I agree to remove the alert module
   > 
   > But
   > 
   > Email, SMS and other alarms can be tools directly, put in common module, define the communication interface between them, and call directly
   > 
   > I personally think that if you want to modify this, one PR will be done, and multiple PRs will be more complicated.
   
   Sure, Mr. Qiao

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services