[GitHub] imay commented on a change in pull request #283: Fix truncation error in CastExpr

[GitBox <gi...@apache.org>]

imay commented on a change in pull request #283: Fix truncation error in CastExpr
URL: https://github.com/apache/incubator-doris/pull/283#discussion_r230782696
 
 

 ##########
 File path: fe/src/main/java/org/apache/doris/analysis/CastExpr.java
 ##########
 @@ -219,7 +195,9 @@ private void analyze() throws AnalysisException {
 
     @Override
     public void analyzeImpl(Analyzer analyzer) throws AnalysisException {
-        type = targetType;
+        Preconditions.checkState(!isImplicit);
+        targetTypeDef.analyze(analyzer);
 
 Review comment:
   targetTypeDef will null if this is implicit cast? And this will throw a NullPointerException

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@doris.apache.org
For additional commands, e-mail: dev-help@doris.apache.org