[GitHub] [superset] suddjian commented on a change in pull request #15399: feat(explore): Viz picker search improvements

[GitBox <gi...@apache.org>]

suddjian commented on a change in pull request #15399:
URL: https://github.com/apache/superset/pull/15399#discussion_r660002237



##########
File path: superset-frontend/src/explore/components/controls/VizTypeControl/index.tsx
##########
@@ -146,86 +146,98 @@ const UnpaddedModal = styled(Modal)`
 
 const VizPickerLayout = styled.div`
   display: grid;
-  grid-template-rows: auto 1fr 30%;
+  grid-template-rows: 1fr 35%;
+  grid-template-columns: 1fr 5fr;
+  grid-template-areas:
+    'sidebar main'
+    'details details';
   height: 70vh;
 `;
 
 const SectionTitle = styled.h3`
   margin-top: 0;
+  margin-bottom: ${({ theme }) => theme.gridUnit * 2}px;
   font-size: ${({ theme }) => theme.gridUnit * 4}px;

Review comment:
       Good catch. Using `l` instead though.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org