You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@calcite.apache.org by Francis Chuang <fr...@apache.org> on 2020/01/07 20:36:50 UTC
Re: [DISCUSS] Avatica 1.16.0 dockerfiles broken. Release 1.17.0?
Has there been any progress/solution regarding the LF and CRLF issue?
Francis
On 30/12/2019 2:43 am, Vladimir Sitnikov wrote:
> Stamitis>I was thinking that if the check says that there is no problem
> then apply
> would be a noop.
>
> The current logic of 'apply' is it computes the appropriate style and
> overwrites the file.
>
> Do you suggest it to skip overwriting in case the only diff is line endings?
> What if there are other changes?
> What if the lines have different style?
>
> I would refrain from making such changes to check/apply unless there's a
> justification.
>
> So far I do not care if the source build is broken for Windows, however, I
> do not like how LF vs CRLF issue is ignored.
>
> Vladimir
>
Re: [DISCUSS] Avatica 1.16.0 dockerfiles broken. Release 1.17.0?
Posted by Francis Chuang <fr...@apache.org>.
In terms of the changes for this release, the dockerfiles has been fixed
and I believe you've reordered the steps for finalizing a release using
gradle.
I think the problem is somewhat annoying, but has not been an issue
before. If there is some consensus regarding this, I am happy to make
rc0 available for voting in the next couple of days.
On 8/01/2020 7:58 am, Vladimir Sitnikov wrote:
> AFAIK it is up to the release manager.
>
> Vladimir
>
Re: [DISCUSS] Avatica 1.16.0 dockerfiles broken. Release 1.17.0?
Posted by Vladimir Sitnikov <si...@gmail.com>.
AFAIK it is up to the release manager.
Vladimir