[GitHub] [incubator-yunikorn-core] kingamarton commented on pull request #275: [YUNIKORN-582] Introduced soft/hard gang scheduling styles

[GitBox <gi...@apache.org>]

kingamarton commented on pull request #275:
URL: https://github.com/apache/incubator-yunikorn-core/pull/275#issuecomment-853726527


   > hi @kingamarton pls see my comments. And also I think we need to add some more UT for this to cover different scenarios.
   
   @yangwwei what cases do you mean more exactly?
   In application_test.go we have a couple of test cases for the timeout. (we are already testing the following scenarios:
   - the app is Completing when it times out - the style has no effect on this case
   - the app is in starting state - again the style has no effect on this case
   - the app is in Accepted state - here I split the test case into 2 cases, where the style is Soft, and when the Style is Hard)


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org