You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@avro.apache.org by "Todd Lipcon (JIRA)" <ji...@apache.org> on 2012/11/05 02:36:42 UTC
[jira] [Created] (AVRO-1189) cpp build requires cmake 2.8.4
Todd Lipcon created AVRO-1189:
---------------------------------
Summary: cpp build requires cmake 2.8.4
Key: AVRO-1189
URL: https://issues.apache.org/jira/browse/AVRO-1189
Project: Avro
Issue Type: Bug
Components: build, c++
Affects Versions: 1.7.2
Reporter: Todd Lipcon
The cmake_minimum_required setting for the C++ build is 2.6, but when I try to compile using cmake 2.8.2 I get an error because add_test doesn't understand the WORKING_DIRECTORY property. It turns out this was added in cmake 2.8.4. The CMakeLists.txt should either be updated to use some kind of workaround, or bump the minimum requirement to 2.8.4
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (AVRO-1189) cpp build requires cmake 2.8.4
Posted by "Thiruvalluvan M. G. (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/AVRO-1189?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13490450#comment-13490450 ]
Thiruvalluvan M. G. commented on AVRO-1189:
-------------------------------------------
This patch works well with single configuration systems like Unix Makefile. But with multi configuration systems like Mac and Windows, ctest -c <config> fails (it doesn't generate correct executable name). Ctest is a handy tool to run all tests at once on these platforms. I think it's better that we bump up the requirement to 2.8.4, which is anyway 18 months old. An alternative is to remove working directory requirements in the tests, which requires little bit of work.
> cpp build requires cmake 2.8.4
> ------------------------------
>
> Key: AVRO-1189
> URL: https://issues.apache.org/jira/browse/AVRO-1189
> Project: Avro
> Issue Type: Bug
> Components: build, c++
> Affects Versions: 1.7.2
> Reporter: Todd Lipcon
> Assignee: Todd Lipcon
> Attachments: avro-1189.txt
>
>
> The cmake_minimum_required setting for the C++ build is 2.6, but when I try to compile using cmake 2.8.2 I get an error because add_test doesn't understand the WORKING_DIRECTORY property. It turns out this was added in cmake 2.8.4. The CMakeLists.txt should either be updated to use some kind of workaround, or bump the minimum requirement to 2.8.4
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (AVRO-1189) cpp build requires cmake 2.8.4
Posted by "Todd Lipcon (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/AVRO-1189?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Todd Lipcon updated AVRO-1189:
------------------------------
Attachment: avro-1189.txt
Attached patch uses a workaround I found on the cmake mailing lists. I tested this with cmake 2.8.2 and the tests ran and passed.
> cpp build requires cmake 2.8.4
> ------------------------------
>
> Key: AVRO-1189
> URL: https://issues.apache.org/jira/browse/AVRO-1189
> Project: Avro
> Issue Type: Bug
> Components: build, c++
> Affects Versions: 1.7.2
> Reporter: Todd Lipcon
> Attachments: avro-1189.txt
>
>
> The cmake_minimum_required setting for the C++ build is 2.6, but when I try to compile using cmake 2.8.2 I get an error because add_test doesn't understand the WORKING_DIRECTORY property. It turns out this was added in cmake 2.8.4. The CMakeLists.txt should either be updated to use some kind of workaround, or bump the minimum requirement to 2.8.4
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (AVRO-1189) cpp build requires cmake 2.8.4
Posted by "Todd Lipcon (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/AVRO-1189?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Todd Lipcon updated AVRO-1189:
------------------------------
Assignee: Todd Lipcon
Status: Patch Available (was: Open)
> cpp build requires cmake 2.8.4
> ------------------------------
>
> Key: AVRO-1189
> URL: https://issues.apache.org/jira/browse/AVRO-1189
> Project: Avro
> Issue Type: Bug
> Components: build, c++
> Affects Versions: 1.7.2
> Reporter: Todd Lipcon
> Assignee: Todd Lipcon
> Attachments: avro-1189.txt
>
>
> The cmake_minimum_required setting for the C++ build is 2.6, but when I try to compile using cmake 2.8.2 I get an error because add_test doesn't understand the WORKING_DIRECTORY property. It turns out this was added in cmake 2.8.4. The CMakeLists.txt should either be updated to use some kind of workaround, or bump the minimum requirement to 2.8.4
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira