You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@zookeeper.apache.org by GitBox <gi...@apache.org> on 2020/08/03 17:39:56 UTC
[GitHub] [zookeeper] tanisdlj commented on a change in pull request #1420: Replaced weird comparison of vars
tanisdlj commented on a change in pull request #1420:
URL: https://github.com/apache/zookeeper/pull/1420#discussion_r464563193
##########
File path: bin/zkServer.sh
##########
@@ -37,73 +37,62 @@ fi
# up the JVM to accept JMX remote management:
# http://java.sun.com/javase/6/docs/technotes/guides/management/agent.html
# by default we allow local JMX connections
-if [ "x$JMXLOCALONLY" = "x" ]
-then
- JMXLOCALONLY=false
+if [ -n "$JMXLOCALONLY" ]; then
+ JMXLOCALONLY=false
Review comment:
Yeah, it got me pretty messed up the x=x xDD. You are absolutely right, I'm gonna change it 👍
Thanks!
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org