You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@shardingsphere.apache.org by GitBox <gi...@apache.org> on 2021/11/08 16:48:58 UTC
[GitHub] [shardingsphere] cheese8 opened a new issue #13508: [Discussion] Consider merge QueryAssistedEncryptAlgorithm and EncryptAlgorithm into one
cheese8 opened a new issue #13508:
URL: https://github.com/apache/shardingsphere/issues/13508
## Feature Request
For now:
1、We see that there are two interfaces QueryAssistedEncryptAlgorithm and EncryptAlgorithm, QueryAssistedEncryptAlgorithm inherit from EncryptAlgorithm and provider method queryAssistedEncrypt for QueryAssist.
2、We see 5 fields in EncryptColumnRuleConfiguration but only one encryptorName can be configed with both QueryAssistedEncryptAlgorithm and EncryptAlgorithm, QueryAssistedEncryptAlgorithm was configed usually.
3、We see findEncryptor in EncryptRule.getEncryptValues and EncryptRule.getEncryptAssistedQueryValues, the methods in QueryAssistedEncryptAlgorithm only invoked during encrypt/queryAssistedEncrypt and decrypt, thinking of the above 2.
That's a bad smell, so I consider merge QueryAssistedEncryptAlgorithm and EncryptAlgorithm into one called EncryptAlgorithm with 3 methods: encrypt, queryAssistedEncrypt and decrypt. Would you please suggest on this? @strongduanmu
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [shardingsphere] cheese8 commented on issue #13508: [Discussion] Consider merge QueryAssistedEncryptAlgorithm and EncryptAlgorithm into one
Posted by GitBox <gi...@apache.org>.
cheese8 commented on issue #13508:
URL: https://github.com/apache/shardingsphere/issues/13508#issuecomment-963713226
The first solution is:
merge QueryAssistedEncryptAlgorithm and EncryptAlgorithm into one called EncryptAlgorithm with 3 methods: encrypt, queryAssistedEncrypt and decrypt.
The second solution is:
cut off the inherit relationship on QueryAssistedEncryptAlgorithm and EncryptAlgorithm, and add the 6th field named queryAssistedEncryptorName in EncryptColumnRuleConfiguration.
Which one do you prefer? @strongduanmu
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [shardingsphere] strongduanmu commented on issue #13508: [Discussion] Consider merge QueryAssistedEncryptAlgorithm and EncryptAlgorithm into one
Posted by GitBox <gi...@apache.org>.
strongduanmu commented on issue #13508:
URL: https://github.com/apache/shardingsphere/issues/13508#issuecomment-963718763
@cheese8 Considering that the 5.0.0 GA version has just been released, it is not suitable to make changes to the API at this time, I think this suggestion can be put into the future 6.x version.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [shardingsphere] cheese8 commented on issue #13508: [Discussion] Consider merge QueryAssistedEncryptAlgorithm and EncryptAlgorithm into one
Posted by GitBox <gi...@apache.org>.
cheese8 commented on issue #13508:
URL: https://github.com/apache/shardingsphere/issues/13508#issuecomment-1046986066
Please assign it to me, thanks.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@shardingsphere.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org