[jira] [Commented] (THRIFT-1351) Compiler does not care about binary strings

["Xuri Nagarin (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/THRIFT-1351?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13875246#comment-13875246 ] 

Xuri Nagarin commented on THRIFT-1351:
--------------------------------------

Validating that not fixed as of 0.9.1

> Compiler does not care about binary strings
> -------------------------------------------
>
>                 Key: THRIFT-1351
>                 URL: https://issues.apache.org/jira/browse/THRIFT-1351
>             Project: Thrift
>          Issue Type: Bug
>          Components: Node.js - Compiler
>    Affects Versions: 0.7
>            Reporter: Hans Duedal
>            Assignee: Wade Simmons
>              Labels: compiler, node, nodejs
>             Fix For: 1.0
>
>         Attachments: 0001-read-binary-strings-with-readBinary-v2.patch, 0001-read-binary-strings-with-readBinary.patch
>
>   Original Estimate: 5m
>  Remaining Estimate: 5m
>
> The node.js lib has support for binary strings, but the compiler does not check for it.
> It's quite easily fixed:
> https://github.com/onlinecity/thrift/commit/1d86faa2f44c7b8db80595375d6bd0b9b678c0ee
> With the fix node.js server implementations can operate on binary arguments.



--
This message was sent by Atlassian JIRA
(v6.1.5#6160)