[GitHub] flink issue #2209: [FLINK-4111] [table] Flink Table & SQL doesn't work in ve...

[rmetzger <gi...@git.apache.org>]

Github user rmetzger commented on the issue:

    https://github.com/apache/flink/pull/2209
  
    Are all the dependencies you removed really not needed or are they needed, but present because they are pulled in transitively?
    In general, it makes sense to define all needed dependencies, instead of relying on transitive dependencies.
    
    The problem with the suggested shading is that you are not relocating calcite, which means that we have calcite in the org.apache.calcite namespace, in our flink package.
    This can potentially lead to version clashes if our users want to use a different calcite version in their code (I have to admit that's unlikely.)
    But for `com.fasterxml.jackson` this might be an issue, also for `org.slf4j`.
    
    I would exclude slf4j and jackson from the shading.
    
    Do you know why the relocation of calcite doesn't work? Do you think there is an issue with relocating class files produced by the scala compiler?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---