You are viewing a plain text version of this content. The canonical link for it is here.

Posted to dev@directory.apache.org by Emmanuel Lecharny <el...@gmail.com> on 2011/03/30 02:16:51 UTC

Value doco page written

https://cwiki.apache.org/confluence/display/DIRAPI/Value

For review...

-- 
Regards,
Cordialement,
Emmanuel Lécharny
www.iktek.com

Re: Value doco page written

Posted by Alex Karasulu <ak...@apache.org>.

On Wed, Mar 30, 2011 at 12:13 PM, Pierre-Arnaud Marcelot <pa...@marcelot.net>wrote:

> Hi Emmanuel,
>
> Doco looks fine to me.
>
>
Great doco indeed - thanks Emm!


> I think the naming of two methods could be improved for readability and
> coherence with standard Java and our own coding standards:
> - boolean isHR(); ---> boolean isHumanReadable();
> - boolean instanceOf( AttributeType attributeType ); ---> boolean
> isInstanceOf( AttributeType attributeType );
>
> Very minor concerns...
>
>
Yeah this does improve readability.  +1

Best,
Alex

Re: Value doco page written

Posted by Pierre-Arnaud Marcelot <pa...@marcelot.net>.

Hi Emmanuel,

Doco looks fine to me.

I think the naming of two methods could be improved for readability and coherence with standard Java and our own coding standards:
- boolean isHR(); ---> boolean isHumanReadable();
- boolean instanceOf( AttributeType attributeType ); ---> boolean isInstanceOf( AttributeType attributeType );

Very minor concerns...

Regards,
Pierre-Arnaud


On 30 mars 2011, at 02:16, Emmanuel Lecharny wrote:

> https://cwiki.apache.org/confluence/display/DIRAPI/Value
> 
> For review...
> 
> -- 
> Regards,
> Cordialement,
> Emmanuel Lécharny
> www.iktek.com
>