You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@impala.apache.org by "Daniel Becker (Code Review)" <ge...@cloudera.org> on 2019/08/06 15:46:06 UTC
[Impala-ASF-CR] IMPALA-8796: Add unit tests to UnpackAndDecodeValues
Daniel Becker has uploaded this change for review. ( http://gerrit.cloudera.org:8080/14004
Change subject: IMPALA-8796: Add unit tests to UnpackAndDecodeValues
......................................................................
IMPALA-8796: Add unit tests to UnpackAndDecodeValues
Adding unit tests to test BitPacking::UnpackAndDecodeValues. Also
changing the existing BitPacking tests so that they are parametrised
by the output type of the unpacking so we can test different output
types.
Change-Id: I363ff9f5d4750231fdc1aa60cf40d90ebb9ba305
---
M be/src/util/bit-packing-test.cc
M be/src/util/bit-packing.cc
2 files changed, 190 insertions(+), 25 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/04/14004/2
--
To view, visit http://gerrit.cloudera.org:8080/14004
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: I363ff9f5d4750231fdc1aa60cf40d90ebb9ba305
Gerrit-Change-Number: 14004
Gerrit-PatchSet: 2
Gerrit-Owner: Daniel Becker <da...@cloudera.com>
Gerrit-Reviewer: Csaba Ringhofer <cs...@cloudera.com>
Gerrit-Reviewer: Daniel Becker <da...@cloudera.com>
[Impala-ASF-CR] IMPALA-8796: Add unit tests to UnpackAndDecodeValues
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/14004 )
Change subject: IMPALA-8796: Add unit tests to UnpackAndDecodeValues
......................................................................
Patch Set 6:
Build started: https://jenkins.impala.io/job/gerrit-verify-dryrun/4764/ DRY_RUN=false
--
To view, visit http://gerrit.cloudera.org:8080/14004
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I363ff9f5d4750231fdc1aa60cf40d90ebb9ba305
Gerrit-Change-Number: 14004
Gerrit-PatchSet: 6
Gerrit-Owner: Daniel Becker <da...@cloudera.com>
Gerrit-Reviewer: Csaba Ringhofer <cs...@cloudera.com>
Gerrit-Reviewer: Daniel Becker <da...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Comment-Date: Fri, 09 Aug 2019 12:24:09 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-8796: Add unit tests to UnpackAndDecodeValues
Posted by "Csaba Ringhofer (Code Review)" <ge...@cloudera.org>.
Csaba Ringhofer has posted comments on this change. ( http://gerrit.cloudera.org:8080/14004 )
Change subject: IMPALA-8796: Add unit tests to UnpackAndDecodeValues
......................................................................
Patch Set 5: Code-Review+2
--
To view, visit http://gerrit.cloudera.org:8080/14004
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I363ff9f5d4750231fdc1aa60cf40d90ebb9ba305
Gerrit-Change-Number: 14004
Gerrit-PatchSet: 5
Gerrit-Owner: Daniel Becker <da...@cloudera.com>
Gerrit-Reviewer: Csaba Ringhofer <cs...@cloudera.com>
Gerrit-Reviewer: Daniel Becker <da...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Comment-Date: Fri, 09 Aug 2019 12:17:37 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-8796: Add unit tests to UnpackAndDecodeValues
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/14004 )
Change subject: IMPALA-8796: Add unit tests to UnpackAndDecodeValues
......................................................................
Patch Set 6: Verified+1
--
To view, visit http://gerrit.cloudera.org:8080/14004
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I363ff9f5d4750231fdc1aa60cf40d90ebb9ba305
Gerrit-Change-Number: 14004
Gerrit-PatchSet: 6
Gerrit-Owner: Daniel Becker <da...@cloudera.com>
Gerrit-Reviewer: Csaba Ringhofer <cs...@cloudera.com>
Gerrit-Reviewer: Daniel Becker <da...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Comment-Date: Fri, 09 Aug 2019 16:31:40 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-8796: Add unit tests to UnpackAndDecodeValues
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/14004 )
Change subject: IMPALA-8796: Add unit tests to UnpackAndDecodeValues
......................................................................
Patch Set 2: Verified-1
Build failed: https://jenkins.impala.io/job/gerrit-verify-dryrun/4753/
--
To view, visit http://gerrit.cloudera.org:8080/14004
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I363ff9f5d4750231fdc1aa60cf40d90ebb9ba305
Gerrit-Change-Number: 14004
Gerrit-PatchSet: 2
Gerrit-Owner: Daniel Becker <da...@cloudera.com>
Gerrit-Reviewer: Csaba Ringhofer <cs...@cloudera.com>
Gerrit-Reviewer: Daniel Becker <da...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Comment-Date: Wed, 07 Aug 2019 18:57:23 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-8796: Add unit tests to UnpackAndDecodeValues
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/14004 )
Change subject: IMPALA-8796: Add unit tests to UnpackAndDecodeValues
......................................................................
Patch Set 2:
Build started: https://jenkins.impala.io/job/gerrit-verify-dryrun/4758/ DRY_RUN=true
--
To view, visit http://gerrit.cloudera.org:8080/14004
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I363ff9f5d4750231fdc1aa60cf40d90ebb9ba305
Gerrit-Change-Number: 14004
Gerrit-PatchSet: 2
Gerrit-Owner: Daniel Becker <da...@cloudera.com>
Gerrit-Reviewer: Csaba Ringhofer <cs...@cloudera.com>
Gerrit-Reviewer: Daniel Becker <da...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Comment-Date: Thu, 08 Aug 2019 09:22:22 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-8796: Add unit tests to UnpackAndDecodeValues
Posted by "Daniel Becker (Code Review)" <ge...@cloudera.org>.
Daniel Becker has uploaded a new patch set (#3). ( http://gerrit.cloudera.org:8080/14004 )
Change subject: IMPALA-8796: Add unit tests to UnpackAndDecodeValues
......................................................................
IMPALA-8796: Add unit tests to UnpackAndDecodeValues
Adding unit tests to test BitPacking::UnpackAndDecodeValues. Also
changing the existing BitPacking tests so that they are parametrised
by the output type of the unpacking so we can test different output
types.
Change-Id: I363ff9f5d4750231fdc1aa60cf40d90ebb9ba305
---
M be/src/util/bit-packing-test.cc
M be/src/util/bit-packing.cc
2 files changed, 194 insertions(+), 25 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/04/14004/3
--
To view, visit http://gerrit.cloudera.org:8080/14004
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I363ff9f5d4750231fdc1aa60cf40d90ebb9ba305
Gerrit-Change-Number: 14004
Gerrit-PatchSet: 3
Gerrit-Owner: Daniel Becker <da...@cloudera.com>
Gerrit-Reviewer: Csaba Ringhofer <cs...@cloudera.com>
Gerrit-Reviewer: Daniel Becker <da...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
[Impala-ASF-CR] IMPALA-8796: Add unit tests to UnpackAndDecodeValues
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/14004 )
Change subject: IMPALA-8796: Add unit tests to UnpackAndDecodeValues
......................................................................
IMPALA-8796: Add unit tests to UnpackAndDecodeValues
Adding unit tests to test BitPacking::UnpackAndDecodeValues. Also
changing the existing BitPacking tests so that they are parametrised
by the output type of the unpacking so we can test different output
types.
Change-Id: I363ff9f5d4750231fdc1aa60cf40d90ebb9ba305
Reviewed-on: http://gerrit.cloudera.org:8080/14004
Reviewed-by: Impala Public Jenkins <im...@cloudera.com>
Tested-by: Impala Public Jenkins <im...@cloudera.com>
---
M be/src/util/bit-packing-test.cc
M be/src/util/bit-packing.cc
2 files changed, 195 insertions(+), 25 deletions(-)
Approvals:
Impala Public Jenkins: Looks good to me, approved; Verified
--
To view, visit http://gerrit.cloudera.org:8080/14004
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: I363ff9f5d4750231fdc1aa60cf40d90ebb9ba305
Gerrit-Change-Number: 14004
Gerrit-PatchSet: 7
Gerrit-Owner: Daniel Becker <da...@cloudera.com>
Gerrit-Reviewer: Csaba Ringhofer <cs...@cloudera.com>
Gerrit-Reviewer: Daniel Becker <da...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
[Impala-ASF-CR] IMPALA-8796: Add unit tests to UnpackAndDecodeValues
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/14004 )
Change subject: IMPALA-8796: Add unit tests to UnpackAndDecodeValues
......................................................................
Patch Set 2:
Build failed: https://jenkins.impala.io/job/gerrit-verify-dryrun/4758/
--
To view, visit http://gerrit.cloudera.org:8080/14004
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I363ff9f5d4750231fdc1aa60cf40d90ebb9ba305
Gerrit-Change-Number: 14004
Gerrit-PatchSet: 2
Gerrit-Owner: Daniel Becker <da...@cloudera.com>
Gerrit-Reviewer: Csaba Ringhofer <cs...@cloudera.com>
Gerrit-Reviewer: Daniel Becker <da...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Comment-Date: Thu, 08 Aug 2019 14:12:51 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-8796: Add unit tests to UnpackAndDecodeValues
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/14004 )
Change subject: IMPALA-8796: Add unit tests to UnpackAndDecodeValues
......................................................................
Patch Set 5:
Build Successful
https://jenkins.impala.io/job/gerrit-code-review-checks/4201/ : Initial code review checks passed. Use gerrit-verify-dryrun-external or gerrit-verify-dryrun to run full precommit tests.
--
To view, visit http://gerrit.cloudera.org:8080/14004
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I363ff9f5d4750231fdc1aa60cf40d90ebb9ba305
Gerrit-Change-Number: 14004
Gerrit-PatchSet: 5
Gerrit-Owner: Daniel Becker <da...@cloudera.com>
Gerrit-Reviewer: Csaba Ringhofer <cs...@cloudera.com>
Gerrit-Reviewer: Daniel Becker <da...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Comment-Date: Fri, 09 Aug 2019 10:06:00 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-8796: Add unit tests to UnpackAndDecodeValues
Posted by "Daniel Becker (Code Review)" <ge...@cloudera.org>.
Daniel Becker has posted comments on this change. ( http://gerrit.cloudera.org:8080/14004 )
Change subject: IMPALA-8796: Add unit tests to UnpackAndDecodeValues
......................................................................
Patch Set 3:
I corrected the UBSAN failures.
--
To view, visit http://gerrit.cloudera.org:8080/14004
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I363ff9f5d4750231fdc1aa60cf40d90ebb9ba305
Gerrit-Change-Number: 14004
Gerrit-PatchSet: 3
Gerrit-Owner: Daniel Becker <da...@cloudera.com>
Gerrit-Reviewer: Csaba Ringhofer <cs...@cloudera.com>
Gerrit-Reviewer: Daniel Becker <da...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Comment-Date: Thu, 08 Aug 2019 15:06:49 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-8796: Add unit tests to UnpackAndDecodeValues
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/14004 )
Change subject: IMPALA-8796: Add unit tests to UnpackAndDecodeValues
......................................................................
Patch Set 2:
Build started: https://jenkins.impala.io/job/gerrit-verify-dryrun/4753/ DRY_RUN=true
--
To view, visit http://gerrit.cloudera.org:8080/14004
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I363ff9f5d4750231fdc1aa60cf40d90ebb9ba305
Gerrit-Change-Number: 14004
Gerrit-PatchSet: 2
Gerrit-Owner: Daniel Becker <da...@cloudera.com>
Gerrit-Reviewer: Csaba Ringhofer <cs...@cloudera.com>
Gerrit-Reviewer: Daniel Becker <da...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Comment-Date: Wed, 07 Aug 2019 13:29:24 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-8796: Add unit tests to UnpackAndDecodeValues
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/14004 )
Change subject: IMPALA-8796: Add unit tests to UnpackAndDecodeValues
......................................................................
Patch Set 2:
Build Failed
https://jenkins.impala.io/job/gerrit-code-review-checks/4156/ : Initial code review checks failed. See linked job for details on the failure.
--
To view, visit http://gerrit.cloudera.org:8080/14004
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I363ff9f5d4750231fdc1aa60cf40d90ebb9ba305
Gerrit-Change-Number: 14004
Gerrit-PatchSet: 2
Gerrit-Owner: Daniel Becker <da...@cloudera.com>
Gerrit-Reviewer: Csaba Ringhofer <cs...@cloudera.com>
Gerrit-Reviewer: Daniel Becker <da...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Comment-Date: Tue, 06 Aug 2019 16:27:46 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-8796: Add unit tests to UnpackAndDecodeValues
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/14004 )
Change subject: IMPALA-8796: Add unit tests to UnpackAndDecodeValues
......................................................................
Patch Set 3:
Build Successful
https://jenkins.impala.io/job/gerrit-code-review-checks/4181/ : Initial code review checks passed. Use gerrit-verify-dryrun-external or gerrit-verify-dryrun to run full precommit tests.
--
To view, visit http://gerrit.cloudera.org:8080/14004
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I363ff9f5d4750231fdc1aa60cf40d90ebb9ba305
Gerrit-Change-Number: 14004
Gerrit-PatchSet: 3
Gerrit-Owner: Daniel Becker <da...@cloudera.com>
Gerrit-Reviewer: Csaba Ringhofer <cs...@cloudera.com>
Gerrit-Reviewer: Daniel Becker <da...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Comment-Date: Thu, 08 Aug 2019 15:47:50 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-8796: Add unit tests to UnpackAndDecodeValues
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/14004 )
Change subject: IMPALA-8796: Add unit tests to UnpackAndDecodeValues
......................................................................
Patch Set 6: Code-Review+2
--
To view, visit http://gerrit.cloudera.org:8080/14004
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I363ff9f5d4750231fdc1aa60cf40d90ebb9ba305
Gerrit-Change-Number: 14004
Gerrit-PatchSet: 6
Gerrit-Owner: Daniel Becker <da...@cloudera.com>
Gerrit-Reviewer: Csaba Ringhofer <cs...@cloudera.com>
Gerrit-Reviewer: Daniel Becker <da...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Comment-Date: Fri, 09 Aug 2019 12:24:08 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-8796: Add unit tests to UnpackAndDecodeValues
Posted by "Daniel Becker (Code Review)" <ge...@cloudera.org>.
Daniel Becker has uploaded a new patch set (#4). ( http://gerrit.cloudera.org:8080/14004 )
Change subject: IMPALA-8796: Add unit tests to UnpackAndDecodeValues
......................................................................
IMPALA-8796: Add unit tests to UnpackAndDecodeValues
Adding unit tests to test BitPacking::UnpackAndDecodeValues. Also
changing the existing BitPacking tests so that they are parametrised
by the output type of the unpacking so we can test different output
types.
Change-Id: I363ff9f5d4750231fdc1aa60cf40d90ebb9ba305
---
M be/src/util/bit-packing-test.cc
M be/src/util/bit-packing.cc
2 files changed, 195 insertions(+), 25 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/04/14004/4
--
To view, visit http://gerrit.cloudera.org:8080/14004
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I363ff9f5d4750231fdc1aa60cf40d90ebb9ba305
Gerrit-Change-Number: 14004
Gerrit-PatchSet: 4
Gerrit-Owner: Daniel Becker <da...@cloudera.com>
Gerrit-Reviewer: Csaba Ringhofer <cs...@cloudera.com>
Gerrit-Reviewer: Daniel Becker <da...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
[Impala-ASF-CR] IMPALA-8796: Add unit tests to UnpackAndDecodeValues
Posted by "Daniel Becker (Code Review)" <ge...@cloudera.org>.
Daniel Becker has uploaded a new patch set (#5). ( http://gerrit.cloudera.org:8080/14004 )
Change subject: IMPALA-8796: Add unit tests to UnpackAndDecodeValues
......................................................................
IMPALA-8796: Add unit tests to UnpackAndDecodeValues
Adding unit tests to test BitPacking::UnpackAndDecodeValues. Also
changing the existing BitPacking tests so that they are parametrised
by the output type of the unpacking so we can test different output
types.
Change-Id: I363ff9f5d4750231fdc1aa60cf40d90ebb9ba305
---
M be/src/util/bit-packing-test.cc
M be/src/util/bit-packing.cc
2 files changed, 195 insertions(+), 25 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/04/14004/5
--
To view, visit http://gerrit.cloudera.org:8080/14004
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I363ff9f5d4750231fdc1aa60cf40d90ebb9ba305
Gerrit-Change-Number: 14004
Gerrit-PatchSet: 5
Gerrit-Owner: Daniel Becker <da...@cloudera.com>
Gerrit-Reviewer: Csaba Ringhofer <cs...@cloudera.com>
Gerrit-Reviewer: Daniel Becker <da...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
[Impala-ASF-CR] IMPALA-8796: Add unit tests to UnpackAndDecodeValues
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/14004 )
Change subject: IMPALA-8796: Add unit tests to UnpackAndDecodeValues
......................................................................
Patch Set 4:
Build Successful
https://jenkins.impala.io/job/gerrit-code-review-checks/4200/ : Initial code review checks passed. Use gerrit-verify-dryrun-external or gerrit-verify-dryrun to run full precommit tests.
--
To view, visit http://gerrit.cloudera.org:8080/14004
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I363ff9f5d4750231fdc1aa60cf40d90ebb9ba305
Gerrit-Change-Number: 14004
Gerrit-PatchSet: 4
Gerrit-Owner: Daniel Becker <da...@cloudera.com>
Gerrit-Reviewer: Csaba Ringhofer <cs...@cloudera.com>
Gerrit-Reviewer: Daniel Becker <da...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Comment-Date: Fri, 09 Aug 2019 09:58:25 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-8796: Add unit tests to UnpackAndDecodeValues
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/14004 )
Change subject: IMPALA-8796: Add unit tests to UnpackAndDecodeValues
......................................................................
Patch Set 2:
Build Successful
https://jenkins.impala.io/job/gerrit-code-review-checks/4172/ : Initial code review checks passed. Use gerrit-verify-dryrun-external or gerrit-verify-dryrun to run full precommit tests.
--
To view, visit http://gerrit.cloudera.org:8080/14004
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I363ff9f5d4750231fdc1aa60cf40d90ebb9ba305
Gerrit-Change-Number: 14004
Gerrit-PatchSet: 2
Gerrit-Owner: Daniel Becker <da...@cloudera.com>
Gerrit-Reviewer: Csaba Ringhofer <cs...@cloudera.com>
Gerrit-Reviewer: Daniel Becker <da...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Comment-Date: Wed, 07 Aug 2019 14:05:04 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-8796: Add unit tests to UnpackAndDecodeValues
Posted by "Daniel Becker (Code Review)" <ge...@cloudera.org>.
Daniel Becker has posted comments on this change. ( http://gerrit.cloudera.org:8080/14004 )
Change subject: IMPALA-8796: Add unit tests to UnpackAndDecodeValues
......................................................................
Patch Set 2:
It seems the build failed for unrelated reasons.
--
To view, visit http://gerrit.cloudera.org:8080/14004
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I363ff9f5d4750231fdc1aa60cf40d90ebb9ba305
Gerrit-Change-Number: 14004
Gerrit-PatchSet: 2
Gerrit-Owner: Daniel Becker <da...@cloudera.com>
Gerrit-Reviewer: Csaba Ringhofer <cs...@cloudera.com>
Gerrit-Reviewer: Daniel Becker <da...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Comment-Date: Wed, 07 Aug 2019 13:13:51 +0000
Gerrit-HasComments: No