You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@cassandra.apache.org by "Jon Hermes (JIRA)" <ji...@apache.org> on 2011/05/26 21:14:49 UTC
[jira] [Created] (CASSANDRA-2713) Null strategy_options on a KsDef
leads to an NPE.
Null strategy_options on a KsDef leads to an NPE.
-------------------------------------------------
Key: CASSANDRA-2713
URL: https://issues.apache.org/jira/browse/CASSANDRA-2713
Project: Cassandra
Issue Type: Bug
Affects Versions: 0.8.0 beta 2
Reporter: Jon Hermes
Assignee: Jon Hermes
Priority: Minor
Fix For: 0.8.0
For add/update keyspace, a KsDef with null strategy_options will cause an NPE.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (CASSANDRA-2713) Null strategy_options on a
KsDef leads to an NPE.
Posted by "Cathy Daw (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/CASSANDRA-2713?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13042407#comment-13042407 ]
Cathy Daw commented on CASSANDRA-2713:
--------------------------------------
I verified this fix by dropping in the c* 0.8.0 jar file into brisk.
Can we get this merged to the Cassandra 0.8 branch since brisk builds its jar file from there?
> Null strategy_options on a KsDef leads to an NPE.
> -------------------------------------------------
>
> Key: CASSANDRA-2713
> URL: https://issues.apache.org/jira/browse/CASSANDRA-2713
> Project: Cassandra
> Issue Type: Bug
> Affects Versions: 0.8.0 beta 2
> Reporter: Jon Hermes
> Assignee: Jon Hermes
> Priority: Minor
> Fix For: 0.8.0
>
> Attachments: 2713-allow.txt, 2713-disallow.txt
>
>
> For add/update keyspace, a KsDef with null strategy_options will cause an NPE.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (CASSANDRA-2713) Null strategy_options on a KsDef
leads to an NPE.
Posted by "Jon Hermes (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/CASSANDRA-2713?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Jon Hermes updated CASSANDRA-2713:
----------------------------------
Attachment: 2713-disallow.txt
2713-allow.txt
Attaching two patches.
`2713-allow` will allow nulls and default them to an empty set on KSMD creation.
`2713-disallow` will explicitly block nulls during ThriftValidation.
Both avoid NPEs and either are technically correct. Looks like we need to allow nulls because of upgrade issues coming from 0.7.
> Null strategy_options on a KsDef leads to an NPE.
> -------------------------------------------------
>
> Key: CASSANDRA-2713
> URL: https://issues.apache.org/jira/browse/CASSANDRA-2713
> Project: Cassandra
> Issue Type: Bug
> Affects Versions: 0.8.0 beta 2
> Reporter: Jon Hermes
> Assignee: Jon Hermes
> Priority: Minor
> Fix For: 0.8.0
>
> Attachments: 2713-allow.txt, 2713-disallow.txt
>
>
> For add/update keyspace, a KsDef with null strategy_options will cause an NPE.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (CASSANDRA-2713) Null strategy_options on a
KsDef leads to an NPE.
Posted by "Jonathan Ellis (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/CASSANDRA-2713?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13042561#comment-13042561 ]
Jonathan Ellis commented on CASSANDRA-2713:
-------------------------------------------
merged to 0.8 branch in r1130370
> Null strategy_options on a KsDef leads to an NPE.
> -------------------------------------------------
>
> Key: CASSANDRA-2713
> URL: https://issues.apache.org/jira/browse/CASSANDRA-2713
> Project: Cassandra
> Issue Type: Bug
> Affects Versions: 0.8.0 beta 2
> Reporter: Jon Hermes
> Assignee: Jon Hermes
> Priority: Minor
> Fix For: 0.8.0
>
> Attachments: 2713-allow.txt, 2713-disallow.txt
>
>
> For add/update keyspace, a KsDef with null strategy_options will cause an NPE.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Resolved] (CASSANDRA-2713) Null strategy_options on a KsDef
leads to an NPE.
Posted by "Jonathan Ellis (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/CASSANDRA-2713?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Jonathan Ellis resolved CASSANDRA-2713.
---------------------------------------
Resolution: Fixed
Reviewer: jbellis
committed the "allow" approach
> Null strategy_options on a KsDef leads to an NPE.
> -------------------------------------------------
>
> Key: CASSANDRA-2713
> URL: https://issues.apache.org/jira/browse/CASSANDRA-2713
> Project: Cassandra
> Issue Type: Bug
> Affects Versions: 0.8.0 beta 2
> Reporter: Jon Hermes
> Assignee: Jon Hermes
> Priority: Minor
> Fix For: 0.8.0
>
> Attachments: 2713-allow.txt, 2713-disallow.txt
>
>
> For add/update keyspace, a KsDef with null strategy_options will cause an NPE.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira