You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@kudu.apache.org by "Todd Lipcon (Code Review)" <ge...@cloudera.org> on 2016/11/30 20:44:00 UTC
[kudu-CR] KUDU-1754. Add a warning to the Java API docs that columns default NOT NULL
Hello Dan Burkert,
I'd like you to do a code review. Please visit
http://gerrit.cloudera.org:8080/5283
to review the following change.
Change subject: KUDU-1754. Add a warning to the Java API docs that columns default NOT NULL
......................................................................
KUDU-1754. Add a warning to the Java API docs that columns default NOT NULL
Change-Id: Ia5589746f8b618874326fce69532578468e8ca4a
---
M java/kudu-client/src/main/java/org/apache/kudu/ColumnSchema.java
1 file changed, 7 insertions(+), 0 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/83/5283/1
--
To view, visit http://gerrit.cloudera.org:8080/5283
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: Ia5589746f8b618874326fce69532578468e8ca4a
Gerrit-PatchSet: 1
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Todd Lipcon <to...@apache.org>
Gerrit-Reviewer: Dan Burkert <da...@apache.org>
[kudu-CR] KUDU-1754. Add a warning to the Java API docs that columns default NOT NULL
Posted by "Dan Burkert (Code Review)" <ge...@cloudera.org>.
Dan Burkert has posted comments on this change.
Change subject: KUDU-1754. Add a warning to the Java API docs that columns default NOT NULL
......................................................................
Patch Set 1: Code-Review+2
--
To view, visit http://gerrit.cloudera.org:8080/5283
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ia5589746f8b618874326fce69532578468e8ca4a
Gerrit-PatchSet: 1
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Todd Lipcon <to...@apache.org>
Gerrit-Reviewer: Dan Burkert <da...@apache.org>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-HasComments: No
[kudu-CR] KUDU-1754. Add a warning to the Java API docs that columns default NOT NULL
Posted by "Todd Lipcon (Code Review)" <ge...@cloudera.org>.
Todd Lipcon has submitted this change and it was merged.
Change subject: KUDU-1754. Add a warning to the Java API docs that columns default NOT NULL
......................................................................
KUDU-1754. Add a warning to the Java API docs that columns default NOT NULL
Change-Id: Ia5589746f8b618874326fce69532578468e8ca4a
Reviewed-on: http://gerrit.cloudera.org:8080/5283
Reviewed-by: Dan Burkert <da...@apache.org>
Tested-by: Kudu Jenkins
---
M java/kudu-client/src/main/java/org/apache/kudu/ColumnSchema.java
1 file changed, 7 insertions(+), 0 deletions(-)
Approvals:
Dan Burkert: Looks good to me, approved
Kudu Jenkins: Verified
--
To view, visit http://gerrit.cloudera.org:8080/5283
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Ia5589746f8b618874326fce69532578468e8ca4a
Gerrit-PatchSet: 2
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Todd Lipcon <to...@apache.org>
Gerrit-Reviewer: Dan Burkert <da...@apache.org>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Todd Lipcon <to...@apache.org>