You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@helix.apache.org by Kanak Biscuitwala <ka...@apache.org> on 2013/10/22 23:29:18 UTC
Review Request 14858: [HELIX-274] Verify FULL_AUTO tagged node behavior,
fix bug in AutoRebalancer
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/14858/
-----------------------------------------------------------
Review request for helix, Zhen Zhang and Kishore Gopalakrishna.
Bugs: HELIX-274
Repository: helix-git
Description
-------
commit f3ba195263305fd2e9cb88907a80d89858b062a8
Author: Kanak Biscuitwala <ka...@apache.org>
Date: Tue Oct 22 14:17:03 2013 -0700
[HELIX-274] Verify FULL_AUTO tagged node behavior, fix bug in AutoRebalancer
:100644 100644 9564e35... 3eb258b... M helix-core/src/main/java/org/apache/helix/controller/rebalancer/AutoRebalancer.java
:000000 100644 0000000... b453c53... A helix-core/src/test/java/org/apache/helix/integration/TestFullAutoNodeTagging.java
Diffs
-----
helix-core/src/main/java/org/apache/helix/controller/rebalancer/AutoRebalancer.java 9564e35
helix-core/src/test/java/org/apache/helix/integration/TestFullAutoNodeTagging.java PRE-CREATION
Diff: https://reviews.apache.org/r/14858/diff/
Testing
-------
Existing tests pass locally, new test passes locally.
Thanks,
Kanak Biscuitwala
Re: Review Request 14858: [HELIX-274] Verify FULL_AUTO tagged node behavior,
fix bug in AutoRebalancer
Posted by Kishore Gopalakrishna <ki...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/14858/#review27349
-----------------------------------------------------------
Ship it!
Ship It!
- Kishore Gopalakrishna
On Oct. 22, 2013, 9:29 p.m., Kanak Biscuitwala wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/14858/
> -----------------------------------------------------------
>
> (Updated Oct. 22, 2013, 9:29 p.m.)
>
>
> Review request for helix, Zhen Zhang and Kishore Gopalakrishna.
>
>
> Bugs: HELIX-274
>
>
> Repository: helix-git
>
>
> Description
> -------
>
> commit f3ba195263305fd2e9cb88907a80d89858b062a8
> Author: Kanak Biscuitwala <ka...@apache.org>
> Date: Tue Oct 22 14:17:03 2013 -0700
>
> [HELIX-274] Verify FULL_AUTO tagged node behavior, fix bug in AutoRebalancer
>
> :100644 100644 9564e35... 3eb258b... M helix-core/src/main/java/org/apache/helix/controller/rebalancer/AutoRebalancer.java
> :000000 100644 0000000... b453c53... A helix-core/src/test/java/org/apache/helix/integration/TestFullAutoNodeTagging.java
>
>
> Diffs
> -----
>
> helix-core/src/main/java/org/apache/helix/controller/rebalancer/AutoRebalancer.java 9564e35
> helix-core/src/test/java/org/apache/helix/integration/TestFullAutoNodeTagging.java PRE-CREATION
>
> Diff: https://reviews.apache.org/r/14858/diff/
>
>
> Testing
> -------
>
> Existing tests pass locally, new test passes locally.
>
>
> Thanks,
>
> Kanak Biscuitwala
>
>
Re: Review Request 14858: [HELIX-274] Verify FULL_AUTO tagged node behavior,
fix bug in AutoRebalancer
Posted by Zhen Zhang <ne...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/14858/#review27359
-----------------------------------------------------------
Ship it!
Ship It!
- Zhen Zhang
On Oct. 22, 2013, 9:29 p.m., Kanak Biscuitwala wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/14858/
> -----------------------------------------------------------
>
> (Updated Oct. 22, 2013, 9:29 p.m.)
>
>
> Review request for helix, Zhen Zhang and Kishore Gopalakrishna.
>
>
> Bugs: HELIX-274
>
>
> Repository: helix-git
>
>
> Description
> -------
>
> commit f3ba195263305fd2e9cb88907a80d89858b062a8
> Author: Kanak Biscuitwala <ka...@apache.org>
> Date: Tue Oct 22 14:17:03 2013 -0700
>
> [HELIX-274] Verify FULL_AUTO tagged node behavior, fix bug in AutoRebalancer
>
> :100644 100644 9564e35... 3eb258b... M helix-core/src/main/java/org/apache/helix/controller/rebalancer/AutoRebalancer.java
> :000000 100644 0000000... b453c53... A helix-core/src/test/java/org/apache/helix/integration/TestFullAutoNodeTagging.java
>
>
> Diffs
> -----
>
> helix-core/src/main/java/org/apache/helix/controller/rebalancer/AutoRebalancer.java 9564e35
> helix-core/src/test/java/org/apache/helix/integration/TestFullAutoNodeTagging.java PRE-CREATION
>
> Diff: https://reviews.apache.org/r/14858/diff/
>
>
> Testing
> -------
>
> Existing tests pass locally, new test passes locally.
>
>
> Thanks,
>
> Kanak Biscuitwala
>
>