You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@airflow.apache.org by GitBox <gi...@apache.org> on 2021/11/27 12:02:25 UTC
[GitHub] [airflow] anurag-rajawat opened a new pull request #19853: Remove some more redundant parentheses
anurag-rajawat opened a new pull request #19853:
URL: https://github.com/apache/airflow/pull/19853
<!--
Thank you for contributing! Please make sure that your code changes
are covered with tests. And in case of new features or big changes
remember to adjust the documentation.
Feel free to ping committers for the review!
In case of existing issue, reference it using one of the following:
closes: #ISSUE
related: #ISSUE
How to write a good git commit message:
http://chris.beams.io/posts/git-commit/
-->
---
**^ Add meaningful description above**
Read the **[Pull Request Guidelines](https://github.com/apache/airflow/blob/main/CONTRIBUTING.rst#pull-request-guidelines)** for more information.
In case of fundamental code change, Airflow Improvement Proposal ([AIP](https://cwiki.apache.org/confluence/display/AIRFLOW/Airflow+Improvements+Proposals)) is needed.
In case of a new dependency, check compliance with the [ASF 3rd Party License Policy](https://www.apache.org/legal/resolved.html#category-x).
In case of backwards incompatible changes please leave a note in [UPDATING.md](https://github.com/apache/airflow/blob/main/UPDATING.md).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] uranusjr commented on a change in pull request #19853: Remove some more redundant parentheses
Posted by GitBox <gi...@apache.org>.
uranusjr commented on a change in pull request #19853:
URL: https://github.com/apache/airflow/pull/19853#discussion_r757777109
##########
File path: airflow/_vendor/connexion/operations/openapi.py
##########
@@ -197,7 +197,7 @@ def example_response(self, status_code=None, content_type=None):
except (KeyError, IndexError):
pass
try:
- return (deep_get(self._responses, example_path), status_code)
+ return deep_get(self._responses, example_path), status_code
Review comment:
I’d prefer keeping this, or split this into two lines
```python
response = deep_get(self._responses, example_path)
return response, status_code
```
otherwise it is too easy to miss this is actually returning a tuple.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] potiuk closed pull request #19853: Remove some more redundant parentheses
Posted by GitBox <gi...@apache.org>.
potiuk closed pull request #19853:
URL: https://github.com/apache/airflow/pull/19853
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] anurag-rajawat commented on a change in pull request #19853: Remove some more redundant parentheses
Posted by GitBox <gi...@apache.org>.
anurag-rajawat commented on a change in pull request #19853:
URL: https://github.com/apache/airflow/pull/19853#discussion_r757778469
##########
File path: airflow/_vendor/connexion/operations/openapi.py
##########
@@ -197,7 +197,7 @@ def example_response(self, status_code=None, content_type=None):
except (KeyError, IndexError):
pass
try:
- return (deep_get(self._responses, example_path), status_code)
+ return deep_get(self._responses, example_path), status_code
Review comment:
I'll revert it as it was.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] boring-cyborg[bot] commented on pull request #19853: Remove some more redundant parentheses
Posted by GitBox <gi...@apache.org>.
boring-cyborg[bot] commented on pull request #19853:
URL: https://github.com/apache/airflow/pull/19853#issuecomment-980547804
Congratulations on your first Pull Request and welcome to the Apache Airflow community! If you have any issues or are unsure about any anything please check our Contribution Guide (https://github.com/apache/airflow/blob/main/CONTRIBUTING.rst)
Here are some useful points:
- Pay attention to the quality of your code (flake8, mypy and type annotations). Our [pre-commits]( https://github.com/apache/airflow/blob/main/STATIC_CODE_CHECKS.rst#prerequisites-for-pre-commit-hooks) will help you with that.
- In case of a new feature add useful documentation (in docstrings or in `docs/` directory). Adding a new operator? Check this short [guide](https://github.com/apache/airflow/blob/main/docs/apache-airflow/howto/custom-operator.rst) Consider adding an example DAG that shows how users should use it.
- Consider using [Breeze environment](https://github.com/apache/airflow/blob/main/BREEZE.rst) for testing locally, it’s a heavy docker but it ships with a working Airflow and a lot of integrations.
- Be patient and persistent. It might take some time to get a review or get the final approval from Committers.
- Please follow [ASF Code of Conduct](https://www.apache.org/foundation/policies/conduct) for all communication including (but not limited to) comments on Pull Requests, Mailing list and Slack.
- Be sure to read the [Airflow Coding style]( https://github.com/apache/airflow/blob/main/CONTRIBUTING.rst#coding-style-and-best-practices).
Apache Airflow is a community-driven project and together we are making it better 🚀.
In case of doubts contact the developers at:
Mailing List: dev@airflow.apache.org
Slack: https://s.apache.org/airflow-slack
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org