You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@arrow.apache.org by GitBox <gi...@apache.org> on 2020/12/06 11:44:56 UTC
[GitHub] [arrow] zhulongcheng opened a new pull request #8855: ARROW-9630: [Go] Export JSON reader and writer
zhulongcheng opened a new pull request #8855:
URL: https://github.com/apache/arrow/pull/8855
Move the JSON reader and writer out of the internal package.
This allows them to be imported by other projects.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] fsaintjacques commented on pull request #8855: ARROW-9630: [Go] Export JSON reader and writer
Posted by GitBox <gi...@apache.org>.
fsaintjacques commented on pull request #8855:
URL: https://github.com/apache/arrow/pull/8855#issuecomment-740820889
This is not a JSON reader like the C++'s json reader. This is only meant to support the internal custom format used for integration testing between implementation languages.
To me, this package should stay private.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] fsaintjacques commented on pull request #8855: ARROW-9630: [Go] Export JSON reader and writer
Posted by GitBox <gi...@apache.org>.
fsaintjacques commented on pull request #8855:
URL: https://github.com/apache/arrow/pull/8855#issuecomment-741828481
Then I can confirm that it won't work the way you expect it to. It expects a [single giant](https://github.com/apache/arrow/blob/master/go/arrow/internal/arrjson/reader.go#L39-L45) json object.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] zhulongcheng commented on pull request #8855: ARROW-9630: [Go] Export JSON reader and writer
Posted by GitBox <gi...@apache.org>.
zhulongcheng commented on pull request #8855:
URL: https://github.com/apache/arrow/pull/8855#issuecomment-741852201
Thanks for the help, now I know this is not for JSON data sources.
Sorry, I am new to Arrow. :)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] github-actions[bot] commented on pull request #8855: ARROW-9630: [Go] Export JSON reader and writer
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on pull request #8855:
URL: https://github.com/apache/arrow/pull/8855#issuecomment-739491255
https://issues.apache.org/jira/browse/ARROW-9630
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] zhulongcheng commented on pull request #8855: ARROW-9630: [Go] Export JSON reader and writer
Posted by GitBox <gi...@apache.org>.
zhulongcheng commented on pull request #8855:
URL: https://github.com/apache/arrow/pull/8855#issuecomment-741827218
Thanks.
The use case is to read JSON data source into the arrow record batch. Like python's [JSON reader](http://arrow.apache.org/docs/python/json.html) does.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] xhochy commented on pull request #8855: ARROW-9630: [Go] Export JSON reader and writer
Posted by GitBox <gi...@apache.org>.
xhochy commented on pull request #8855:
URL: https://github.com/apache/arrow/pull/8855#issuecomment-740901677
> This is not a JSON reader like the C++'s json reader. This is only meant to support the internal custom format used for integration testing between implementation languages.
>
> To me, this package should stay private.
Stronly support what @fsaintjacques said, we should rather get https://github.com/apache/arrow/pull/7110 restart to have an official human-readable serialization of the schema.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] zhulongcheng closed pull request #8855: ARROW-9630: [Go] Export JSON reader and writer
Posted by GitBox <gi...@apache.org>.
zhulongcheng closed pull request #8855:
URL: https://github.com/apache/arrow/pull/8855
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow] xhochy edited a comment on pull request #8855: ARROW-9630: [Go] Export JSON reader and writer
Posted by GitBox <gi...@apache.org>.
xhochy edited a comment on pull request #8855:
URL: https://github.com/apache/arrow/pull/8855#issuecomment-740901677
> This is not a JSON reader like the C++'s json reader. This is only meant to support the internal custom format used for integration testing between implementation languages.
>
> To me, this package should stay private.
Strongly support what @fsaintjacques said, we should rather get https://github.com/apache/arrow/pull/7110 restart to have an official human-readable serialization of the schema.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org